Linux Trace Kernel
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: liubaolin <liubaolin12138@163.com>
Cc: almaz.alexandrovich@paragon-software.com, mhiramat@kernel.org,
	mathieu.desnoyers@efficios.com, linux-kernel@vger.kernel.org,
	ntfs3@lists.linux.dev, linux-trace-kernel@vger.kernel.org,
	liubaolin12138@gmail.com, Baolin Liu <liubaolin@kylinos.cn>
Subject: Re: [PATCH v1 v1 2/7] ntfs3: add namei tracepoints
Date: Thu, 23 Jul 2026 10:17:35 -0400	[thread overview]
Message-ID: <20260723101735.377f355c@gandalf.local.home> (raw)
In-Reply-To: <a36a7376-d750-4f07-a626-e916fe77ff77@163.com>

On Thu, 23 Jul 2026 17:30:33 +0800
liubaolin <liubaolin12138@163.com> wrote:

> Dear Steve,
>     dentry->d_name.len is the qstr length and does not include the 
> trailing NUL, so it corresponds to strlen(dentry->d_name.name), rather 
> than strlen(dentry->d_name.name) + 1.

But it is still tightly coupled with the actual length of the name.

> If you think the extra name_len field here is unnecessary, I can submit 
> a v2 patch to drop it. Looking forward to your feedback.

I'm wondering what the purpose of it is for. The length of the string is
also stored in part of the meta data of the event which can be retrieved
via:

  __get_dynnamic_array_len(name)

Although that will be strlen(name) + 1.

-- Steve

  reply	other threads:[~2026-07-23 14:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17  3:22 [PATCH v1 0/7] ntfs3: add tracepoints for core filesystem paths Baolin Liu
2026-07-17  3:22 ` [PATCH v1 v1 1/7] ntfs3: add mount and log replay tracepoints Baolin Liu
2026-07-17  3:22 ` [PATCH v1 v1 2/7] ntfs3: add namei tracepoints Baolin Liu
2026-07-21 21:09   ` Steven Rostedt
2026-07-23  9:30     ` liubaolin
2026-07-23 14:17       ` Steven Rostedt [this message]
2026-07-17  3:22 ` [PATCH v1 v1 3/7] ntfs3: add create inode tracepoint Baolin Liu
2026-07-17  3:22 ` [PATCH v1 v1 4/7] ntfs3: add directory index tracepoints Baolin Liu
2026-07-17  3:22 ` [PATCH v1 v1 5/7] ntfs3: add allocation tracepoints Baolin Liu
2026-07-17  3:22 ` [PATCH v1 v1 6/7] ntfs3: add iomap tracepoints Baolin Liu
2026-07-17  3:22 ` [PATCH v1 v1 7/7] ntfs3: add file I/O tracepoints Baolin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260723101735.377f355c@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=liubaolin12138@163.com \
    --cc=liubaolin12138@gmail.com \
    --cc=liubaolin@kylinos.cn \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=ntfs3@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox