From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDD7746D556 for ; Tue, 4 Aug 2026 14:04:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.71 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785852251; cv=none; b=JFNdyrnr98fZN8Rzds44HepcU/mIHQdhoEU9vTrWlZzK4XuAhRcGzwHMo9bak+ueLXR0za23oLeQeUvaXzgIPnPAD03YPE8aVWLHl9S7snCkvQMJZmVYIn0Drw7Dcm0pT+KRhBa8rr933vDbx3y4Hc0vxe1PdkAg6spfeSUc80Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785852251; c=relaxed/simple; bh=IhGaRiD59PVZUrhDaF5GXLlfF/a7erg0cl0Z2aB4b0s=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Zm9vLTdSA5H5AjX61JLX8c3mlph8+PZk2zb6v40SMYO0sTn4ugElq+Tr2t+Uhtn3zXrmHblcAiBdQUPmBNyo5narac9bcd+ZBLHI1booakuKvC3RsYLNxZCiIArj/hX6n/ptV53Ic1kgwa4ZCLA1ia+PclUma+RSf2/O3j1kYHo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--vdonnefort.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=lN9UeM+O; arc=none smtp.client-ip=209.85.221.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--vdonnefort.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lN9UeM+O" Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-47f81362fb1so3090962f8f.1 for ; Tue, 04 Aug 2026 07:04:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1785852247; x=1786457047; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ins1d4409psvT0l6jw8ETMSTSJtrHpDMH4MtXmtJ23M=; b=lN9UeM+OVyP2Ud4yjLLdqJJkMd9iJSPFMurgmEkt4rd3BJzE9xaOnK2JXl5xZXOypa RZ+O62o9hict0oNQFxHSGquUvUxBku8SMrVIBHcxtxtzbr3bRTDTmJ7vr/HRqWrnVdcG WlOPDKaJ+kKsYxnGRH5xf7y+Pl7hYeDasgwohVPYqyCF5Rp+DXcKAOJ2jgdW+OgJe3ua n83Hecu6/Hyz+86Tb3QdfOwNMmcru4mm1jxLJyQSiPYWPrctVvksYkhHD7ez92TP+2b6 0cJzv43OlFGYLWYLszoxqTBIUisbFf7RtgjZfZuYvQy3QjgyWyB0dS5jp3F+AHquz+N9 KGqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785852247; x=1786457047; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ins1d4409psvT0l6jw8ETMSTSJtrHpDMH4MtXmtJ23M=; b=WbKKbZ37Ha50hXey5dZUg5I6qa00ySQna6VgjkqisH1kM4N5j6Ch0n8bxmYG9+puOC Gj/usvYJMBFwqkBWc7tT+D2V1skMC3hXCS5gPQwM47/HYqznXP2ho6XL8ZUkiIULAnTK SiZcm9D2bzp5TsPblRK7xQoYu9aZctVasGURvR9QYP5GU1t6KDORLm2etl/xUE28k7BB +6A1bb576GXQ1smIhIHpGc/SseGz0LokZbHp5qS9RHIlIkpwsOfWJ0XTkppVTdm+mvWY L6d+unmRK8NK4ecOqT8Z2uG90maBA+Rrn6iLB28lS8eSfj0pSUI4PqEaLj1NCP+S3+4h ckLQ== X-Forwarded-Encrypted: i=1; AHgh+Ro0Sg18osvqwcI3cXeEt4cJ9fnmScJg3ZHmvHj1LAYdhUXxIbL7AlfMnGuuuRvC+Ba68FyLsR3qsu15HYblKE4hoNc=@vger.kernel.org X-Gm-Message-State: AOJu0Ywn44mE3wb8wpos6wQA4QUnqLphJBEKJFFPevcMN8dczWfmrBOW rPQkLDHk777U2+04O7nl/dtfpz8Ahk6+LvYWsP998V2YrP4/DroOzILpqn+lnOqoQJRLHuXDJ3o TSyleKnUNFVOZMJGeFF/QCg== X-Received: from wrsc12.prod.google.com ([2002:adf:fb4c:0:b0:47f:8f3e:9a28]) (user=vdonnefort job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:4e94:b0:493:e365:ace9 with SMTP id 5b1f17b1804b1-4980ee9ce83mr275704225e9.11.1785852246693; Tue, 04 Aug 2026 07:04:06 -0700 (PDT) Date: Tue, 4 Aug 2026 15:03:28 +0100 In-Reply-To: <20260804140333.797210-1-vdonnefort@google.com> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260804140333.797210-1-vdonnefort@google.com> X-Mailer: git-send-email 2.55.0.571.g244d577d93-goog Message-ID: <20260804140333.797210-14-vdonnefort@google.com> Subject: [PATCH v4 13/18] tracing/remotes: Add dump_on_panic tracefs file From: Vincent Donnefort To: rostedt@goodmis.org, mhiramat@kernel.org, linux-trace-kernel@vger.kernel.org Cc: mathieu.desnoyers@efficios.com, kernel-team@android.com, linux-kernel@vger.kernel.org, Vincent Donnefort Content-Type: text/plain; charset="UTF-8" When enabled, dump_on_panic will dump the content of the trace remote buffer if the system panics. Signed-off-by: Vincent Donnefort diff --git a/kernel/trace/trace_remote.c b/kernel/trace/trace_remote.c index 2421550d5601..9077b488e584 100644 --- a/kernel/trace/trace_remote.c +++ b/kernel/trace/trace_remote.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -22,6 +23,7 @@ enum tri_type { TRI_CONSUMING, TRI_NONCONSUMING, TRI_DMESG, + TRI_PANIC, }; struct trace_remote_iterator { @@ -59,6 +61,9 @@ struct trace_remote { unsigned int poll_cnt; unsigned int poll_ms; bool tracing_on; + bool panic_on; + struct notifier_block panic_notifier; + struct trace_remote_iterator *panic_iter; struct delayed_work poll_work; }; @@ -71,10 +76,15 @@ static bool trace_remote_loaded(struct trace_remote *remote) return !!remote->trace_buffer; } +static void trace_remote_unload(struct trace_remote *remote); +static int trace_remote_panic_load(struct trace_remote *remote); +static void trace_remote_panic_unload(struct trace_remote *remote); + static int trace_remote_load(struct trace_remote *remote) { struct ring_buffer_remote *rb_remote = &remote->rb_remote; struct trace_buffer_desc *desc; + int ret = 0; lockdep_assert_held(&remote->lock); @@ -89,15 +99,28 @@ static int trace_remote_load(struct trace_remote *remote) rb_remote->swap_reader_page = remote->cbs->swap_reader_page; rb_remote->priv = remote->priv; rb_remote->reset = remote->cbs->reset; + remote->trace_buffer_desc = desc; remote->trace_buffer = ring_buffer_alloc_remote(rb_remote); if (!remote->trace_buffer) { remote->cbs->unload_trace_buffer(desc, remote->priv); return -ENOMEM; } - remote->trace_buffer_desc = desc; + if (remote->panic_on) { + ret = trace_remote_panic_load(remote); + if (ret) + trace_remote_unload(remote); + } - return 0; + return ret; +} + +static void trace_remote_unload(struct trace_remote *remote) +{ + trace_remote_panic_unload(remote); + ring_buffer_free(remote->trace_buffer); + remote->trace_buffer = NULL; + remote->cbs->unload_trace_buffer(remote->trace_buffer_desc, remote->priv); } static void trace_remote_try_unload(struct trace_remote *remote) @@ -115,9 +138,7 @@ static void trace_remote_try_unload(struct trace_remote *remote) if (!ring_buffer_empty(remote->trace_buffer)) return; - ring_buffer_free(remote->trace_buffer); - remote->trace_buffer = NULL; - remote->cbs->unload_trace_buffer(remote->trace_buffer_desc, remote->priv); + trace_remote_unload(remote); } static int trace_remote_enable_tracing(struct trace_remote *remote) @@ -434,58 +455,68 @@ static void trace_remote_dec_poll(struct trace_remote *remote) static struct trace_remote_iterator *trace_remote_iter(struct trace_remote *remote, int cpu, enum tri_type type) { - struct trace_remote_iterator *iter = NULL; + struct trace_remote_iterator *iter __free(kfree) = kzalloc_obj(*iter); int ret; lockdep_assert_held(&remote->lock); - if (type == TRI_NONCONSUMING && !trace_remote_loaded(remote)) - return NULL; + if (!iter) + return ERR_PTR(-ENOMEM); - ret = trace_remote_get(remote, cpu); - if (ret) - return ERR_PTR(ret); + switch (type) { + case TRI_NONCONSUMING: + if (!trace_remote_loaded(remote)) + return NULL; + fallthrough; + case TRI_CONSUMING: + case TRI_DMESG: + ret = trace_remote_get(remote, cpu); + if (ret) + return ERR_PTR(ret); + break; + case TRI_PANIC: + break; + } if (!trace_remote_has_cpu(remote, cpu)) { ret = -ENODEV; goto err; } - iter = kzalloc_obj(*iter); - if (iter) { - iter->remote = remote; - iter->cpu = cpu; - iter->type = type; - trace_seq_init(&iter->seq); + iter->remote = remote; + iter->cpu = cpu; + iter->type = type; + trace_seq_init(&iter->seq); - switch (type) { - case TRI_DMESG: - /* only one dmesg iter allowed */ - if (WARN_ON_ONCE(remote->dmesg)) { - ret = -EBUSY; - break; - } - smp_store_release(&remote->dmesg, iter); - fallthrough; - case TRI_CONSUMING: - trace_remote_inc_poll(remote); - break; - case TRI_NONCONSUMING: - ret = __alloc_ring_buffer_iter(iter, cpu); - break; + switch (type) { + case TRI_DMESG: + /* only one dmesg iter allowed */ + if (WARN_ON_ONCE(remote->dmesg)) { + ret = -EBUSY; + goto err; } - + smp_store_release(&remote->dmesg, iter); + fallthrough; + case TRI_CONSUMING: + trace_remote_inc_poll(remote); + break; + case TRI_PANIC: + case TRI_NONCONSUMING: + ret = __alloc_ring_buffer_iter(iter, cpu); if (ret) goto err; - - return iter; + break; } - ret = -ENOMEM; + + return no_free_ptr(iter); err: - kfree(iter); - trace_remote_put(remote); - + switch (type) { + case TRI_PANIC: + break; + default: + trace_remote_put(remote); + } return ERR_PTR(ret); } @@ -508,14 +539,18 @@ static void trace_remote_iter_free(struct trace_remote_iterator *iter) fallthrough; case TRI_CONSUMING: trace_remote_dec_poll(remote); + trace_remote_put(remote); break; case TRI_NONCONSUMING: + __free_ring_buffer_iter(iter, iter->cpu); + trace_remote_put(remote); + break; + case TRI_PANIC: __free_ring_buffer_iter(iter, iter->cpu); break; } kfree(iter); - trace_remote_put(remote); } static bool trace_remote_iter_is_consuming(struct trace_remote_iterator *iter) @@ -989,6 +1024,117 @@ static int dmesg_show(struct seq_file *s, void *unused) } DEFINE_TRACE_REMOTE_ATTRIBUTE(dmesg); +static int trace_remote_panic_handler(struct notifier_block *self, unsigned long ev, void *v) +{ + struct trace_remote *remote = container_of(self, struct trace_remote, panic_notifier); + struct trace_remote_iterator *iter = smp_load_acquire(&remote->panic_iter); + int cpu; + + if (!iter) { + pr_warn("Unexpected error: no panic iterator for the trace remote\n"); + return NOTIFY_DONE; + } + + for_each_possible_cpu(cpu) { + if (iter->rb_iters[cpu]) { + /* No RING_BUFFER_ALL_CPUS to avoid taking cpu_read_lock() */ + ring_buffer_read_remote_meta_page(remote->trace_buffer, cpu); + ring_buffer_iter_reset(iter->rb_iters[cpu]); + } + } + + while (trace_remote_iter_read_event(iter)) { + trace_seq_init(&iter->seq); + + trace_remote_iter_print_event(iter); + trace_seq_putc(&iter->seq, 0); + pr_emerg("%s", iter->seq.buffer); + + trace_remote_iter_move(iter); + } + + return NOTIFY_DONE; +} + +static int trace_remote_panic_load(struct trace_remote *remote) +{ + struct notifier_block *notifier = &remote->panic_notifier; + struct trace_remote_iterator *iter; + + lockdep_assert_held(&remote->lock); + + if (remote->panic_iter) + return 0; + + iter = trace_remote_iter(remote, RING_BUFFER_ALL_CPUS, TRI_PANIC); + if (IS_ERR(iter)) + return PTR_ERR(iter); + + smp_store_release(&remote->panic_iter, iter); + + notifier->notifier_call = trace_remote_panic_handler; + notifier->priority = INT_MAX - 1; + atomic_notifier_chain_register(&panic_notifier_list, notifier); + + return 0; +} + +static void trace_remote_panic_unload(struct trace_remote *remote) +{ + struct trace_remote_iterator *iter = remote->panic_iter; + + lockdep_assert_held(&remote->lock); + + if (!iter) + return; + + atomic_notifier_chain_unregister(&panic_notifier_list, &remote->panic_notifier); + smp_store_release(&remote->panic_iter, NULL); + trace_remote_iter_free(iter); +} + +static ssize_t dump_on_panic_write(struct file *filp, const char __user *ubuf, + size_t cnt, loff_t *ppos) +{ + struct seq_file *seq = filp->private_data; + struct trace_remote *remote = seq->private; + bool enable; + int ret; + + ret = kstrtobool_from_user(ubuf, cnt, &enable); + if (ret) + return ret; + + guard(mutex)(&remote->lock); + + if (enable == remote->panic_on) + return cnt; + + if (trace_remote_loaded(remote)) { + if (enable) { + ret = trace_remote_panic_load(remote); + if (ret) + return ret; + } else { + trace_remote_panic_unload(remote); + } + } + + remote->panic_on = enable; + + return cnt; +} + +static int dump_on_panic_show(struct seq_file *s, void *unused) +{ + struct trace_remote *remote = s->private; + + seq_printf(s, "%d\n", remote->panic_on); + + return 0; +} +DEFINE_TRACE_REMOTE_ATTRIBUTE(dump_on_panic); + static int trace_remote_init_tracefs(const char *name, struct trace_remote *remote) { struct dentry *remote_d, *percpu_d, *d; @@ -1016,6 +1162,11 @@ static int trace_remote_init_tracefs(const char *name, struct trace_remote *remo if (!d) goto err; + d = trace_create_file("dump_on_panic", TRACEFS_MODE_WRITE, remote_d, remote, + &dump_on_panic_fops); + if (!d) + goto err; + d = trace_create_file("buffer_size_kb", TRACEFS_MODE_WRITE, remote_d, remote, &buffer_size_kb_fops); if (!d) -- 2.55.0.571.g244d577d93-goog