Linux Trace Kernel
 help / color / mirror / Atom feed
From: Vincent Donnefort <vdonnefort@google.com>
To: rostedt@goodmis.org, mhiramat@kernel.org,
	 linux-trace-kernel@vger.kernel.org
Cc: mathieu.desnoyers@efficios.com, kernel-team@android.com,
	 linux-kernel@vger.kernel.org,
	Vincent Donnefort <vdonnefort@google.com>
Subject: [PATCH v6 15/18] tracing/remotes: Add poll_ms tracefs file
Date: Mon, 17 Aug 2026 14:55:14 +0100	[thread overview]
Message-ID: <20260817135517.3919534-16-vdonnefort@google.com> (raw)
In-Reply-To: <20260817135517.3919534-1-vdonnefort@google.com>

Add a tracefs file to configure the trace remote polling period. Keep
the default value to 100ms.

Signed-off-by: Vincent Donnefort <vdonnefort@google.com>

diff --git a/kernel/trace/trace_remote.c b/kernel/trace/trace_remote.c
index 5536e0df4379..204d5bef7a8c 100644
--- a/kernel/trace/trace_remote.c
+++ b/kernel/trace/trace_remote.c
@@ -425,7 +425,8 @@ static void trace_remote_do_poll(struct trace_remote *remote)
 
 	ring_buffer_poll_remote(remote->trace_buffer, RING_BUFFER_ALL_CPUS);
 	yield = trace_remote_do_dmesg(remote);
-	schedule_delayed_work(&remote->poll_work, yield ? 0 : msecs_to_jiffies(remote->poll_ms));
+	schedule_delayed_work(&remote->poll_work,
+			      yield ? 0 : msecs_to_jiffies(READ_ONCE(remote->poll_ms)));
 }
 
 static void __poll_remote(struct work_struct *work)
@@ -1135,6 +1136,40 @@ static int dump_on_panic_show(struct seq_file *s, void *unused)
 }
 DEFINE_TRACE_REMOTE_ATTRIBUTE(dump_on_panic);
 
+static ssize_t poll_ms_write(struct file *filp, const char __user *ubuf, size_t cnt, loff_t *ppos)
+{
+	struct seq_file *seq = filp->private_data;
+	struct trace_remote *remote = seq->private;
+	unsigned int val;
+	int ret;
+
+	ret = kstrtouint_from_user(ubuf, cnt, 10, &val);
+	if (ret)
+		return ret;
+
+	if (!val)
+		return -EINVAL;
+
+	guard(mutex)(&remote->lock);
+
+	if (val < remote->poll_ms && remote->poll_cnt)
+		mod_delayed_work(system_percpu_wq, &remote->poll_work, msecs_to_jiffies(val));
+
+	WRITE_ONCE(remote->poll_ms, val);
+
+	return cnt;
+}
+
+static int poll_ms_show(struct seq_file *s, void *unused)
+{
+	struct trace_remote *remote = s->private;
+
+	seq_printf(s, "%u\n", READ_ONCE(remote->poll_ms));
+
+	return 0;
+}
+DEFINE_TRACE_REMOTE_ATTRIBUTE(poll_ms);
+
 static int trace_remote_init_tracefs(const char *name, struct trace_remote *remote)
 {
 	struct dentry *remote_d, *percpu_d, *d;
@@ -1167,6 +1202,10 @@ static int trace_remote_init_tracefs(const char *name, struct trace_remote *remo
 	if (!d)
 		goto err;
 
+	d = trace_create_file("poll_ms", TRACEFS_MODE_WRITE, remote_d, remote, &poll_ms_fops);
+	if (!d)
+		goto err;
+
 	d = trace_create_file("buffer_size_kb", TRACEFS_MODE_WRITE, remote_d, remote,
 			      &buffer_size_kb_fops);
 	if (!d)
-- 
2.55.0.691.gc56d675ccc-goog


  parent reply	other threads:[~2026-08-17 13:55 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-17 13:54 [PATCH v6 00/18] tracing/remotes: Add printk, dump_on_panic and boot parameters Vincent Donnefort
2026-08-17 13:55 ` [PATCH v6 01/18] tracing/remotes: Gate tracefs files opening on trace remote registration Vincent Donnefort
2026-08-17 14:09   ` sashiko-bot
2026-08-17 13:55 ` [PATCH v6 02/18] tracing/remotes: Release tracefs,eventfs on registration failure Vincent Donnefort
2026-08-17 13:55 ` [PATCH v6 03/18] tracing/remotes: Use kstrtobool for boolean tracefs files Vincent Donnefort
2026-08-17 14:11   ` sashiko-bot
2026-08-17 13:55 ` [PATCH v6 04/18] tracing/remotes: Use a single per-remote polling work Vincent Donnefort
2026-08-17 13:55 ` [PATCH v6 05/18] tracing/simple_ring_buffer: Add support for compressed length Vincent Donnefort
2026-08-17 13:55 ` [PATCH v6 06/18] tracing/remotes: Add dmesg tracefs file Vincent Donnefort
2026-08-17 14:09   ` sashiko-bot
2026-08-17 13:55 ` [PATCH v6 07/18] tracing/remotes: selftests: Add a test for the " Vincent Donnefort
2026-08-17 14:05   ` sashiko-bot
2026-08-17 13:55 ` [PATCH v6 08/18] tracing/remotes: selftests: Prefix hypervisor folder Vincent Donnefort
2026-08-17 13:55 ` [PATCH v6 09/18] ring-buffer: Use irqsave for the reader lock in ring_buffer_poll_remote Vincent Donnefort
2026-08-17 13:55 ` [PATCH v6 10/18] ring-buffer: Use panic-friendly locking in ring_buffer_iter interface Vincent Donnefort
2026-08-17 14:04   ` sashiko-bot
2026-08-17 13:55 ` [PATCH v6 11/18] ring-buffer: Add ring_buffer_read_remote_meta_page() Vincent Donnefort
2026-08-17 13:55 ` [PATCH v6 12/18] ring-buffer: Add kerneldoc for ring_buffer_poll_remote Vincent Donnefort
2026-08-17 13:55 ` [PATCH v6 13/18] tracing/remotes: Add dump_on_panic tracefs file Vincent Donnefort
2026-08-17 14:10   ` sashiko-bot
2026-08-17 13:55 ` [PATCH v6 14/18] tracing/remotes: selftests: Add a test for the " Vincent Donnefort
2026-08-17 14:07   ` sashiko-bot
2026-08-17 13:55 ` Vincent Donnefort [this message]
2026-08-17 13:55 ` [PATCH v6 16/18] tracing/remotes: Add trace_remote cmdline options Vincent Donnefort
2026-08-17 14:12   ` sashiko-bot
2026-08-17 13:55 ` [PATCH v6 17/18] Documentation: tracing/remotes: Add detailed tracefs layout Vincent Donnefort
2026-08-17 13:55 ` [PATCH v6 18/18] Documentation/kernel-parameters: Add trace_remote Vincent Donnefort
2026-08-17 14:21   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260817135517.3919534-16-vdonnefort@google.com \
    --to=vdonnefort@google.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox