From: Steven Rostedt <rostedt@goodmis.org>
To: Vincent Donnefort <vdonnefort@google.com>
Cc: mhiramat@kernel.org, linux-trace-kernel@vger.kernel.org,
mathieu.desnoyers@efficios.com, kernel-team@android.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 1/4] ring-buffer: Allow splice reads on static buffers
Date: Thu, 3 Sep 2026 14:26:22 -0400 [thread overview]
Message-ID: <20260903142622.774ff437@gandalf.local.home> (raw)
In-Reply-To: <20260901155445.1475405-2-vdonnefort@google.com>
On Tue, 1 Sep 2026 16:54:42 +0100
Vincent Donnefort <vdonnefort@google.com> wrote:
> ring_buffer_read_page() rejects splice (full=1) reads on static buffers
> (that is user-mapped, persistent or remote) because !read check assumes
> unread pages must be swapped. However for those buffers we have no other
> choice than memcpy the data.
>
> For the memcpy case, only return an error when the writer is still on
> the reader page for the splice interface to wait.
>
> Fixes: 117c39200d9d ("ring-buffer: Introducing ring-buffer mapping functions")
> Signed-off-by: Vincent Donnefort <vdonnefort@google.com>
I'm going to apply this patch now, so you can drop it from your v10.
-- Steve
next prev parent reply other threads:[~2026-09-03 18:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 15:54 [PATCH v9 0/4] ring-buffer: Fixes for subbuf resizing and persistent buffers Vincent Donnefort
2026-09-01 15:54 ` [PATCH v9 1/4] ring-buffer: Allow splice reads on static buffers Vincent Donnefort
2026-09-03 18:26 ` Steven Rostedt [this message]
2026-09-01 15:54 ` [PATCH v9 2/4] tracing: Fix subbuf resize races with trace_pipe_raw readers Vincent Donnefort
2026-09-03 15:48 ` Steven Rostedt
2026-09-03 17:27 ` Vincent Donnefort
2026-09-01 15:54 ` [PATCH v9 3/4] ring-buffer: Cap static ring buffer nr_pages Vincent Donnefort
2026-09-01 16:35 ` sashiko-bot
2026-09-03 16:56 ` Steven Rostedt
2026-09-03 17:06 ` Vincent Donnefort
2026-09-03 17:33 ` Steven Rostedt
2026-09-04 13:04 ` Vincent Donnefort
2026-09-04 14:02 ` Steven Rostedt
2026-09-01 15:54 ` [PATCH v9 4/4] ring-buffer: Prevent truncation of nr_pages / nr_subbufs Vincent Donnefort
2026-09-01 16:48 ` sashiko-bot
2026-09-03 17:23 ` Steven Rostedt
2026-09-03 17:16 ` Steven Rostedt
2026-09-03 17:37 ` Vincent Donnefort
2026-09-03 18:17 ` Steven Rostedt
2026-09-03 14:31 ` [PATCH v9 0/4] ring-buffer: Fixes for subbuf resizing and persistent buffers Steven Rostedt
2026-09-03 15:19 ` Vincent Donnefort
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903142622.774ff437@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=vdonnefort@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox