From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29EFA4A4820 for ; Fri, 4 Sep 2026 14:14:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788531269; cv=none; b=hoVz3RcUP+jJTihJqBTatAiFZytXVwTSkP/h9cG/qhnd4fyDV0p2WIfvAP19tPa4ldfGgRbLvCZ1AUQsb4fhPvllUoMgcTgtTYAtdogE3nxpaN55i7lqnp+MgmrUaMCyOJIhQS/rn2LBlv11rapJneSNbzlwwx53OgkaunjlxUE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788531269; c=relaxed/simple; bh=Nwh6qKR0V+XnjPWwHnDPQggNun+470bR9FEfgGFIKDs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ttFYjjxYIzlBolT1eq2tmb/2uHtEwWVHKLKQlnBCIP3K6p+eYEML6ymvGfHibtQBl0461lNK6SkiqLYoox5Gajoog4Wn19aUVKsg9baj7mGpQh+u8TN5MrwRY+euAeU74mSRZQwYcl4ZWpNdB44L+gnHU/YKfwnScF+EUSTtI1k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ojA3+U2v; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ojA3+U2v" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-49556f97a9dso9056645e9.1 for ; Fri, 04 Sep 2026 07:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788531266; x=1789136066; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Ci5sK1VA/AFzZLFsaPwTu74VZ2hcdCO7IieHuFxzFO8=; b=ojA3+U2vtBobsb0saxAsmVJOOvZ0tinQJcBN0YktONA64T/b7CefZwY4MdgDa3kyNp KzMbJ4/+bOvLJEC4Flqfd+1YI4qeKtorHab+rkbQhmODA70xCc/l6t18wBuwQtpblH8X wkS426Jyz17mqX9LXKqWcOcfSLScgA4dm94tRJmHdLZq2lnD0L9wZR5v0M91tqZVPG3w f4F0FcwaRnSsWTHUAJU7cL7l9fRjqH0JovlEL+S+6LPn8dFBG0ozl/jzUg0H7B13huK/ 8HdhJUNidMa7dSKcyMZqg3OY7b1tUIirVnJn0AmNvP7imn4jz3Z/KBb8u5MY0l+eTSVo gGiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788531266; x=1789136066; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=Ci5sK1VA/AFzZLFsaPwTu74VZ2hcdCO7IieHuFxzFO8=; b=tL0e86ODNzCsMf47Mr3q2Yrj+CCHxp0SC4fFPSDATIBwh6jQU6n1x0orzVGiCze+ot KbCg+1QY7zfkG/Ngdr8KzTP6L/6XVxwcH3KeYbiAxJWUVIZsG9Jv22xN3As/DRX4Ols3 VCtUHBdyPS6tazD+7YrG4kiKnKFaVWtebkT5+vA150Y0gAZLjgHquJSjockU75kfBUPY 67qditp1wrl2TnM6Uh3kp4iOmU9rChHTe4u2/oXiuOrgGDKUR/OIGogprwJG3CzS88zg rqzhpzATaVjROj1qIv4BiWoIwxSNu8nN1bo/z6DpIWWRd4v+Uo4yNLLpVNrULlTBbIph xYng== X-Forwarded-Encrypted: i=1; AKwUvBxCgjAuQIain21gENn3EwrF87OGf0nlxJwmBnKcZMRChFLqZSqo59KPuBSzk6Wcjd1hsQu75A1D1+LDS7J62fRLS68=@vger.kernel.org X-Gm-Message-State: AFuF++lOQwqqqjE1TF4GcOJGAZE3gEN51ymakDsTV4B71v3WVydTqogU zw6hNJCAwp8a2/710MkqQF9yn1DbJKrJJyd0UIzie7bKCpE429G6iyeH X-Gm-Gg: AYBFou1cFwTAfWFiZllQmVubgIJFQe+xJWQnNwoT9arVCpW/qviZpFLWpll4H01ffZ+ 9xCDAhxWdLX9LGKxTipP/5o/IcmcssdLS/3cA7g1mnO9dG38kUdLH8Rc1Hg7dQEJQsN9czEr1z9 07x8/gxE+nS1PNaMZp1dn830+aZaXUcG2m86tVpG1Lw+ZKACZaVVx5gdJL4BeBahemc6Pe0u7Cb qxUXv38FNsPC5KoPIwq+oIADN4yY5H3wZb2lvMTkFyBPFj+9h8q0ygZCwNAwiV9KwQTzotnJEmO F3m2b7mAXqmbK1ekfDA3XjK/mZ8HhoL8VwD70TTrGBwFCdNIZ12WklPSlebMypohJUmO0zz502F GrU4Ai4dA0w6Zyv1Lu7ggLT+J3vcti6DnNAX20Egmbkf71bxJsEzr9x/Hf3X8O3wkrzQ6k9PQk7 ZwVqOpwgzEy+kILzn6mOTAK+L9auN0g2uV92cBBh4DoaSt7Bz3yhv87Cx2wEgdN/chqlT996hI+ D7uR3Vlk4NX9Q== X-Received: by 2002:a05:600c:138e:b0:49c:d818:8771 with SMTP id 5b1f17b1804b1-49cf8240ba5mr60011755e9.7.1788531265797; Fri, 04 Sep 2026 07:14:25 -0700 (PDT) Received: from localhost (ip87-106-108-193.pbiaas.com. [87.106.108.193]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49d00031c95sm263125e9.11.2026.09.04.07.14.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2026 07:14:25 -0700 (PDT) Date: Fri, 4 Sep 2026 16:14:09 +0200 From: =?iso-8859-1?Q?G=FCnther?= Noack To: Ye Liu Cc: Thomas Gleixner , Peter Zijlstra , "Rafael J. Wysocki" , Andrew Morton , Ingo Molnar , Will Deacon , Boqun Feng , "Paul E. McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Uladzislau Rezki , Juri Lelli , Vincent Guittot , Steven Rostedt , Masami Hiramatsu , Josh Poimboeuf , Ye Liu , Pavel Machek , Lance Yang , Petr Mladek , Waiman Long , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Dietmar Eggemann , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , Mark Rutland , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rcu@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH 5/8] kernel: convert process/thread iterators to for_each_*_rcu Message-ID: <20260904.84b04948b1fc@gnoack.org> References: <20260904083001.553587-1-ye.liu@linux.dev> <20260904083001.553587-6-ye.liu@linux.dev> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260904083001.553587-6-ye.liu@linux.dev> On Fri, Sep 04, 2026 at 04:29:57PM +0800, Ye Liu wrote: > diff --git a/kernel/hung_task.c b/kernel/hung_task.c > index 6fcc94ce4ca9..76871f78497f 100644 > --- a/kernel/hung_task.c > +++ b/kernel/hung_task.c > @@ -337,9 +336,7 @@ static void check_hung_uninterruptible_tasks(unsigned long timeout) > hung_task_info(t, timeout, this_round_count); > } > } > - unlock: > - rcu_read_unlock(); > - > +unlock: > if (!this_round_count) > return; The label name "unlock" is misleading now. There is no further unlock happening after it any more. –Günther