From: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
donggeunyoo.kernel@gmail.com
Subject: [PATCH 0/2] tracing: fix two histogram stacktrace keys that corrupt memory
Date: Tue, 8 Sep 2026 00:50:43 +0900 [thread overview]
Message-ID: <20260907155045.692664-1-donggeunyoo.kernel@gmail.com> (raw)
Both have the same shape: a histogram field ends up flagged as a
stacktrace while the ftrace_event_field behind it does not describe one.
HIST_FIELD_FN_STACK then reads a __data_loc word out of the record and
follows it, and event_hist_trigger() uses the word it lands on as the
length of a memcpy into a 31 entry array. Neither end of that copy is
bounded. One write to tracefs is enough to take the machine down on a
kernel built with no debug options.
They are independent and have different Fixes tags, so they are two
patches rather than one.
Tested on x86_64:
- both reproducers panic before and are clean after, with and without
CONFIG_KASAN
- ftracetest test.d/trigger gives identical results for all 45 items
before and after (32 pass, 3 fail, 2 unresolved, 8 unsupported; the
failures are pre-existing and unrelated)
- the stacktrace modifier recipe from cc5fc8bfc961 still records
stacktraces
Donggeun Yoo (2):
tracing: Fix memory corruption from the stacktrace modifier
tracing: Fix memory corruption from a "STACKTRACE" histogram key
kernel/trace/trace_events_hist.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
base-commit: df2908090cda368b01ff43709f51890076c56157
--
2.53.0
next reply other threads:[~2026-09-07 15:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 15:50 Donggeun Yoo [this message]
2026-09-07 15:50 ` [PATCH 1/2] tracing: Fix memory corruption from the stacktrace modifier Donggeun Yoo
2026-09-07 15:50 ` [PATCH 2/2] tracing: Fix memory corruption from a "STACKTRACE" histogram key Donggeun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907155045.692664-1-donggeunyoo.kernel@gmail.com \
--to=donggeunyoo.kernel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox