From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk2-f12.google.com (mail-qk2-f12.google.com [74.125.230.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B9BA353A75 for ; Fri, 11 Sep 2026 14:10:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.204 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789135845; cv=none; b=aIthOWeu+71RaRCeahj2UCTpJLszbevtpOgWLnxKZqKAOIJYbBzVxSBHd/dWMhIzaCnU5QaaK4F9XQu/mcKVorPyj8v8UJQOHAmSc4+q/E9C/cISy/ysqLc+DKmyCpKkatzPZkqN4Dak+BXOoxYhpUHGyxW2W+Jl58nYXGMDRlA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789135845; c=relaxed/simple; bh=K9+ZKIgsGRgsc959M4tS0rMKOB/eZlOXTQ8Ho0gK2m4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=V4eL5g276WlbKBcTPRHZ91z71N8+WjbxppyrjhjT//4GEOZPBGnOT1QaATZ2KtNjbUa5BPHJ1FOEbOhhl6kzjt1N2of6pRArah0PzABKDoZDWIqIXvinziar5uYrSQPr/KwzQSFhK/MxK1bcPKeJxPevxTLuZ7E22NX5mQSAE5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=toxicpanda.com; spf=pass smtp.mailfrom=toxicpanda.com; dkim=pass (2048-bit key) header.d=toxicpanda.com header.i=@toxicpanda.com header.b=DlojXtNQ; arc=none smtp.client-ip=74.125.230.204 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=toxicpanda.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=toxicpanda.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda.com header.i=@toxicpanda.com header.b="DlojXtNQ" Received: by mail-qk2-f12.google.com with SMTP id d75a77b69052e-52fb76543e1so4032581cf.0 for ; Fri, 11 Sep 2026 07:10:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda.com; s=google; t=1789135842; x=1789740642; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qrCxqh0lkRJGK/msNx4sQvIno2OGGDXwsMjyZ+inPRg=; b=DlojXtNQUMI+4RY2899Vd4IPmVGYjdfubWPeJfZpIUvjJBU3wym3CQSinEvyvDr9pK 082SvIG7BLzZLFY79cZL8B70om+Olx3fXxpAcQQR1qCc591L7hzuznE4vhfcDug9oYzN Nr2s2ZDFpiRGrI4U6t3n8BBycDUuL98yWwZaNenafr0YfxKl8p5iZtwwD+H5tGylC0ct r0vS+8Sfrp3pA0mXnjnnJCktcs+aqWnZCuT0uONmPA/cwW3Lx0yD3xB0L3dhCTO7sASw wE1kkzSkDG1EJ1nLU/KszNnGOj1bg3TQDvvf/zzzO5i6M4HjgFs7HaRiQ3jZqZRXMvvx Cg3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789135842; x=1789740642; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qrCxqh0lkRJGK/msNx4sQvIno2OGGDXwsMjyZ+inPRg=; b=UvfjADG8GFFcgVTBIymBkTfdnI6sxWZvCdmd9ZcWjz4kOlQrwBmYZY5O86rtPb1u+i bmn8IJ4u+YIcXE9OwuU2VLmKqOPE/WNp4MEAQAhxfxgbeMZDnvLNRBsejUvZF8fwsCdF E7VGLwC3KsfkSK8KYtzQyH+xElxtplV2wh37jyEM4C6+rvN+hIcwIvHA7OlgZEee87HW GxFlv802nZt8GhbSv2d4yDYpoQkV0Z/v3tR2A+OF2Vd6zySDLsf63kEFrw7OqFrbeEwv o+94C5KfwOMpUTERH9galK37tG8sv2kdQiaId8N8K9k4LOXqQvbzuJD1rCaFZ1AkNlJG tBYw== X-Forwarded-Encrypted: i=1; AKwUvBwlE/PFOXERGiz4VjEZq0zmdn06XFiF7qs+8Nm5eIw1ulu+9vkBl2fEZgcRW2sQnKC/uhTX/VPb0xpptc2qZo5U0fY=@vger.kernel.org X-Gm-Message-State: AFuF++kvDTOWbEyBH6qTW3M4lostqbWFRQVMpZdCa3gIIL6KlkViKw7u hVTGw5DxZY6LsI2CLZBRfcxeXI5L2SM7irOMS3P0nQFNEv3CTuN0ccd+3nGUjJnsY2s= X-Gm-Gg: AYBFou0rO0vBRpmqI1vUidubggrImu4mBSA8UWsyXN/jyl0GCsZzSx8uIkjD5lxOY7m KpborBO53AszBiWjw2IjB2K7KF7lrt7TDjsvX5HXD/rSlbZXH7F4u1O60dwINzkMOEYRJPiWSKt s2Xdcw6nnE1Nq/gOtltVuSTzmxjYe1c+u8WokglK7rGjcPbHhD3DBHk0ie+3si4tnsk7lIyzmxp 8scFyhHGbDXoIpOyrqriqom1Gxb4X6wjVQ1e3bUsVxZpa60LfxZZbNsDf9PXqaX+EtQ36LvpY5w MxwUl6g+XTlLLBlanOH3s8YpzonwnhHgIyiaICUnnel17/9E1xfje6xSQFxDRkrcn+jRgNO36wh Kkh9BnHz7v1/hUBTyHVwmk83CeQv1cSJ3HgFV8GyZpsNrkRmH5UIWmU0N799evi6+QSrRSrmqPw xSkqY0zcIMKe7sQkClBc9nSmlXS5dsrSkgS/Ql9pGdmVsNDWcfEwIUIwldvSJJku8LrR/m0BPb7 xIsvKJLkSPTxdCT8ErlKiFwMdo0zmlbuQZnTWs0GwoaZ7jN552Q+Rsx X-Received: by 2002:a05:622a:53c5:b0:51c:b98c:f772 with SMTP id d75a77b69052e-530c86f6195mr51379741cf.15.1789135827987; Fri, 11 Sep 2026 07:10:27 -0700 (PDT) Received: from toxicpanda.com (ec2-34-228-114-98.compute-1.amazonaws.com. [34.228.114.98]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-530ca460a32sm20960711cf.9.2026.09.11.07.10.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 07:10:27 -0700 (PDT) From: Josef Bacik Date: Fri, 11 Sep 2026 14:08:53 +0000 Subject: [PATCH RFC v2 15/15] rcu-tasks: Kick running holdouts through the scheduler Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260911-b4-rcu-tasks-preempt-qs-v2-15-eaaa61ed2da4@toxicpanda.com> References: <20260911-b4-rcu-tasks-preempt-qs-v2-0-eaaa61ed2da4@toxicpanda.com> In-Reply-To: <20260911-b4-rcu-tasks-preempt-qs-v2-0-eaaa61ed2da4@toxicpanda.com> To: "Paul E. McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Boqun Feng , Thomas Gleixner , Peter Zijlstra , Steven Rostedt , Masami Hiramatsu , Mark Rutland , Jiri Olsa , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , x86@kernel.org, Catalin Marinas , Will Deacon , Puranjay Mohan , Xu Kuohai Cc: Andy Lutomirski , Josh Triplett , Uladzislau Rezki , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Juergen Gross , Luis Chamberlain , Ihor Solodrai , linux-kernel@vger.kernel.org, rcu@vger.kernel.org, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, Josef Bacik X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openssh-sha256; t=1789135737; l=1790; i=josef@toxicpanda.com; h=from:subject:message-id; bh=K9+ZKIgsGRgsc959M4tS0rMKOB/eZlOXTQ8Ho0gK2m4=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgUBr36M/n0nWN0DNbnxwzIiCZez6MG JiruuNaSCI/zXsAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QFxu9w6oKo935Kq6bYpzSj4sd/pud6qAfpTImYrmpDnci7BPIoYh09XWotebu7q/uE6z/VGg6k/ nk0bYtqCcqAg= X-Developer-Key: i=josef@toxicpanda.com; a=openssh; fpr=SHA256:C8kOX2QUJCMqnCX+KEeoqRAjLo9L+ELOSH2NSAJHqGA A holdout that is running on a CPU with nothing else runnable is only preempted if the tick acts on rcu_request_urgent_qs_task()'s flag, and there may be no tick. Now that a preemption outside a trampoline is a quiescent state, have check_holdout_task() call resched_cpu() on a running holdout as well, so the scheduler IPIs it and it goes through __schedule() and reports (or, if it is inside a trampoline, does not report) its own state with purely local ordering. Nothing reads a running task's rcu_tramp_nesting remotely. Only under CONFIG_RCU_TASKS_PREEMPT_QS; other architectures are unchanged. Suggested-by: Paul E. McKenney Assisted-by: LLM Signed-off-by: Josef Bacik --- kernel/rcu/tasks.h | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h index ba432bd922e2..02d2592ab7a3 100644 --- a/kernel/rcu/tasks.h +++ b/kernel/rcu/tasks.h @@ -1038,8 +1038,18 @@ static bool rcu_tasks_preempted_qs(struct task_struct *t) { return task_call_func(t, rcu_tasks_switched_out_clean, NULL); } + +/* Make a running holdout pass through __schedule() soon, tick or no tick. */ +static void rcu_tasks_kick_running(struct task_struct *t) +{ + int cpu = task_cpu(t); + + if (task_curr(t) && cpu_online(cpu)) + resched_cpu(cpu); +} #else static bool rcu_tasks_preempted_qs(struct task_struct *t) { return false; } +static void rcu_tasks_kick_running(struct task_struct *t) { } #endif /* Per-task initial processing. */ @@ -1219,6 +1229,7 @@ static void check_holdout_task(struct task_struct *t, return; } rcu_request_urgent_qs_task(t); + rcu_tasks_kick_running(t); if (!needreport) return; if (*firstreport) { -- 2.55.0