From: Steven Rostedt <rostedt@goodmis.org>
To: Ridong Chen <ridong.chen@linux.dev>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Kairui Song <kasong@tencent.com>, Qi Zheng <qi.zheng@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
Barry Song <baohua@kernel.org>,
Axel Rasmussen <axelrasmussen@google.com>,
Yuanchu Xie <yuanchu@google.com>, Wei Xu <weixugc@google.com>,
Baoquan He <baoquan.he@linux.dev>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
David Hildenbrand <david@kernel.org>,
Michal Hocko <mhocko@kernel.org>,
Lorenzo Stoakes <ljs@kernel.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-mm@kvack.org (open list:MEMORY MANAGEMENT - MGLRU
(MULTI-GEN LRU)), Ridong Chen <chenridong@xiaomi.com>
Subject: Re: [PATCH 3/3] mm/mglru: add tracepoint for inc_max_seq()
Date: Fri, 11 Sep 2026 10:15:14 -0400 [thread overview]
Message-ID: <20260911101514.1fe0d543@gandalf.local.home> (raw)
In-Reply-To: <20260911072848.2346073-4-ridong.chen@linux.dev>
On Fri, 11 Sep 2026 15:28:48 +0800
Ridong Chen <ridong.chen@linux.dev> wrote:
> +static void trace_inc_max_seq(struct lruvec *lruvec)
> +{
> + int type, gen;
> + unsigned long nr[ANON_AND_FILE][MAX_NR_GENS];
> + struct lru_gen_folio *lrugen = &lruvec->lrugen;
> +
> + if (!trace_mm_mglru_inc_max_seq_enabled())
> + return;
> +
> + for (type = 0; type < ANON_AND_FILE; type++)
> + for (gen = 0; gen < MAX_NR_GENS; gen++)
> + nr[type][gen] = lru_gen_seq_nr_pages(lrugen, gen, type);
> +
> + trace_mm_mglru_inc_max_seq(mem_cgroup_id(lruvec_memcg(lruvec)),
> + lrugen->max_seq,
> + lrugen->min_seq[LRU_GEN_ANON],
> + lrugen->min_seq[LRU_GEN_FILE],
> + nr[LRU_GEN_ANON], nr[LRU_GEN_FILE]);
> +}
I would always look at trying to move as much logic into the
TP_fast_assign() and not have it be where the tracepoint is called.
-- Steve
next prev parent reply other threads:[~2026-09-11 14:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 7:28 [PATCH 0/3] mm/mglru: add tracepoints for scan and aging paths Ridong Chen
2026-09-11 7:28 ` [PATCH 1/3] mm/mglru: factor out lru_gen_seq_nr_pages() Ridong Chen
2026-09-11 7:28 ` [PATCH 2/3] mm/mglru: add tracepoint for scan_folios() Ridong Chen
2026-09-11 7:42 ` sashiko-bot
2026-09-11 10:04 ` Ridong Chen
2026-09-11 14:11 ` Steven Rostedt
2026-09-13 10:25 ` Ridong Chen
2026-09-11 7:28 ` [PATCH 3/3] mm/mglru: add tracepoint for inc_max_seq() Ridong Chen
2026-09-11 14:15 ` Steven Rostedt [this message]
2026-09-13 10:28 ` Ridong Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260911101514.1fe0d543@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=baoquan.he@linux.dev \
--cc=chenridong@xiaomi.com \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=ljs@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mhocko@kernel.org \
--cc=qi.zheng@linux.dev \
--cc=ridong.chen@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=weixugc@google.com \
--cc=yuanchu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox