From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf2-f12.google.com (mail-lf2-f12.google.com [74.125.229.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 183C54D9571 for ; Mon, 28 Sep 2026 15:26:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.229.204 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790609203; cv=none; b=Hz3qkK03DoP0YChI4unFEk/e0U/97KJrTWEvhU56PDCQqt7dTRv/PurSiK/mw2KAKzrb/acdnE/vcvXlFmxneku4VC7tGF/Xktgpscit9DpXSNg7Hvk7wmoQJhgC1S0bi9hEEUudS2w4TFgSAbk1i5acZBoHyhWPh/yhA9aYVNg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790609203; c=relaxed/simple; bh=YUd7BK0ws0/ktUKy73cne940m91GSfX2WZjyprS92lU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CNM2Aa3dO2zAWp5Y85K1F8FlSf8tgZ0FHtGtA3Zbkp9pd65cxFpy1uCyocz/bXikgCPUTU4QnXACr3P+SXCOyl2+ytBlKAvQScuWcLKFCBgR7WengPpI1xyszGpST+oOTgjAio9FHlCxJU0PRfXGqOHopPULH4tpTlSU08J+0mQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YyeoA3kZ; arc=none smtp.client-ip=74.125.229.204 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YyeoA3kZ" Received: by mail-lf2-f12.google.com with SMTP id 2adb3069b0e04-5b8f490bb27so1067558e87.2 for ; Mon, 28 Sep 2026 08:26:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790609200; x=1791214000; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=6zFpLqG/hmtB6W9VTlNsIylmOlLpoN7arQbytoDPb1U=; b=YyeoA3kZW0awuZw+8N8oSeYBop+8P7nF4AoJBidIFdBl4Ds4n8U3mZy00mMe+pwdVw qVy+nvSIh2mDmS12XHeWquk6A6XgCkpYghlv1xgAtyp/NHjrGxzG4HLhkvIWcory8cDQ 71WrmRG/zBd8a0QMi2y5uwPxaBcaLS/zI4BaIAARVYH8Njmj71d8BUsxiyJ1BgJugCBx vVoLONo3AnJ59EJWDkSHXtHQKcoBIz4F+cRU2gqYqipR7/uPte4m6DuOX7c6p3PJhOXt kUg641wkdJ5LLXgX+tJlJVEaEP/R7J5wLUXq8CHOsFUq+Vrcaih0wj4fzDq41THeERpW PgRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790609200; x=1791214000; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6zFpLqG/hmtB6W9VTlNsIylmOlLpoN7arQbytoDPb1U=; b=N0C7ZcqRz7NdhwqpJC4H5vbW/Ojd2F5VI+JY7CNNcOj4RbgbFde/Loqr2yRlIyQNq8 tsVXzZQoqGrlCzpNmHPAI0U8EsO0GKUjE1izv0RAzsfj4sIaZGMviMT/5KVXBExptS4n v1PJfjCTvMJCcVioICA2AdOkvch/ljCN6yc3ExQQbx+cSC52vqp+u1QGIPHGNs1m7eqD iwSYWK7dd+5zfd0WL9YzS1GpnqXscNeLyhLKK3A+bVWjEGHx233WKOfkf5XIlDsO0YWM QVKassLE51Zt0Al+S41tVuJJRDvgnd9BwO45wug9M2mgQEr9tsXB/jdWqiY1R+LBpchk sKSw== X-Forwarded-Encrypted: i=1; AKwUvBwW0Lqx94lvIpQc/cViT3uSlD3G2k1DsvFJlZeVFhd/gXCw1aXFKRpQB7vWphbIc1Y9kBAkWp+8N89Qb2dYZh6Y8PE=@vger.kernel.org X-Gm-Message-State: AFq9FYKPzJBTZFljcyBNmEArACsQqrKPlCFMUuxOKnZg95Tw3cPbUXpa Pjm6w5+O14vEbK8I8ZihCOKWrQiSo6/35xKyZdtFZogI06QaYvo1ff0J X-Gm-Gg: AYBFou17Ar41IijO0iGWfTW0OAaMHsOnNeL9XyKDN8cRwnIqkCdFAL2THknR3nAQZbX +Xp47xxueGEHKreDe3Vq+MBT3kKNVVfoFeTIKA5GgkcaPtpsdkN/SDEJVKfC/eKsTTIN4di4gGR MoVrkiUQgQndjr8Et8LVAdESHlSghbOrewxzhwk6TGdeIRdN/T9IkTgtwe5MvJ6j/8PX+B/R0/n qItbx8KYitc90/2Eukk4XR5L7ce/f4zE+NdgG6/ptVEVV4RdzhUWarcAp+T2YAE73VMkNuGn2CG AlXtHHtBjSshVa9EY9uLb6auwo3LjLWVjrqbrH5159owMXeyPsiLjirJRnHxDAtZbupu6Fk3w+b ByocI/DurJz+LwVuawc/OPgBJLw8KuBx+sQdBmFN0M10yujFyZetO+FDGDrCGxuJGoCxw0iMA9A bl0bJ/w7nlPmrPmAUOSpfM1YFwAztPETuQ7O8e6hxKlinTzlC6MPwWJQ+9aFqITB0r2o1CiziJC apfmPyT/aLLvSF3eDqZdLjePcUfPzs/KxZR X-Received: by 2002:a05:6512:3d12:b0:5aa:5ef9:a33 with SMTP id 2adb3069b0e04-5b8e6d99163mr3466903e87.25.1790609199795; Mon, 28 Sep 2026 08:26:39 -0700 (PDT) Received: from sc-mac-012.corp.sbercloud.ru ([188.191.29.26]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b9d826faf3sm638194e87.9.2026.09.28.08.26.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Sep 2026 08:26:39 -0700 (PDT) From: Dmitry Kandybka To: Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH] tracing: Fix ignored return value of resize_buffer_duplicate_size() Date: Mon, 28 Sep 2026 18:26:32 +0300 Message-ID: <20260928152634.4354-1-d.kandybka@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When tr->allocated_snapshot is true, resize_buffer_duplicate_size() is called to update the snapshot buffer size. However, its return value was not checked. In case of a failed resize this could lead next snapshot being incomplete. Add resize_buffer_duplicate_size() result check and return error if resize fails. Compile tested only. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 180e4e390978 ("tracing: Add snapshot refcount") Signed-off-by: Dmitry Kandybka --- kernel/trace/trace_snapshot.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/kernel/trace/trace_snapshot.c b/kernel/trace/trace_snapshot.c index 07b43c9863a2..4731ef7325a5 100644 --- a/kernel/trace/trace_snapshot.c +++ b/kernel/trace/trace_snapshot.c @@ -675,9 +675,12 @@ tracing_snapshot_write(struct file *filp, const char __user *ubuf, size_t cnt, if (iter->cpu_file != RING_BUFFER_ALL_CPUS) return -EINVAL; #endif - if (tr->allocated_snapshot) + if (tr->allocated_snapshot) { ret = resize_buffer_duplicate_size(&tr->snapshot_buffer, &tr->array_buffer, iter->cpu_file); + if (ret < 0) + return ret; + } ret = tracing_arm_snapshot_locked(tr); if (ret) -- 2.54.0