From: FUJITA Tomonori <tomo@flapping.org>
To: miguel.ojeda.sandonis@gmail.com
Cc: tomo@flapping.org, aliceryhl@google.com, ojeda@kernel.org,
rostedt@goodmis.org, gary@garyguo.net, a.hindborg@kernel.org,
acourbot@nvidia.com, bjorn3_gh@protonmail.com, boqun@kernel.org,
dakr@kernel.org, daniel.almeida@collabora.com, lossin@kernel.org,
mathieu.desnoyers@efficios.com, mhiramat@kernel.org,
tamird@kernel.org, tmgross@umich.edu, work@onurozkan.dev,
linux-trace-kernel@vger.kernel.org,
rust-for-linux@vger.kernel.org, fujita.tomonori@gmail.com
Subject: Re: [PATCH v2] rust: add mark_used macro
Date: Fri, 02 Oct 2026 06:37:11 +0900 (JST) [thread overview]
Message-ID: <20261002.063711.2115045889604804375.tomo@flapping.org> (raw)
In-Reply-To: <CANiq72kZyRQR-cxYKGKLHu7CkyOGAy6KrV2PegFSnM7eHizbhA@mail.gmail.com>
On Thu, 1 Oct 2026 15:02:40 +0200
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:
> On Thu, Oct 1, 2026 at 2:04 PM FUJITA Tomonori <tomo@flapping.org> wrote:
>>
>> Miguel, what do you think?
>
> I suggested it due to seeing the multi-line combination of `if false`
> and `_ = ...`, and the fact that we will probably want to reuse the
> combination in other macros. It makes the concept more explicit,
> easier to grep, and follows other cases we have created for similar
> things like this (e.g. `static_assert!`).
>
> Having said that, I do prefer using plain language instead of macros
> where possible/reasonable, i.e. I don't like introducing macros and
> more concepts in general just for the sake of it. On the other hand,
> sometimes language features aren't the best spellings to be honest
> (like the `const _` "abuse") and some people prefer abbreviations
> (like the discussion on `SZ_*` constants).
>
> Either way is fine, obviously.
Thanks, I'll drop it.
prev parent reply other threads:[~2026-10-01 21:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 12:02 [PATCH v2] rust: add mark_used macro FUJITA Tomonori
2026-09-30 9:50 ` FUJITA Tomonori
2026-10-01 11:05 ` Alice Ryhl
2026-10-01 12:04 ` FUJITA Tomonori
2026-10-01 13:02 ` Miguel Ojeda
2026-10-01 21:37 ` FUJITA Tomonori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002.063711.2115045889604804375.tomo@flapping.org \
--to=tomo@flapping.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rostedt@goodmis.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox