From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: agordeev@linux.ibm.com
Cc: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 2/2] ftrace/selftests: Change non-unique test symbol to init_once
Date: Tue, 13 Oct 2026 04:10:03 +0000 [thread overview]
Message-ID: <20261013041004.B95A91F000FF@smtp.kernel.org> (raw)
In-Reply-To: <67ac21cd214ec9371276df9ba790e9832cf328d4.1787670777.git.agordeev@linux.ibm.com>
On Tue, 25 Aug 2026 18:58:40 +0200, Alexander Gordeev <agordeev@linux.ibm.com> wrote:
> The name_show symbol is not the best choise, because it often
> appears only three times on s390 in kallsyms, with two of them
> having module annotations [mdev] and [i2c_core].
>
> Switch to init_once which has many more duplicate instances
> all in vmlinux, making it a more reliable non-unique symbol
> for testing kprobe registration failure.
>
> Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
Looks good to me. Let me pick this to probes/for-next.
Thanks,
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2026-10-13 4:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 16:58 [PATCH 0/2] ftrace/selftests: Fix registering kprobe on non-unique symbol Alexander Gordeev
2026-08-25 16:58 ` [PATCH 1/2] ftrace/selftests: Fix regex pattern to match vmlinux symbol names only Alexander Gordeev
2026-08-25 16:58 ` [PATCH 2/2] ftrace/selftests: Change non-unique test symbol to init_once Alexander Gordeev
2026-10-13 4:10 ` Masami Hiramatsu [this message]
2026-09-08 12:46 ` [PATCH 0/2] ftrace/selftests: Fix registering kprobe on non-unique symbol Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261013041004.B95A91F000FF@smtp.kernel.org \
--to=mhiramat@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox