From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.215.200 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793051573; b=uTvj9C5oEX5xQ4vtbY12QdwCpMQVNvHUH0I7vzC3bRWzG14w5RXU7DcwUrzX08h8262l eh5P15KYDQdyk93qW7QICygYw74pD8ZB6sTsKouEoxiCTqtSOKjwZX/mGdhM9RSQXrskp o23H4swQZ1FVdT9qegNZAdG1b8Qlw43QOZ7yMkE9k/Ue1jCs1x47PvAYYGDZohFZsGRlH oFyUn51g7iw8ZMKNFt7o6dlUdiJpKBd07bZqthz/rprPfm4TLerkviInyOAoDBBnEr393 /DM9o5eAHAXsBC/8BTnZWNwFLFd9c99OXMIzItPRAlJqHVG0bRkqesrcYQ2jZtAOvdQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793051573; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=OQEJn1r6phHG9JJTEKXNjl8UbrwqhLU2o1gcr6ks6C0=; b=cnEhtNPYIFnCUdR4RUwnRimXIVmGTWeGIZA9NpaiNyxVX7GRnIO4pNriXgATvdD+uxQl KCQV34m3Lelfo9dxIvVHBENI4Wb26oHigiFhrU3O2GeJPBbfeDcq1u6XjA5OYlhVFTTR8 mFXYBQIuzrn2tVNoSNSy6HFJwCB8iubRlzIs4SQSFpRU9i6zI6abpQqAxPGB9ptuTCpSy T6yI6dsN9DPGGISEkNNqHtQM9C+DvAGHRzDCp9k/ERlihn9WFaGOdd0jIlM5n138FiCz3 9pw/xTtSMuvQSCp/oVMnwtk9JuDq3C3HbMchzLZBJ9RNmHfVLTP6GaSW2/YxxcyL+tQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--jthoughton.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=ApDjmBZ2; arc=none smtp.remote-ip=209.85.215.200 Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB78A60A382A for ; Mon, 26 Oct 2026 21:52:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org EB78A60A382A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jthoughton.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=ApDjmBZ2 Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cd0cf3b1c70so2139045a12.3 for ; Mon, 26 Oct 2026 14:52:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1793051572; x=1793656372; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OQEJn1r6phHG9JJTEKXNjl8UbrwqhLU2o1gcr6ks6C0=; b=ApDjmBZ2P5IY9M07VtIw4q1PCPK6CpIgTYTWQMTnhd4WbvnSeK4y3f8atnn7QA9cjB pATuIJVRmfxmUb6DVTcY2TSWeqihjk7sAkqWl2p7EJ+Outh4lOM6tfOP5bdm3xMdvvxm Gz5j1WDaxuKn1Qo4ZRLEMmGLuAM8u+S9GjSAdvAH/B5Z9aOkw665P34Qp/haslR+DdAh 6Cf+TsLq3VxdxXfhvV5luqaTWzWAuM2gDcXBE0x9iCsw+vaQTyRrV4cFglmiecBVNbcN 5aCJa8Oo3N1GkKfrvyeHtHj7KXN2+Rosy5Vsb+br/0l+WNOkW/XGL3x3Tqqyd1sNMI9t cLgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793051572; x=1793656372; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OQEJn1r6phHG9JJTEKXNjl8UbrwqhLU2o1gcr6ks6C0=; b=l98azTmnuRl3ffPsiI8mvCWqE/jmY2e3gyeKyoM+WdS23rpcECRBxoFNyf4ti97or9 Bk/dV5xxcjcRFIYA69YbyT7YyTrYuqnmaHdb9tt+Art7fmbKMX1FpPPKAmHZDGa2U0+g 99BuIghj27t3szLuYsUOz+K/ORlD6CWEbXv2T2gke/wyWfFMBUWTmEHLn3pSZ+24Svf3 pelzFoGYMDyxj9sfUnkoECsnhBiWkE1GVrsYOTgwgjl6V8YiL4cq7YjIuVJ0ijG8aofa KjAW57rHO98PFjulAgTguMYx16Ew58LXRkCG/fpRxy8I2IXtyQGHpJMZ1JtYqSidhHyX zPtQ== X-Forwarded-Encrypted: i=1; AKwUvBzEbDSw2cJ0GOr47hMqhh/PPYR0S3ZXDy6/ZDX9BPklVlwz32g6EogZN2ID3JVQTmYXf//W+2QARP9p6jv2Z2TXVTI=@vger.kernel.org X-Gm-Message-State: AFq9FYLas+JUq4VKbIx+fHiiB6uwmsmSa2BdIj4yzcbqjA4FGL8BUbHp wCsbACsi6205ATGdBtkRy+pPNyktaDeLCe+riKI6M06QKs6c9zxegYgJ4cP9Kk9BJWDcPLAX4ji ZdDxP1OePaCgpk1S9kjBBWg== X-Received: from pjbee5.prod.google.com ([2002:a17:90a:fc45:b0:3ad:f864:f94f]) (user=jthoughton job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:4d8c:b0:3ac:a521:95e with SMTP id 98e67ed59e1d1-3adead4f7ebmr6876350a91.47.1793051572060; Mon, 26 Oct 2026 14:52:52 -0700 (PDT) Date: Mon, 26 Oct 2026 21:52:21 +0000 In-Reply-To: <20261026215226.3713941-1-jthoughton@google.com> X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261026215226.3713941-1-jthoughton@google.com> X-Mailer: git-send-email 2.56.0.307.g5fe7bd680c-goog Message-ID: <20261026215226.3713941-6-jthoughton@google.com> Subject: [RFC PATCH 05/10] perf/core: Don't unwind the user stack without an mm From: James Houghton To: Andrew Morton , Alexander Viro Cc: Thomas Gleixner , Peter Zijlstra , Kees Cook , Arnd Bergmann , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Sean Christopherson , Paolo Bonzini , Jim Mattson , Jens Axboe , Pavel Begunkov , "James E.J. Bottomley" , "Martin K. Petersen" , David Sterba , Chris Mason , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Josh Poimboeuf , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, kvm@vger.kernel.org, io-uring@vger.kernel.org, linux-scsi@vger.kernel.org, linux-btrfs@vger.kernel.org, bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, James Houghton Content-Type: text/plain; charset="UTF-8" get_perf_callchain() only checks is_user_task(current) when the regs it is given aren't user mode regs. However, BPF's bpf_get_task_stack() (and bpf_get_task_stack_sleepable()) pass task_pt_regs(current) when called on the current task, which are user mode regs for a user task, even if that task has already gone through exit_mm(), e.g. when called from a program attached to exit_files() or to the dying task's final sched_switch. perf_callchain_user() then unwinds the user stack without an mm. That access does not reliably fail: the user half of the address space belongs to whatever mm happens to be lazily loaded, if any, so the unwinder may read another task's memory. This affects e.g. arm64, riscv, loongarch and csky, whose perf_callchain_user() doesn't check current->mm itself. perf events themselves are not affected, as perf_callchain() already clears the user callchain request when current is not a user task with an mm. Check is_user_task(current) regardless of the regs' mode. Fixes: fa28dcb82a38 ("bpf: Introduce helper bpf_get_task_stack()") Signed-off-by: James Houghton --- kernel/events/callchain.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/kernel/events/callchain.c b/kernel/events/callchain.c index 9d24b6e0c91f..a451ca2a5573 100644 --- a/kernel/events/callchain.c +++ b/kernel/events/callchain.c @@ -245,11 +245,15 @@ get_perf_callchain(struct pt_regs *regs, bool kernel, bool user, } if (user && !crosstask) { - if (!user_mode(regs)) { - if (!is_user_task(current)) - goto exit_put; + /* + * Even if @regs are user mode regs, e.g. task_pt_regs(current) + * passed in by bpf_get_task_stack(), current may already have + * gone through exit_mm(). + */ + if (!is_user_task(current)) + goto exit_put; + if (!user_mode(regs)) regs = task_pt_regs(current); - } if (defer_cookie) { /* -- 2.56.0.307.g5fe7bd680c-goog