From: Feng Yang <yangfeng59949@163.com>
To: yangsongsen@insta360.com
Cc: andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org,
daniel@iogearbox.net, eddyz87@gmail.com, emil@etsalapatis.com,
ihor.solodrai@linux.dev, jolsa@kernel.org, kpsingh@kernel.org,
linux-trace-kernel@vger.kernel.org, martin.lau@linux.dev,
mathieu.desnoyers@efficios.com, matt@bobrowski.net,
memxor@gmail.com, mhiramat@kernel.org, rostedt@goodmis.org,
song@kernel.org, yangfeng59949@163.com, yonghong.song@linux.dev
Subject: Re: [PATCH bpf-next] bpf: Fix suspicious RCU usage for sleepable bpf_get_stack()
Date: Thu, 29 Oct 2026 15:33:44 +0800 [thread overview]
Message-ID: <20261029073344.729148-1-yangfeng59949@163.com> (raw)
In-Reply-To: <20261028125148.1348-1-yangsongsen@insta360.com>
On Wed, 28 Oct 2026 20:51:47 +0800, Songsen Yang wrote:
> Hi Feng,
>
> I hit the same root cause independently via syzbot and sent a fix a
> few hours after yours, without having seen this patch -- sorry for the
> overlap:
>
> https://lore.kernel.org/bpf/20261028121859.994-1-yangsongsen@insta360.com/
Hi Songsen,
Please don't worry about the overlap.
I hadn't noticed the issue Sashiko raised when I prepared my fix;
It looks like a pt_regs on the stack can fix this.:
BPF_CALL_4(bpf_get_stack_raw_tp_sleepable, struct bpf_raw_tracepoint_args *, args,
void *, buf, u32, size, u64, flags)
{
struct pt_regs regs;
perf_fetch_caller_regs(®s);
return bpf_get_stack_sleepable((unsigned long) ®s, (unsigned long) buf,
(unsigned long) size, flags, 0);
}
That said, I think your approach is the simpler one and the better fit
for the fix itself. So if the maintainers prefer your version, feel
free to ignore my patch.
Thanks,
Feng
prev parent reply other threads:[~2026-10-29 7:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 9:35 [PATCH bpf-next] bpf: Fix suspicious RCU usage for sleepable bpf_get_stack() Feng Yang
2026-10-28 9:59 ` sashiko-bot
2026-10-28 12:51 ` Songsen Yang
2026-10-29 7:33 ` Feng Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261029073344.729148-1-yangfeng59949@163.com \
--to=yangfeng59949@163.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=ihor.solodrai@linux.dev \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mathieu.desnoyers@efficios.com \
--cc=matt@bobrowski.net \
--cc=memxor@gmail.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=song@kernel.org \
--cc=yangsongsen@insta360.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox