From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81EA3212FAA for ; Tue, 13 May 2025 09:06:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747127180; cv=none; b=rZwGTQ3W/IKpcDU6KPZUlYPLKhZ+pS3OcpNyascKtFmOm3OJQilfu8pipnizqhTFlQLL3JquBFnhTduEwW6x/mDNm3XdIsGkrwvNAKEj4eNh05gt14RFaSffYppb387YQ56MHqwC7VuJKrh1xUnBoJNOmpUeUJ1Jf3m5cD1Fnbc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747127180; c=relaxed/simple; bh=dMtFRm4laZ93vmZct7h+E+QskZ03lGRbyCPnefSLeq8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZCS7vikIY5XnLOM00UPZ8DjqcLqmZPGXwcIlbPwID2saI/VdjQL+tUjEY+1RZYxO2lo1u8kxhY1AiT3Fj6FYHNC41XxG+eUeI+9QqZA9dzFZX7Jhe5PFyGpTb+k8XBUjmLI6Uf8fQmhvnjAGrY3Z/cHg75p39LAPx0ddPijqsAQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Y3l19tV/; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y3l19tV/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747127177; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=q9jxOCEACQ9TguSqvzkS3Gt7WQBGW3OxfkGW2LURiUg=; b=Y3l19tV/MVPtvuejp43Dwhg+pUR96xHbR9HNKxVB+G0nEDhU+uiiCcP/R6y0p56jpJ4j7p oUgKaWKCcwKxQYHmUlQYwfsr3dbGZwX8yiBladNhGv4q2HchDpEoZkbFmIWBqpFtr7/xa4 xlslHCtoWto7TQPzWqWfKn6nAFZvc/g= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-416-5IBcNm3PPcumoTFoYOoC4A-1; Tue, 13 May 2025 05:06:16 -0400 X-MC-Unique: 5IBcNm3PPcumoTFoYOoC4A-1 X-Mimecast-MFC-AGG-ID: 5IBcNm3PPcumoTFoYOoC4A_1747127175 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a0db717b55so2747391f8f.3 for ; Tue, 13 May 2025 02:06:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747127175; x=1747731975; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=q9jxOCEACQ9TguSqvzkS3Gt7WQBGW3OxfkGW2LURiUg=; b=hz0KbVjAnZTHGOj3DmPWkvZid7hvloUOXb28CCLBmJgNyM62vNxtgk9xfcg8ccvgmY 1P2zcQMoTNVsa26QkNFr7E2eSfj+V1Hi3bDm0+X2hYKx4p6hsRiP0vXN6LPCyu9mbx56 F52j/gj21z0sLtSb4HT/C+a9e2p9BwSPnujatGhjCHsQN3NjbSiLvHPwglT1fNpGvPQu rS6XcCA0DgH80Dr9y2yedM6VMD/RZLoJQS36t/uij9RVZOFG7EQS39icjLRWLxG/8i8w E6b4DkYBnKqroW3ROd/MKrYyl/7BG9ISbbASOoIO2b9A3p4N5qUQw8t/JW/xKztRXgkz mGdw== X-Forwarded-Encrypted: i=1; AJvYcCV26TD7sDYNdbVa4EHL+t2lQo3H4py10KAl+MbiKQeoU5hKzHtaINCDD961JjDEYFBIKOrLM30B5krJTaelZ6NHQNE=@vger.kernel.org X-Gm-Message-State: AOJu0Yza+rSRiEnISgwLZGHJz0GiS6iKSG3SLm6UqNJ9zFFZmOBPC2zr jTXp03d6XXXaMypXqTw6SBzmDSABrHqFyhauKAcbQIrqQmq0sJXYmzzPKyM7nmFm4+/Lmf5xmRf AGGaJ0drmTjnd7UeKxtkGh3JdR4NjtRls/zlMy8hrTYkOOL5SYpZOJT2PAiadu5HTeyVVfw== X-Gm-Gg: ASbGncsxgXrWcXI4oiDAA7Mbfmtr3HAfm2xL1QrS7s4/Yzk6eCvdrg8z4XoPRwJAD4m JX0eg4rsKZXI0qwPQYOhUTWDG13fsH00U4aSxhPae/6x7Hs2ClCk+75VUWy9dMnurojeF1EZqIH bSgMvmQVIoVpn63kWJzdlry5vceKpktbKs8onRnWlUzWR2vE3n2dWODOeumnSmNnxgd0Sves8Iy 3ccdZk4RQjZ8utvA9eAPV2XjyHeQK/nwIonui29pJmx5JOYRrI1Rz2Tjn3ecA+8ZtvVKiSYu1Sq Hs4MpIvwJP/Fx29Vj+NRM41PtxFJgrKhCKIXdKU3s9cpDuy5PZPiPwFDwlQqyaE6HVPWi53uqNv tI48MCAF9B4UYqIZXjK9j8+ZjXyYd29dNOP4GCEc= X-Received: by 2002:a05:6000:184b:b0:3a0:90c6:46df with SMTP id ffacd0b85a97d-3a1f64ae085mr11924387f8f.48.1747127174843; Tue, 13 May 2025 02:06:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFczOcMfR6BGu8q55UlQ2KyVNNVnSREngFyFtwsspWxPS6JUuFMiq9K5/NPrcvYrdGyfp5UgA== X-Received: by 2002:a05:6000:184b:b0:3a0:90c6:46df with SMTP id ffacd0b85a97d-3a1f64ae085mr11924338f8f.48.1747127174488; Tue, 13 May 2025 02:06:14 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4d:1a00:4fdf:53e2:1a36:ba34? (p200300d82f4d1a004fdf53e21a36ba34.dip0.t-ipconnect.de. [2003:d8:2f4d:1a00:4fdf:53e2:1a36:ba34]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f58f2f58sm15131406f8f.49.2025.05.13.02.06.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 May 2025 02:06:14 -0700 (PDT) Message-ID: <219ad4d8-c191-4c1a-a835-e798ab58374f@redhat.com> Date: Tue, 13 May 2025 11:06:12 +0200 Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/11] mm: convert track_pfn_insert() to pfnmap_setup_cachemode*() To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , "Liam R. Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , Peter Xu , Ingo Molnar References: <20250512123424.637989-1-david@redhat.com> <20250512123424.637989-3-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: optAIeSeEmNQe8lmMVVHculljGpZeG3BepFOh28Ap5E_1747127175 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12.05.25 17:43, Lorenzo Stoakes wrote: > On Mon, May 12, 2025 at 02:34:15PM +0200, David Hildenbrand wrote: >> ... by factoring it out from track_pfn_remap() into >> pfnmap_setup_cachemode() and provide pfnmap_setup_cachemode_pfn() as >> a replacement for track_pfn_insert(). >> >> For PMDs/PUDs, we keep checking a single pfn only. Add some documentation, >> and also document why it is valid to not check the whole pfn range. >> >> We'll reuse pfnmap_setup_cachemode() from core MM next. >> >> Acked-by: Ingo Molnar # x86 bits >> Signed-off-by: David Hildenbrand > > I've gone through carefully and checked and this looks good to me :) Thanks a bunch! -- Cheers, David / dhildenb