From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E79C514F9F9 for ; Fri, 9 Aug 2024 18:42:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723228941; cv=none; b=uVSUOGUOseXOsBXouBxUVbM677aGQt56r7/6qXHbDLosnlIowLdjf9+/47d4vXpTpw30CQYOGu55cEUtDIngbhMdfWp4wwhKk1m+77H33p7yr9cDHid3uzBr57vX/a/looZVHW6Cx4SkHNREjUVcctGp0g56OIDXRTt4YFB/3j0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723228941; c=relaxed/simple; bh=o3gI+eWBz9OdExdT/y37sLpjS+ho3xXPI1CduZtOCuo=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=snfQnwU3+42SFSnASBAy1ywS4bGGJL59mzLvFW/RzW70jSiwtn6Yjm0NJlLBk+46lXh85fx4X9e/G4xVlSpou9xqa+bxLRUvb4Nak3HfkGD1B4ScJjV3hECHOQdyAVolvj7IW2xYUYgvQGMUc5g4ut+oHgf2TzIQp7IMx4s0FUE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EAl3UGdo; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EAl3UGdo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723228938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mTmJUzIYH5xdCwgnyXYAGeRQ3EOacpMfgAoosgsxAQU=; b=EAl3UGdoVzbKPU4Kd0qVBHEozF6ZdJ8gceN85knxz3Pr2w9lA+fOgiRIypr2AGunMpy3ZM 8tK91tMMK4agViOk7TYU9tc70Vj+0w3BCysOIRvLZnzzS9fyoz3PZBdz3sh9R4Yr1+oEof 2Ec/HXCTYipctWx+kQHHQmVqk7t+j9g= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-372-ZaNxSRnEMdap1MYyE_GPUg-1; Fri, 09 Aug 2024 14:42:17 -0400 X-MC-Unique: ZaNxSRnEMdap1MYyE_GPUg-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7a16375187aso285203385a.1 for ; Fri, 09 Aug 2024 11:42:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723228937; x=1723833737; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mTmJUzIYH5xdCwgnyXYAGeRQ3EOacpMfgAoosgsxAQU=; b=RvtBvTLAjnNvYKbLyZdNTr3f0y2jvJ+xIMvKbegvM7c21v65d8gJoBodSzJjokNM9B 2haowtG2GWkM9qlKWHr49uyMQrFwVZpUnGHuX+Bddvt8OXlTcUMF3NkFFJ1ov77MWDO9 jpwysHlR61pj5qKEJDkOjWs3tkqHGubpEERAXn8svUJ0++zPEqLr1POGAbstboTlEUfA BP6VjoHe7zTuoKhfdP0iw0i2tW/7QeeY9obC0PibBezX1T92DKr5HHPvs0eyWvOZac9t mCNLsSpZg8GdvyNBnXIhkZJGqJQNy9kNxl8xABy1iRSctdl9d9LdSH96SawVtktsoj5e +ANQ== X-Forwarded-Encrypted: i=1; AJvYcCUYEjkD2IQEDK83NN44mzE265npN95eJVNY9KjIKdPsOdsXTRKiLsjZJboUY+IA6Ndp/MtVC1Yhfp9FuBxjoXeBfBKnPHXiX2X+lURlBgAlWEeF X-Gm-Message-State: AOJu0YxFJPHCROSusSHTlcX2X1Pu9C+JbSGxFrExT2u1u37gPqpQpqcc KkDBUjXHKxuDR9lUCQl8ldiju8N2gcvslO2N5f30OyigtiXG9Vhj3aomSiWptoZS7+7AEHUhLaN oASeh7xKXoXmgqnhTdWSvOkkIfwwBlrJRoAN4GVNl9lWFrF7Da4duLkd2PbIF/q8Npctb3g== X-Received: by 2002:a05:620a:24d6:b0:7a1:e001:bb1b with SMTP id af79cd13be357-7a4c18c2d1bmr260014285a.60.1723228936976; Fri, 09 Aug 2024 11:42:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEXXXCv7azVX3+7vSHxmPbJNeW7P2HuAh5Ji2ZQSlJNOIDr1NBkSTa19JwsluzgDU1JZcECjw== X-Received: by 2002:a05:620a:24d6:b0:7a1:e001:bb1b with SMTP id af79cd13be357-7a4c18c2d1bmr260012185a.60.1723228936553; Fri, 09 Aug 2024 11:42:16 -0700 (PDT) Received: from fionn ([142.189.102.234]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a4c7d7a531sm4115085a.58.2024.08.09.11.42.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Aug 2024 11:42:16 -0700 (PDT) Date: Fri, 9 Aug 2024 14:42:13 -0400 (EDT) From: John Kacur To: Steven Rostedt cc: Dan Carpenter , Daniel Bristot de Oliveira , "Luis Claudio R. Goncalves" , Clark Williams , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] rtla/osnoise: prevent NULL dereference in error handling In-Reply-To: <20240809140545.698f654e@gandalf.local.home> Message-ID: <25b597bd-bdc4-411f-e5d9-78ed4d042c4b@redhat.com> References: <20240809134133.751723e5@gandalf.local.home> <7ece353a-36a6-6154-97d9-b255728b9807@redhat.com> <20240809140545.698f654e@gandalf.local.home> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII On Fri, 9 Aug 2024, Steven Rostedt wrote: > On Fri, 9 Aug 2024 13:53:33 -0400 (EDT) > John Kacur wrote: > > > > > > Although your fix appears to be correct, I wonder if it would be better to > > > > create a second error label, such as out_destroy_tool: as described in > > > > section 7 of the coding-style.rst > > > > > > > > > > There's no reason for that. It's the only error path. That is, nothing > > > would jump to the original out_err: > > > > > > And for a single error, an if statement is good enough. > > > > > > -- Steve > > > > > > > > > > Ah, right of course. > > Okay in that case, Signed-off-by: John Kacur > > (applied the patch, built and ran) > > Note, "Signed-off-by" is for the author of a patch or someone pushing it > through their tree. I believe you want either "Acked-by" or "Reviewed-by", > and since you ran it you could also add "Tested-by". > > -- Steve Thanks Steve, Reviewed-by: John Kacur Tested-by: John Kacur