From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A004E2222CC for ; Tue, 27 Jan 2026 01:32:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769477560; cv=none; b=uUMj6QFdYSW43OCnoBdyJZMSII7WlIuQg0LFiKUKODBCdyS4nUrPw0omaAJzMWr27ktl9xS1K88sq87BWEHeQwYzC5iJ/oRhEn1JQBXkY4dyeQnapvCzcDzBkAIjX7IR/xXPEfuw4la/+fNKlrMAvCf6R3seZ6O/d+/3nriDFJA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769477560; c=relaxed/simple; bh=dCDNdc5ViwAZ31uKNNUrqN+tz+sav2geyOoaw4Tozmw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BRvwYUJynsANT5jchwWZ6MDbHDqyToGIwlU7s/dU/Y0yvscfGNONgftshV6r0fzEYKnJxzGcLtl+MkX9MAhxNg+y5Y8bvpkSerwzLSKJp4IyFhZeO1yEnAiHx4qnjpUaEagquiQLprvZlhAwgl7Ao5iyFgPIFURHo7d753TPT+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H4d8qEe2; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H4d8qEe2" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2a0c09bb78cso35757935ad.0 for ; Mon, 26 Jan 2026 17:32:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769477558; x=1770082358; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=uulx0WOxdrU4glIAb8OrX5ZK+yXeZwLkXoVx0Hx78Yk=; b=H4d8qEe2NnPVweJjX317pnbvdSbang+VSQ6UuCJvmg6ey55FJPj8XhfbPmixRyO1yy AvSCHv0JPnwYY/gPEd8CYuXqggXVOt4BLsgJo02s7v6t9uYpqfHq3Nvy6X9F73BZhATY Q+6hDhWe7xY6A+2k2AvoW3LQi9mr8rItI+94+xuTOuFhzMTtPMn60Kr1vOjnhV8MjiyB 1yLvdhQilTYv9m/YGLUJhIESXqEDv6E+/IEXmWNSuSiL96qahw5CfW3jnWaDrN4Iy3jf xudHiqeYpr5M/qU/vlbF20SHruk3CnZaxpwzHBMnSncSBJxocMt1ske74L400bzzYL48 +QxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769477558; x=1770082358; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uulx0WOxdrU4glIAb8OrX5ZK+yXeZwLkXoVx0Hx78Yk=; b=bnXhnWvIDJt5QItC4aNwxHEMbkQ8ZWNhhvq1GB+z2a7R6i9X+WpsEtfty6NI0pHZNX SbRVWxQVm4AvbIZy+ZahEkQtc31apxPUaFsufUMcsM8TjR33G1rld6/f/T8gwxeZddvY 5tK9AW85ur0xV+fbDc1j81ajLD4tt7SLOLjyVmDA8Qp77ksD2m43PzF64RWlWM1Huoc9 SLC6rbze8EAbkSqdc92eHXHK+eGJdHrdUN2vU664nBYsPxlrnIpIL9zqawkjpYKcVu91 lW8TtGUpfWEZNCIraoXAxSyuMg1mVsDqrQTGYXYqJabbQRRfEUAu8UsjhbGPYMhZlPLJ hJCg== X-Forwarded-Encrypted: i=1; AJvYcCUWfxj7TrRQySFeQAxi2/ht36yHJ4+FQ8+S5rC5LXt+dPVxmQkpg8uUdue8BoFXgKsY+rjErDEPQlIWcK+RDVxaAws=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1XpJkZD2HIOenk4lUj7byTZfwTo0YJsvyw0xWiyoC4dUlF0cd 7IabG6hzUlXNfYWjrHnVfwzyDFOkIuKb6ELmj692xUFb+SqyaHTlureZHmDTF74L X-Gm-Gg: AZuq6aJ3MuK4vZ30KajIn5DjJLwyYwrBlRmGJQtP3MvugML0N6ZPDvcSI5QpPhNHpww GFTYxSo2ddUjh3PKeOfp77qwcM1APquIlboMI7VeXBGPGRZH6OTWZrMMpK4Jn7Rs/jJw3zlbuY1 zPgqVyRnTwFTKQPqQUyzB9h/WYrbOToh52cr7hBvuiNoVyEsqChqvOrL9FJNih3go7cEbImBRbi Cu67hPRGLqESoC4fVDLrCkVnl/H+T9THam+e6iEfGZxdm2Ip0VLyQzF/xrUnLX0i/sG3YM/dCKN prYElFeAB7aVyZtyQSulpFmtm9W28UzNlgJnwgxhLsFS0CfFPFY6YQcCxbduGeV0QtxmAIi2KYl Rn8FfUJSMLXyBkLoSp6W9J99gHTAKjfcHbCk2k+8LvtA24/mslPGP8m2buRbTYvJKiv3HW3pKFs F1BSk7ltv2TiEudeJP4yMa3Dh5u7+Eo+kfG61kHSMv18WKiQUM9KzwtsXG1fOP X-Received: by 2002:a17:902:fc84:b0:2a7:9163:8e60 with SMTP id d9443c01a7336-2a8455b04e5mr60607285ad.23.1769477557920; Mon, 26 Jan 2026 17:32:37 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a802dcd781sm99006485ad.24.2026.01.26.17.32.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jan 2026 17:32:37 -0800 (PST) Sender: Guenter Roeck Message-ID: <27f9a957-67c7-4c88-b320-0f8725e9b03d@roeck-us.net> Date: Mon, 26 Jan 2026 17:32:35 -0800 Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND][PATCH 3/5] perf: Use current->flags & PF_KTHREAD|PF_USER_WORKER instead of current->mm == NULL To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Thomas Gleixner References: <20250820180338.701352023@kernel.org> <20250820180428.592367294@kernel.org> <0d877e6f-41a7-4724-875d-0b0a27b8a545@roeck-us.net> <20260126120553.2fa79048@gandalf.local.home> <20260126121803.4a90c959@gandalf.local.home> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <20260126121803.4a90c959@gandalf.local.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/26/26 09:18, Steven Rostedt wrote: > On Mon, 26 Jan 2026 12:05:53 -0500 > Steven Rostedt wrote: > >> I guess we need to also test for !current->mm because the flags set for an >> exiting task is done when we can still do callchains. Thus, the only way to >> know if it is safe to do a callchain when a task is exiting is via task->mm >> and not task->flags :-/ > > Can you test this patch? > Still crashing, though not as often and with a slightly different backtrace. I added the backtrace to the bug report @ Google. Guenter > -- Steve > > diff --git a/kernel/events/callchain.c b/kernel/events/callchain.c > index 1f6589578703..c82d61d73bd8 100644 > --- a/kernel/events/callchain.c > +++ b/kernel/events/callchain.c > @@ -246,7 +246,14 @@ get_perf_callchain(struct pt_regs *regs, bool kernel, bool user, > > if (user && !crosstask) { > if (!user_mode(regs)) { > - if (current->flags & (PF_KTHREAD | PF_USER_WORKER)) > + /* > + * Testing current->mm is not enough as some kernel threads > + * may have one set. But testing the flags is not enough > + * either as this can be called after a user task > + * frees its mm just before it exits. > + */ > + if (!current->mm || > + (current->flags & (PF_KTHREAD | PF_USER_WORKER))) > goto exit_put; > regs = task_pt_regs(current); > }