From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0A6729A309 for ; Fri, 2 Jan 2026 15:54:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767369289; cv=none; b=l24b1EOZ0o1Gn7ZNkPAH6lbR/g54EWsmFa5kZdd5pnAzASmhrKB7bpgdyuoSfpmo/r3Mxd0V7j2EFPnOTMdMmZyHJuKA/S8Eei9nhJzZzNN3CfdZa5dfkdl/FtX2/OpRpM3r55CQUhj220hsDCQfIgRMGArlRcX5Y4ju/+k6lbc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767369289; c=relaxed/simple; bh=AYNhkdmP1tJtXgCNHGe2xmAp1DrgVNe0CaWaSNBP0gk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DXf/bvcltvnMMet+G9p/fthbNQKa72xbXyjU5O8HXoepHFGvGqgT/Pi54wh+UFOsk0FqsMMWY0jzjlCgO+Nzc9xXq2N9Oid3CuzHD2XC/+PsM2OuKExOVEq4HrZI4wnMKsk2MQl0w4YdscGuSuqxorEaFSoCbY8KIdt9n4ZMqWY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=UjKtRe1d; arc=none smtp.client-ip=91.218.175.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="UjKtRe1d" Message-ID: <2a8dcd09-fc28-4fbc-b8f5-a4f89d05a30a@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1767369275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ey84i6E6qnGgfsFMzS37RovpPPEFB2/BWeJmlqvfIJ4=; b=UjKtRe1dXL1CqhW2V4fM9Y6NwlE7pjwzey3eb9pown9nrD92SQRdmO8JZEBc8RzDqowKYy 3WNlZU5q18f/XtFJmobpwmdeS0CBCLqjsnnturR2VQ3a2kQ7soK3dqJRR05MfPydPajyBi 7UEAQ7Fx8i+0g16h9Eg3bMBabDH6Vvc= Date: Fri, 2 Jan 2026 23:54:20 +0800 Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next v2] page_pool: Add page_pool_release_stalled tracepoint To: Steven Rostedt Cc: netdev@vger.kernel.org, Jesper Dangaard Brouer , Ilias Apalodimas , Masami Hiramatsu , Mathieu Desnoyers , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , kerneljasonxing@gmail.com, lance.yang@linux.dev, jiayuan.chen@linux.dev, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Leon Huang Fu References: <20260102061718.210248-1-leon.hwang@linux.dev> <20260102104504.7f593441@gandalf.local.home> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Leon Hwang In-Reply-To: <20260102104504.7f593441@gandalf.local.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 2026/1/2 23:45, Steven Rostedt wrote: > On Fri, 2 Jan 2026 14:17:18 +0800 > Leon Hwang wrote: > >> diff --git a/include/trace/events/page_pool.h b/include/trace/events/page_pool.h >> index 31825ed30032..c34de6a5ae80 100644 >> --- a/include/trace/events/page_pool.h >> +++ b/include/trace/events/page_pool.h >> @@ -113,6 +113,30 @@ TRACE_EVENT(page_pool_update_nid, >> __entry->pool, __entry->pool_nid, __entry->new_nid) >> ); >> >> +TRACE_EVENT(page_pool_release_stalled, >> + >> + TP_PROTO(const struct page_pool *pool, int inflight, int sec), >> + >> + TP_ARGS(pool, inflight, sec), >> + >> + TP_STRUCT__entry( >> + __field(const struct page_pool *, pool) >> + __field(u32, id) >> + __field(int, inflight) >> + __field(int, sec) >> + ), >> + >> + TP_fast_assign( >> + __entry->pool = pool; >> + __entry->id = pool->user.id; >> + __entry->inflight = inflight; >> + __entry->sec = sec; >> + ), >> + >> + TP_printk("page_pool=%p id=%d inflight=%d sec=%d", >> + __entry->pool, __entry->id, __entry->inflight, __entry->sec) >> +); >> + >> #endif /* _TRACE_PAGE_POOL_H */ > > From a tracing POV, I see nothing wrong with this. > > Reviewed-by: Steven Rostedt (Google) > > -- Steve Hi Steve, Thanks for the review! I realized the id should be printed with '%u', so I've sent out v3 [1] with that adjustment. Links: [1] https://lore.kernel.org/netdev/20260102071745.291969-1-leon.hwang@linux.dev/ Thanks, Leon