From: Crystal Wood <crwood@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-kernel@vger.kernel.org,
John Kacur <jkacur@redhat.com>,
Tomas Glozar <tglozar@redhat.com>,
Costa Shulyupin <costa.shul@redhat.com>
Subject: Re: [PATCH v2 6/7] tools/rtla: Add test engine support for unexpected output
Date: Mon, 08 Sep 2025 09:48:10 -0500 [thread overview]
Message-ID: <2beae00128b235525a068527185443211beeb041.camel@redhat.com> (raw)
In-Reply-To: <20250907022325.243930-7-crwood@redhat.com>
On Sat, 2025-09-06 at 21:23 -0500, Crystal Wood wrote:
> Add a check() parameter to indicate which text must not appear in the
> output.
>
> Simplify the code so that we can print failures as they happen rather
> than trying to figure out what went wrong after printing "not ok". This
> also means that "not ok" gets printed after the info rather than before,
> which seems more intuitive anyway.
>
> Signed-off-by: Crystal Wood <crwood@redhat.com>
> ---
> v2: Preserved the original ordering of "not ok" versus diagnostics as per
> convention
Oops, forgot to edit the actual commit message to reflect the v2 update.
If there's no other need for a respin, please just remove the second
paragraph when committing.
Thanks,
Crystal
next prev parent reply other threads:[~2025-09-08 14:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-07 2:23 [PATCH v2 0/7] tools/rtla: Code consolidation and osnoise actions Crystal Wood
2025-09-07 2:23 ` [PATCH v2 1/7] tools/rtla: Consolidate common parameters into shared structure Crystal Wood
2025-09-07 2:23 ` [PATCH v2 2/7] tools/rtla: Move top/hist params into common struct Crystal Wood
2025-09-07 2:23 ` [PATCH v2 3/7] tools/rtla: Create common_apply_config() Crystal Wood
2025-09-07 2:23 ` [PATCH v2 4/7] tools/rtla: Consolidate code between osnoise/timerlat and hist/top Crystal Wood
2025-09-07 19:51 ` Costa Shulyupin
2025-09-08 13:53 ` Costa Shulyupin
2025-09-07 2:23 ` [PATCH v2 5/7] tools/rtla: Fix -A option name in test comment Crystal Wood
2025-09-07 2:23 ` [PATCH v2 6/7] tools/rtla: Add test engine support for unexpected output Crystal Wood
2025-09-08 14:48 ` Crystal Wood [this message]
2025-09-07 2:23 ` [PATCH v2 7/7] tools/rtla: Add remaining support for osnoise actions Crystal Wood
2025-09-09 11:25 ` [PATCH v2 0/7] tools/rtla: Code consolidation and " Tomas Glozar
2025-09-26 14:19 ` Tomas Glozar
2025-09-27 8:44 ` Steven Rostedt
2025-09-27 9:47 ` Steven Rostedt
2025-09-27 10:09 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2beae00128b235525a068527185443211beeb041.camel@redhat.com \
--to=crwood@redhat.com \
--cc=costa.shul@redhat.com \
--cc=jkacur@redhat.com \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglozar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox