Linux Trace Kernel
 help / color / mirror / Atom feed
From: Hongyan Xia <hongyan.xia@transsion.com>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
	Steven Rostedt <steven@rostedt.org>
Cc: Will Deacon <will@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Dennis Zhou <dennis@kernel.org>, Tejun Heo <tj@kernel.org>,
	Christoph Lameter <cl@gentwo.org>,
	Oleg Nesterov <oleg@redhat.com>, Naveen N Rao <naveen@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>,
	Jiazi Li <jiazi.li@transsion.com>, Pu Hu <hupu@transsion.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-trace-kernel@vger.kernel.org"
	<linux-trace-kernel@vger.kernel.org>,
	"llvm@lists.linux.dev" <llvm@lists.linux.dev>
Subject: Re: [RFC PATCH 9/9] arm64/debug: Mark debug exception helpers __always_inline
Date: Thu, 30 Jul 2026 11:50:17 +0000	[thread overview]
Message-ID: <2c7a6d63-b98a-4d8d-897f-50ad365026ff@transsion.com> (raw)
In-Reply-To: <20260730090307.24d3e4b1041f30d87d390e1c@kernel.org>

On 7/30/2026 8:03 AM, Masami Hiramatsu wrote:
> On Wed, 29 Jul 2026 14:08:46 -0400
> Steven Rostedt <steven@rostedt.org> wrote:
> 
>>
>> Masami,
>>
>>
>> On Mon, 27 Jul 2026 12:25:48 +0000
>> Hongyan Xia <hongyan.xia@transsion.com> wrote:
>>
>>> From: Hongyan Xia <hongyan.xia@transsion.com>
>>>
>>> Static inline should be enough to actually inline functions for most
>>> compilers, but my Clang-19 somehow thinks it's better to outline them.
>>> These tiny helpers then live in normal .text sections instead of
>>> .noinstr sections, violating noinstr.
>>>
>>> Mark them __always_inline so the compiler can never outline them.
>>>
>>> Signed-off-by: Hongyan Xia <hongyan.xia@transsion.com>
>>> ---
>>>   arch/arm64/include/asm/esr.h       | 2 +-
>>>   arch/arm64/include/asm/percpu.h    | 2 +-
>>>   arch/arm64/include/asm/preempt.h   | 4 ++--
>>>   arch/arm64/include/asm/ptrace.h    | 4 ++--
>>>   arch/arm64/kernel/debug-monitors.c | 2 +-
>>>   include/linux/kprobes.h            | 8 ++++----
>>
>> Are you OK with this patch? If so, can you ack it?
> 
> Yeah, this patch looks good to me. Anyway these are expected to be
> inlined.
> 
> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> 
> For other patches, Sashiko noted some comments, I need to check it.
> 
> Thank you,

Right, I just realized this is a badly-ordered series. Patch 9/9 should 
be merged first regardless, otherwise noinstr in the rest of the series 
simply won't work because of these outlined functions.

> [...]

      reply	other threads:[~2026-07-30 11:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1785153469.git.hongyan.xia@transsion.com>
2026-07-27 12:25 ` [RFC PATCH 9/9] arm64/debug: Mark debug exception helpers __always_inline Hongyan Xia
2026-07-27 19:22   ` Nick Desaulniers
2026-07-27 21:49     ` Will Deacon
2026-07-28  2:03     ` Hongyan Xia
2026-07-29 18:08   ` Steven Rostedt
2026-07-30  0:03     ` Masami Hiramatsu
2026-07-30 11:50       ` Hongyan Xia [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c7a6d63-b98a-4d8d-897f-50ad365026ff@transsion.com \
    --to=hongyan.xia@transsion.com \
    --cc=catalin.marinas@arm.com \
    --cc=cl@gentwo.org \
    --cc=davem@davemloft.net \
    --cc=dennis@kernel.org \
    --cc=hupu@transsion.com \
    --cc=jiazi.li@transsion.com \
    --cc=justinstitt@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=mhiramat@kernel.org \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=naveen@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=oleg@redhat.com \
    --cc=steven@rostedt.org \
    --cc=tj@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox