From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16DB62FD7B8 for ; Wed, 17 Sep 2025 18:34:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758134059; cv=none; b=S13LUIlvuQan8tsIIkBdCg7EoeJwTGN5RW9dWlHW4cnOae72VIHuXEkhBuCrhmp04eD8J/cDfC5BrPI9CvyWmWCJagPjGCyfqVW2XyXzbLCJCxGXSuUsAPiE/RnqTpFI33BjE2jjCzHCeZ2DzNfiAuIdQi8M7lMb3NjHiv7PbQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758134059; c=relaxed/simple; bh=3bnYGSqJJ0U3uhuPWHaq2lHDzYWemc/ZBgK/vRSmd3I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=P2RRO0Xu/AvKXC7JvxWniU0gTnNPJJwXM5TnRfrgWZvI2sbDbwcQG7m4NM7Kg5Gh9KXuaXfXb+zvkiDCaSY6rGJDzmwAJ8PetFF+Vps//eLjgYl0nxOj5JDUqAPlroCzY8MUwnOjpC3lLFo1ubb8h2YEcH7zCewa3dLg6uMU5iU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Y+5BzH2/; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y+5BzH2/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758134057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DGFF1TGksFvJE01BynPWTlxwwJdIv5IyqKnRBO/qFac=; b=Y+5BzH2/PpFnSKz81C6NYfnAV9RQ/6V7sdussdfF/ER/L+qAggfChVLYD8fdHBm37YK0V9 lfzZa/6jqRLYK8ldwXs6R0K9ZH3ic2QcDebBZblq0RK7A0TdpdEs+MFMd4r/MmQvrFdJCB DN86J+3ho+ova0pVzs1NIxyrMXT/AEE= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-564--2eK3icnNcq8CtAzCGv7Fw-1; Wed, 17 Sep 2025 14:34:15 -0400 X-MC-Unique: -2eK3icnNcq8CtAzCGv7Fw-1 X-Mimecast-MFC-AGG-ID: -2eK3icnNcq8CtAzCGv7Fw_1758134054 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-45cb612d362so386805e9.3 for ; Wed, 17 Sep 2025 11:34:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758134054; x=1758738854; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DGFF1TGksFvJE01BynPWTlxwwJdIv5IyqKnRBO/qFac=; b=ExBIKzXgH3i0hphPDW6mCQmxQjUVBkpeoF9h9vHLZRo4DfRFLIndGS7ipmdgpmamh0 swPW5K+evn3cLXqI6z1GwPSuIHPiBngGvUT3MRJiT9nMoqTkxMnIOmTWZ5us+h3B/cRZ xBMHOUo+x93HEqbZnDCpR1zVY4o6FY+3Yd8kg3vdgtrD6vcVjKzSSX83Ysb3Up5oB4sd IEvHGsPwPchXcdNa+hRocRHZ5+dQkzLLLy/PS7jID6ZPeCPpeLx1uBdrsbqq1xXp7dZx n2f6VWg2XCBmgVH17osfMDIipf9BmgruVOY+CYR7ZOABFEKWoOAZqZwQ6bRV64yTpk0Z TaEQ== X-Forwarded-Encrypted: i=1; AJvYcCXXMpnCugWE0HEmRAa1C2u18Knun46x7YrFucS/oXrB3Rk7pZIfl9s8a159Z6PkSX/cYQ1RBFP4ZrKb6XkwSktTYRc=@vger.kernel.org X-Gm-Message-State: AOJu0YzZvXTbmEq3tFl4RMyicJrLpzGt7FfGoa274Y+au+yl0NXlmZHA hOUBCXXifC2zSfkPXrZpA/Uat6bGOCjjNFDlSiWKCAkmiULAH1s53xFd6ICa8jNUqtqnc18Ulb7 EDAS/jZfnwYlr8JhhsnOXq8F0dt8jOo02G3EG0hA7578n8Ri1ajrD1zOk43bsq9L58NVYmW0lbg == X-Gm-Gg: ASbGncv9y3OboC929ZyG2vWX09QBlCAO10MbDvYoct83hl/PYmOFGa9jrFzHqTrMHcr 5lYyLyyjRf2Llmc4BeiiheRauZTbeBNSGTTX5dLmTqypmQ53hCjMHAPwMxo1FqwpJ5GqpjKC0/g teOG1ECYCl4YyuBDZQfxPKdsfcDzN7ZIOR/nOi/4IiTNFx3L5Zd0SkauGvN9Rsgi06cohOkCdMF cupKmYQ/uSl88VLgMU5Lnvb3Kh08hBtQQ5uhzad7cOfCt4P+nji7nZ7AKO9G1p85//6+OwHoHyv HoiiRi/XsDgD5wN57/aAQGxAtoA6MpWWNfZAe7c9UibP5A3MnbxGS3zBEcpC0y9q/UeoJUc= X-Received: by 2002:a05:600c:3b09:b0:45f:2d2a:e323 with SMTP id 5b1f17b1804b1-461fc6674f9mr32666705e9.0.1758134054032; Wed, 17 Sep 2025 11:34:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHedDcjLH9XDvUmI6R0DJmIUBsC8vdl45mHXNEs7FKudkuR4KrH37oiCo8ZAPtPFj7zk/sQEg== X-Received: by 2002:a05:600c:3b09:b0:45f:2d2a:e323 with SMTP id 5b1f17b1804b1-461fc6674f9mr32666305e9.0.1758134053593; Wed, 17 Sep 2025 11:34:13 -0700 (PDT) Received: from [192.168.3.141] (p4fe0f678.dip0.t-ipconnect.de. [79.224.246.120]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-464f527d6cdsm7187695e9.12.2025.09.17.11.34.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Sep 2025 11:34:12 -0700 (PDT) Message-ID: <322fd5d2-d7f4-40d8-8a06-6e7c5e9ef180@redhat.com> Date: Wed, 17 Sep 2025 20:34:10 +0200 Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/7] mm: add assertion for VMA count limit To: Kalesh Singh Cc: akpm@linux-foundation.org, minchan@kernel.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, rppt@kernel.org, pfalcato@suse.de, kernel-team@android.com, android-mm@google.com, Alexander Viro , Christian Brauner , Jan Kara , Kees Cook , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Valentin Schneider , Jann Horn , Shuah Khan , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20250915163838.631445-1-kaleshsingh@google.com> <20250915163838.631445-7-kaleshsingh@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xcyz2ftvT8VWvtDHg4F3usnrZuLu_AsvlRaY59no7og_1758134054 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit >> Can't that fire when changing the max count from user space at just the >> wrong time? > > You are right: technically it's possible if it was raised between the > time of checking and when the new VMA is added. > >> >> I assume we'll have to tolerated that and might just want to drop this >> patch from the series. >> > > It is compiled out in !CONFIG_VM_DEBUG builds, would we still want to drop it? Due to the racy nature I think any kinds of assertions would be wrong. Without any such races possible I would agree that the checks would be nice to have. -- Cheers David / dhildenb