From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D34A14F105 for ; Mon, 22 Apr 2024 14:27:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713796075; cv=none; b=cMq+uwHTnmrpB4V0prxhAkB2TSq4trysJoYThfuGBvIKJe/9cBJfEYirrhnujCeWqcvXL13RNUELmj8kx5Ir60A6ZL4e7cg0uTJK4gqCn/x5JYkBSJWnqBipM5rsMENdiSJvOBEYAjkzLQBjUGWTvjwb9c5J9ryBBe+Hvp8QjpQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713796075; c=relaxed/simple; bh=UNBjOTY0qs0uiF8EORx5BtyTGJtQ6MyutJpELBAOp5E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OyPGpXtYDRj3LPVd5Gj81DnQNl7SLXNSfkECSKKr5W5MlRq7udbPTcQvtG7DPGw8rLSGhyf1pWO0H/8sM4fhqElvPp+y20wmUK8ab8SbADQX6gHzQLwWIwWoE2EofQ6nD/FBBiVZlCDf9bay1ko4XCu2RQ0kNeZL25xuOB4smbs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AvRcdhh6; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AvRcdhh6" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-516d2b9cd69so5379057e87.2 for ; Mon, 22 Apr 2024 07:27:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713796072; x=1714400872; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UNBjOTY0qs0uiF8EORx5BtyTGJtQ6MyutJpELBAOp5E=; b=AvRcdhh6bssrwby6uQ53USsUaKKfA+EIjVX759zcaKj7AUOyOVcb5e+Gds//W8ik/P 5eJf9yOG2L6bWP60UKgMm61rwbzoWkWZLYigGPhAfGDqy9kao664Tjs5dmvX9EIccXVw uOtWZM92YdGqraWkksh+1ibfbv1kwFVdR1kFnPCGvBy719BZ5Mykhtp2V0VFlLdT/1+2 Ev3PlMbAsuz3Cu97Aos2IWeCW8Y4wwl51tee9K2Ct0OQ2BB5exzpelb6+XoMLtAkM/s1 ztNZT6H9z7X+3cWolCjRGbkIOC5aZYow7I6ZvEWXg2MmyEa5BihCupNafaKfF1Upekju qpYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713796072; x=1714400872; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UNBjOTY0qs0uiF8EORx5BtyTGJtQ6MyutJpELBAOp5E=; b=NdbKqcPacsobJttDzcRIc+hwEiHeq9oaVGM6Y4Mu0MaPGYbmHwDPMvhMtMqf1D8EF2 xzD85yWMpz6hPCXgLMPVAC29KwoNW2tqUruKm6taBppQTXPgGlgFN6rsHD6esm2fxdE4 lK7HAAr3N9CCF5qoaCXGNr6kUs7RyObuk6OkYtzSvwdJScOxu9RmRYGvXgc92U23tKHS jEftC7PF5FInbc7Yh2olDm1q/Gk2VngTU4wyWbaExZFJ/VWKAuCQlbF7IQP8nJLMPfXi 7QuK7NDRAIDmI65F9CJCnpyApomXJ/T1zSzkJfXngEnPL8kWQNSRlYkVoLGQjzbYCLlj aCXw== X-Forwarded-Encrypted: i=1; AJvYcCU2htFq4cDGXPxpBeoiyBfbbl6YWFmUsDUd4N9zRGM3qY7WXmMr6SiUP9AI+Qozc3fLNDn2TmHJaWVfEpSvf1vCmF8bl3GOfaOOB+1WzxtqfVz1 X-Gm-Message-State: AOJu0Yx2jml22xBA64y8llEXTHRw7zGzKvp110I6ced1Xx77T4CrZhJd 7zyor4bF3eyrQS7DJ8jzcFQiFymq3fkQCQyfoizdmaMKZWmR/B+C64FxKxrQxbA= X-Google-Smtp-Source: AGHT+IEkN6CNdQTBKxKxXZBn2HlML3rafBsTIUTuTxt2ocrHVbXK17h0QDhg5Z61h1NNgJ6JKtrQow== X-Received: by 2002:a2e:805a:0:b0:2db:99e4:dbdd with SMTP id p26-20020a2e805a000000b002db99e4dbddmr5541085ljg.53.1713796072319; Mon, 22 Apr 2024 07:27:52 -0700 (PDT) Received: from [172.30.205.46] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id p5-20020a2e93c5000000b002dce3eab848sm1076631ljh.47.2024.04.22.07.27.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Apr 2024 07:27:51 -0700 (PDT) Message-ID: <36a1ea2f-92c2-4183-a892-00c5b48c419b@linaro.org> Date: Mon, 22 Apr 2024 16:27:47 +0200 Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 00/10] sysctl: Remove sentinel elements from kernel dir To: Joel Granados , Luis Chamberlain , josh@joshtriplett.org, Kees Cook , Eric Biederman , Iurii Zaikin , Steven Rostedt , Masami Hiramatsu , Mark Rutland , Thomas Gleixner , John Stultz , Stephen Boyd , Andy Lutomirski , Will Drewry , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Petr Mladek , John Ogness , Sergey Senozhatsky , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Balbir Singh , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, tools@kernel.org References: <20240328-jag-sysctl_remove_empty_elem_kernel-v3-0-285d273912fe@samsung.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20240328-jag-sysctl_remove_empty_elem_kernel-v3-0-285d273912fe@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/28/24 16:44, Joel Granados wrote: > What? > These commits remove the sentinel element (last empty element) from the > sysctl arrays of all the files under the "kernel/" directory that use a > sysctl array for registration. The merging of the preparation patches > [1] to mainline allows us to remove sentinel elements without changing > behavior. This is safe because the sysctl registration code > (register_sysctl() and friends) use the array size in addition to > checking for a sentinel [2]. Hi, looks like *this* "patch" made it to the sysctl tree [1], breaking b4 for everyone else (as there's a "--- b4-submit-tracking ---" magic in the tree history now) on next-20240422 Please drop it (again, I'm only talking about this empty cover letter). Konrad [1] https://git.kernel.org/pub/scm/linux/kernel/git/sysctl/sysctl.git/commit/?h=sysctl-next&id=ec04a7fa09ddedc1d6c8b86ae281897256c7fdf0