From: Shuah Khan <skhan@linuxfoundation.org>
To: Steven Rostedt <rostedt@goodmis.org>,
Beau Belgrave <beaub@linux.microsoft.com>
Cc: shuah@kernel.org, mhiramat@kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v3] selftests/user_events: Fix abi_test for BE archs
Date: Tue, 17 Oct 2023 15:10:48 -0600 [thread overview]
Message-ID: <38a36f4c-c62a-44f0-a818-3ea7dc49654b@linuxfoundation.org> (raw)
In-Reply-To: <20231017163844.55d828bf@gandalf.local.home>
On 10/17/23 14:38, Steven Rostedt wrote:
> On Thu, 5 Oct 2023 21:57:12 +0000
> Beau Belgrave <beaub@linux.microsoft.com> wrote:
>
>> The abi_test currently uses a long sized test value for enablement
>> checks. On LE this works fine, however, on BE this results in inaccurate
>> assert checks due to a bit being used and assuming it's value is the
>> same on both LE and BE.
>>
>> Use int type for 32-bit values and long type for 64-bit values to ensure
>> appropriate behavior on both LE and BE.
>>
>> Fixes: 60b1af8de8c1 ("tracing/user_events: Add ABI self-test")
>> Signed-off-by: Beau Belgrave <beaub@linux.microsoft.com>
>> ---
>> V3 Changes:
>> Fix missing cast in clone_check().
>>
>> V2 Changes:
>> Rebase to linux-kselftest/fixes.
>
> Shuah,
>
> Can you take this patch?
>
> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
>
Thank you both. Applied to linux-kselftest fixes for Linux 6.6-rc7
thanks,
-- Shuah
prev parent reply other threads:[~2023-10-17 21:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 21:57 [PATCH v3] selftests/user_events: Fix abi_test for BE archs Beau Belgrave
2023-10-17 20:38 ` Steven Rostedt
2023-10-17 21:10 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38a36f4c-c62a-44f0-a818-3ea7dc49654b@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=beaub@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).