From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B8BFC7EE22 for ; Wed, 26 Apr 2023 18:25:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235095AbjDZSZ5 (ORCPT ); Wed, 26 Apr 2023 14:25:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231858AbjDZSZ4 (ORCPT ); Wed, 26 Apr 2023 14:25:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2D6383D6; Wed, 26 Apr 2023 11:25:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1EF6E637D9; Wed, 26 Apr 2023 18:25:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D15EC433D2; Wed, 26 Apr 2023 18:25:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682533553; bh=8scSkzABeTwq6U1ENTDR2ugXhnsGmDkZhoILw3OMkpQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=C6FcJ4OAMihx0yn5HULXNQjEJJv+qJaBSIrzCU/M+ZrhYZh2Hv+wi0lOA0mIjhC2a NtEzj6c35JMjjVP21Xmkc8KwE/HZYrbv2Bz4kqgCaYrvvUzcEUlu3b9vNgXFa2QjHl Lftz7QcXoFKVoLwRFX8b5pBg2XU62zrphY1flHmROmNDkHojn3xTAyZTqOcIxgigv4 TdhChUZqF84zrhKD9erQQ7kwyvIGQteevHs5cIKIU8ggFMV8BeqdV43AxI0aAX+tMN drqqviOfOj7DkB24JVcp2i2xy9Mp8Kj90/Q4W6LIuKLJ1ro8sVDJSVwTyuOB1N/1k6 hf9Jb/3YkIQvQ== Message-ID: <3a1cb6691bd913cadccbfaccf5ff642460eeac83.camel@kernel.org> Subject: Re: [RFC][PATCH 3/6] verification: Introduce verify_umd_signature() and verify_umd_message_sig() From: Jarkko Sakkinen To: Roberto Sassu , dhowells@redhat.com, dwmw2@infradead.org, herbert@gondor.apana.org.au, davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, rostedt@goodmis.org, mhiramat@kernel.org, mykolal@fb.com, shuah@kernel.org Cc: linux-kernel@vger.kernel.org, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Roberto Sassu Date: Wed, 26 Apr 2023 21:25:46 +0300 In-Reply-To: <40fbededd8dbe3b70fffb179574f344e9b0aed17.camel@huaweicloud.com> References: <20230425173557.724688-1-roberto.sassu@huaweicloud.com> <20230425173557.724688-4-roberto.sassu@huaweicloud.com> <40fbededd8dbe3b70fffb179574f344e9b0aed17.camel@huaweicloud.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.0-1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org On Wed, 2023-04-26 at 13:42 +0200, Roberto Sassu wrote: > On Wed, 2023-04-26 at 03:28 +0300, Jarkko Sakkinen wrote: > > On Tue Apr 25, 2023 at 8:35 PM EEST, Roberto Sassu wrote: > > > From: Roberto Sassu > > >=20 > > > Introduce verify_umd_signature() and verify_umd_message_sig(), to ver= ify > > > UMD-parsed signatures from detached data. It aims to be used by kerne= l > > > subsystems wishing to verify the authenticity of system data, with > > > system-defined keyrings as trust anchor. > >=20 > > UMD is not generic knowledge. It is a term coined up in this patch set > > so please open code it to each patch. >=20 > Yes, Linus also commented on this: >=20 > https://lwn.net/ml/linux-kernel/CAHk-=3DwihqhksXHkcjuTrYmC-vajeRcNh3s6eeo= JNxS7wp77dFQ@mail.gmail.com/ >=20 > I will check if the full name is mentioned at least once. So far, it > seems that using umd for function names should be ok. Also: "UMD-based parser for the asymmetric key type" It is a tautology: UMD is based on parser which based on UMD. I.e. makes no sense. Everyone hates three letter acronyms so I would consider not inventing a new one out of the void. So the corrective step would be to rename Kconfig flags as USER_ASYMMETRIC_KEY_PARSER and USER_ASYMMETRIC_SIGNATURE_PARSER. BR, Jarkko