From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0E841A275 for ; Wed, 10 Jun 2026 00:07:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781050042; cv=none; b=ZxVn+XFwPa7olpM5gs72MdfFKOtmWgCTkGdiRVllXNol9kLl218tS/ADxlupD1Sk4UotTDYzh99AWwM/dEaByMWH6PO3KpJd+thSwnH4IrMX6Fbf9P/hfKj3Pk0VOk1nvSlgziL6c3Lm8IBQ7nOayWjVFvmj/7aUgBs+cLECrRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781050042; c=relaxed/simple; bh=2JooMOCw4USXUxXqWYPWPyk0FF7skUtFE0PhzYfW9z4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Utu5XpUtil5UwgQl78jMI9uuaiEgiLx9VwUyAUFZiMJxBFAGNbLvJNuLuxr/UQFtesIW/E1dhtxa0FYRaOIPqFjwdjAyNoSBeAb3hX/kh7Jx6RB1CogvNnPl2GWX5vCa5wWchZfsR3xpQF+Iyn7WI9ANNz2faZrDsiW8uFh5GNU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=PvKUzKJl; arc=none smtp.client-ip=95.215.58.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="PvKUzKJl" Message-ID: <3e55e520-b979-4b1c-874c-3b4e5ca629e2@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1781050028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AwJzDDAOSFuZjBaB9TmeW/QSyG/8wM8MFjZ03MHUWhU=; b=PvKUzKJleDOKAW/fMSWZhcpCF9sreXbb/V2RKVKUALR0+9bhdUr9iSvrWc0vi/1DLR5ma5 l9dpIr39/jwnd2ZZ0anZNd+dHr1WXt/qr3I7YU1mj5BjZq+S+A9a0x7D0WPBYIzYiRqpqN +SgFOhvwGk5oxb5woyrW62JDeMXcomo= Date: Tue, 9 Jun 2026 17:07:00 -0700 Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] mm/lruvec: trace LRU add drains and drain-all queuing To: Barry Song Cc: linux-mm@kvack.org, willy@infradead.org, shakeel.butt@linux.dev, usama.arif@linux.dev, akpm@linux-foundation.org, vbabka@kernel.org, mhocko@suse.com, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, kasong@tencent.com, qi.zheng@linux.dev, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, chrisl@kernel.org, shikemeng@huaweicloud.com, nphamcs@gmail.com, baoquan.he@linux.dev, youngjun.park@lge.com, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org References: <20260609041156.31127-1-jp.kobryn@linux.dev> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: JP Kobryn In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 6/9/26 12:44 AM, Barry Song wrote: > On Tue, Jun 9, 2026 at 12:12 PM JP Kobryn wrote: >> >> LRU add batches can be drained before they reach capacity. This can be a >> source of LRU lock contention, but it is not currently possible to >> attribute these drains to callers with existing tracepoints. >> >> Add mm_lru_add_drain to report the CPU and lru_add batch count when an >> lru_add batch is drained. This allows tracing to distinguish full drains >> from partial drains and attribute them to the calling stack. >> >> Add mm_lru_drain_all_queue to report when lru_add_drain_all() queues >> per-CPU drain work. This captures the requester stack and target CPU for >> remote drain work. The event is named as a drain-all queue event because >> the queued work can be needed for batches other than lru_add. >> >> Signed-off-by: JP Kobryn >> --- >> include/trace/events/pagemap.h | 40 ++++++++++++++++++++++++++++++++++ >> mm/swap.c | 6 ++++- >> 2 files changed, 45 insertions(+), 1 deletion(-) >> >> diff --git a/include/trace/events/pagemap.h b/include/trace/events/pagemap.h >> index 171524d3526d..ea8fc46bedb0 100644 >> --- a/include/trace/events/pagemap.h >> +++ b/include/trace/events/pagemap.h >> @@ -77,6 +77,46 @@ TRACE_EVENT(mm_lru_activate, >> TP_printk("folio=%p pfn=0x%lx", __entry->folio, __entry->pfn) >> ); >> >> +TRACE_EVENT(mm_lru_add_drain, >> + >> + TP_PROTO(int cpu, unsigned int nr), >> + >> + TP_ARGS(cpu, nr), >> + >> + TP_STRUCT__entry( >> + __field(int, cpu ) >> + __field(unsigned int, nr ) >> + ), >> + >> + TP_fast_assign( >> + __entry->cpu = cpu; >> + __entry->nr = nr; >> + ), >> + >> + TP_printk("cpu=%d nr=%u", __entry->cpu, __entry->nr) >> +); >> + >> +TRACE_EVENT(mm_lru_drain_all_queue, >> + >> + TP_PROTO(int target_cpu, bool force_all_cpus), >> + >> + TP_ARGS(target_cpu, force_all_cpus), >> + >> + TP_STRUCT__entry( >> + __field(int, target_cpu ) >> + __field(bool, force_all_cpus ) >> + ), >> + >> + TP_fast_assign( >> + __entry->target_cpu = target_cpu; >> + __entry->force_all_cpus = force_all_cpus; >> + ), >> + >> + TP_printk("target_cpu=%d force_all_cpus=%s", >> + __entry->target_cpu, >> + __entry->force_all_cpus ? "true" : "false") >> +); >> + >> #endif /* _TRACE_PAGEMAP_H */ >> >> /* This part must be outside protection */ >> diff --git a/mm/swap.c b/mm/swap.c >> index 588f50d8f1a8..c385b93582eb 100644 >> --- a/mm/swap.c >> +++ b/mm/swap.c >> @@ -694,9 +694,12 @@ void lru_add_drain_cpu(int cpu) >> { >> struct cpu_fbatches *fbatches = &per_cpu(cpu_fbatches, cpu); >> struct folio_batch *fbatch = &fbatches->lru_add; >> + unsigned int nr_folios_add = folio_batch_count(fbatch); >> >> - if (folio_batch_count(fbatch)) >> + if (nr_folios_add) { >> folio_batch_move_lru(fbatch, lru_add); >> + trace_mm_lru_add_drain(cpu, nr_folios_add); >> + } >> >> fbatch = &fbatches->lru_move_tail; >> /* Disabling interrupts below acts as a compiler barrier. */ >> @@ -928,6 +931,7 @@ static inline void __lru_add_drain_all(bool force_all_cpus) >> if (cpu_needs_drain(cpu)) { >> INIT_WORK(work, lru_add_drain_per_cpu); >> queue_work_on(cpu, mm_percpu_wq, work); >> + trace_mm_lru_drain_all_queue(cpu, force_all_cpus); > > Do you need tracing on each CPU individually, or is tracing the > entire __lru_add_drain_all() invocation sufficient? I think the latter would be fine. The remote work will invoke the mm_lru_add_drain tracepoint, which will show up as kworker stacks. Since the event already has the CPU, we could see where queued drains actually ran. > > Do you also need this_gen and lru_drain_gen to be traced? As trace parameters, I don't think they give meaningful info on who is making requests to drain all. But since I'm going to move the trace call from within the CPU loop to earlier in the function we can still see requestors even if the function exits early because a parallel drain generation already satisfied the request. > > By the way, I'm not sure drain_all_queue is the best name here. > Why not simply use add_drain_all()? It would match the existing > function name better. The new tracepoint name can be mm_lru_add_drain_all.