From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BFED3D6CB9; Wed, 8 Apr 2026 18:25:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775672702; cv=none; b=aXjWNEx0a8erfD5EI52fd6a4Dh90tESoivyi9l4JTnCee7/7og3KCnzRG80urRj9SyaW6DiHCP7n00lUpr8UCMOkoMstsjHIK08ktrsFbhZAVgEtYYzxGIXklMc1sDj85Fk3qzLkzJ6RusiiFZlstetECWxALD2oL1GzU6CcNDg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775672702; c=relaxed/simple; bh=7AJ729q4Cp/bXTUy72jIeNaMdH0XzQ6V8oT9kikfxxQ=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=AXrDLHd4iQYwQh7uuZxHUyycrzmrAIu01n2uokyacsCapcssJBLGRNU+8R20a3+suKDvFOyKv8spBz8iBkQ6ZQPoDxUXknIsjFvjs5Sv7D2PbQgNmJ440XXRNCDS0HqZ7/R4u796rgyZUKESG0eEoQeGTjT5kIAYbMMnPYNPc3k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JCkLGMis; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JCkLGMis" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6445C2BCB0; Wed, 8 Apr 2026 18:25:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775672702; bh=7AJ729q4Cp/bXTUy72jIeNaMdH0XzQ6V8oT9kikfxxQ=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=JCkLGMisN5LRUINrQOqRYSNjDZ0Aul9bboyB7CbMNVHbEZxPta+JoUsraZx+bB+RO hvIhu83GA50rOAhv7In/EpUb8bnbRQ9loGhZljpbU8NLnIT9mdycCLANHFf6e/lhrg CHmU7Tn1zwstAKqoq0PHR1o71uTFjqelMpkYK7uaa0r8dwD0q/TdNB7wwrM5kBbVB+ XK5dRQLegPnfL0/NB3ZIwKpJoJVAh9eYiDWtfJ7VVulfWsXS+/xOMvWZ3s/dCJnqUG n5nso+ziBkpnmRp9RBtvMPM9wazQBUb331VywGES9twIkpiRVv7B9QOnINvJbBDJ4p mulP706T/rgHw== Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfauth.phl.internal (Postfix) with ESMTP id D0076F40071; Wed, 8 Apr 2026 14:24:59 -0400 (EDT) Received: from phl-imap-15 ([10.202.2.104]) by phl-compute-10.internal (MEProxy); Wed, 08 Apr 2026 14:24:59 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgddvgedvkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefoggffhffvvefkjghfufgtgfesthejredtredttdenucfhrhhomhepfdevhhhutghk ucfnvghvvghrfdcuoegtvghlsehkvghrnhgvlhdrohhrgheqnecuggftrfgrthhtvghrnh ephfffkefffedtgfehieevkeduuefhvdejvdefvdeuuddvgeelkeegtefgudfhfeelnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheptghhuhgtkh hlvghvvghrodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdduieefgeelleel heelqdefvdelkeeggedvfedqtggvlheppehkvghrnhgvlhdrohhrghesfhgrshhtmhgrih hlrdgtohhmpdhnsggprhgtphhtthhopedvgedpmhhouggvpehsmhhtphhouhhtpdhrtghp thhtohepnhgvihhlsegsrhhofihnrdhnrghmvgdprhgtphhtthhopehmrghthhhivghurd guvghsnhhohigvrhhssegvfhhfihgtihhoshdrtghomhdprhgtphhtthhopegrlhgvgidr rghrihhnghesghhmrghilhdrtghomhdprhgtphhtthhopegrmhhirhejfehilhesghhmrg hilhdrtghomhdprhgtphhtthhopehrohhsthgvughtsehgohhoughmihhsrdhorhhgpdhr tghpthhtoheprghnnhgrsehkvghrnhgvlhdrohhrghdprhgtphhtthhopegsrhgruhhnvg hrsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehjlhgrhihtohhnsehkvghrnhgvlhdr ohhrghdprhgtphhtthhopehmhhhirhgrmhgrtheskhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: ifa6e4810:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id A8E2C780070; Wed, 8 Apr 2026 14:24:59 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: Am-qK5lmH61J Date: Wed, 08 Apr 2026 14:24:39 -0400 From: "Chuck Lever" To: "Jeff Layton" , "Alexander Viro" , "Christian Brauner" , "Jan Kara" , "Chuck Lever" , "Alexander Aring" , "Steven Rostedt" , "Masami Hiramatsu" , "Mathieu Desnoyers" , "Jonathan Corbet" , "Shuah Khan" , NeilBrown , "Olga Kornievskaia" , "Dai Ngo" , "Tom Talpey" , "Trond Myklebust" , "Anna Schumaker" , "Amir Goldstein" Cc: "Calum Mackay" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-nfs@vger.kernel.org Message-Id: <412e143e-1e99-42a6-a959-654bde4e7038@app.fastmail.com> In-Reply-To: <20260407-dir-deleg-v1-8-aaf68c478abd@kernel.org> References: <20260407-dir-deleg-v1-0-aaf68c478abd@kernel.org> <20260407-dir-deleg-v1-8-aaf68c478abd@kernel.org> Subject: Re: [PATCH 08/24] nfsd: update the fsnotify mark when setting or removing a dir delegation Content-Type: text/plain Content-Transfer-Encoding: 7bit On Tue, Apr 7, 2026, at 9:21 AM, Jeff Layton wrote: > Add a new helper function that will update the mask on the nfsd_file's > fsnotify_mark to be a union of all current directory delegations on an > inode. Call that when directory delegations are added or removed. > > Signed-off-by: Jeff Layton > diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c > index c8fb84c38637..9a4cff08c67d 100644 > --- a/fs/nfsd/nfs4state.c > +++ b/fs/nfsd/nfs4state.c > @@ -1266,6 +1297,7 @@ static void nfs4_unlock_deleg_lease(struct > nfs4_delegation *dp) > WARN_ON_ONCE(!fp->fi_delegees); > > nfsd4_finalize_deleg_timestamps(dp, nf->nf_file); > + nfsd_fsnotify_recalc_mask(nf); > kernel_setlease(nf->nf_file, F_UNLCK, NULL, (void **)&dp); > put_deleg_file(fp); > } The grant path in nfsd_get_dir_deleg() uses a different ordering (setlease first, recalc_mask after). Here, since the delegation being removed is still in flc_lease, inode_lease_ignore_mask() includes its ignore flags. The mask is computed as if the delegation is still present. The result is that stale FS_CREATE/FS_DELETE/FS_RENAME bits remain in the fsnotify mark. It might be harmless in practice since the handler finds no leases and returns early, but it creates unnecessary work. Should nfs4_unlock_deleg_lease call nfsd_fsnotify_recalc_mask() after kernel_setlease(F_UNLCK)? -- Chuck Lever