From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 568D221322F; Mon, 18 Aug 2025 11:24:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755516246; cv=none; b=WY4fTciQf8rmK6g6xRnl0LwBvo0Q4Hq8czucBQGRYg+RyvqQT7IeGbuDs5tkUCHVkOe7ik5xgAxOCtHEZyu1HdBa6VgGCL+VjRmCTqVThCzF6bx6FrVDLAqpiLTZztsJGHHLb088sFwC4JU39i9KZUC9a4U/vykX83nh94o1zfg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755516246; c=relaxed/simple; bh=S8fx28ZOFv/aRwZ2Xxu1HcW0LeO59Bf0W+4lw52lHUo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AJE0TKSJUi2FNBr19dhvBWPxC6xL4MwXwOSiewpXUASFDNJG1Dd1IwJ2eSJfohvPFU9VTIm+HJ2RH72FxS1Fxpm9j5gCsXGholuj2fCgPu6NQKyuobGFdxQKUYqXWUStntiK338d1eYqoXd5pTzRYcwbXE3wyJ3HHzbw0mhHJ9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tXPhIcpr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tXPhIcpr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E674C4CEEB; Mon, 18 Aug 2025 11:24:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755516246; bh=S8fx28ZOFv/aRwZ2Xxu1HcW0LeO59Bf0W+4lw52lHUo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=tXPhIcprcunHMleGFLIvoG1s0XiCUEY2N9lcE3i6sadmegRADVYTVBlq3c242EyOX 8sNT3sdezjIpZqJpS4aioZ0DzojutaxSXEkpDyl8YOKEf2N5wefVvj4kwhUYaPX+j3 dHhf2o/643YaqP84+2K2k2IF0Qrq3BXNbXM+FO8xZU7AjwXHhN8A9Qb/uEWuKjMg6L GtNb96H8fqsjP/nYrP2xTdw5csi276T6jCX8kZF08Ijf2y1Dji/QvjrjOOo7vsau6z u2B5jxc3FCK33EQ6d73QTTJUQgqHoHJqiYw55TUuk1GsHsCPH66WZeGrRlH1oFirNL 5Ej4ll1/hIcUA== Message-ID: <4574e72d-5cc3-4ad2-beab-78dbeb34d42f@kernel.org> Date: Mon, 18 Aug 2025 06:24:00 -0500 Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 04/11] USB: Pass PMSG_POWEROFF event to suspend_common() for poweroff with S4 flow To: Oliver Neukum , "Rafael J . Wysocki" , Bjorn Helgaas Cc: Pavel Machek , Len Brown , Greg Kroah-Hartman , Danilo Krummrich , =?UTF-8?Q?Christian_K=C3=B6nig?= , "James E . J . Bottomley" , "Martin K . Petersen" , Steven Rostedt , "open list:HIBERNATION (aka Software Suspend, aka swsusp)" , "open list:RADEON and AMDGPU DRM DRIVERS" , "open list:DRM DRIVERS" , "open list:PCI SUBSYSTEM" , "open list:SCSI SUBSYSTEM" , "open list:USB SUBSYSTEM" , "open list:TRACING" , AceLan Kao , Kai-Heng Feng , Mark Pearson , =?UTF-8?Q?Merthan_Karaka=C5=9F?= , Eric Naim References: <20250818020101.3619237-1-superm1@kernel.org> <20250818020101.3619237-5-superm1@kernel.org> Content-Language: en-US From: Mario Limonciello In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 8/18/25 5:50 AM, Oliver Neukum wrote: > On 8/18/25 04:00, Mario Limonciello (AMD) wrote: >> If powering off the system with the S4 flow USB wakeup sources should >> be ignored. Add a new callback hcd_pci_poweroff() which will >> differentiate >> whether target state is S5 and pass PMSG_POWEROFF as the message so that >> suspend_common() will avoid doing wakeups. > > Hi, > > how will Wake-On-LAN work with this change? > >     Regards >         Oliver > From S5 using a USB dongle? Is this a use case that is intended to work today? Does it? I had expected this only intended from S4, S3 and s2idle.