From: Paolo Bonzini <pbonzini@redhat.com>
To: Ross Zwisler <zwisler@chromium.org>, linux-kernel@vger.kernel.org
Cc: Ross Zwisler <zwisler@google.com>,
kvm@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v2 4/6] tools/kvm_stat: use canonical ftrace path
Date: Fri, 17 Feb 2023 12:32:14 +0100 [thread overview]
Message-ID: <45e343f7-9b1b-fb23-30ee-4ba59b6dfa62@redhat.com> (raw)
In-Reply-To: <20230215223350.2658616-5-zwisler@google.com>
On 2/15/23 23:33, Ross Zwisler wrote:
> The canonical location for the tracefs filesystem is at /sys/kernel/tracing.
>
> But, from Documentation/trace/ftrace.rst:
>
> Before 4.1, all ftrace tracing control files were within the debugfs
> file system, which is typically located at /sys/kernel/debug/tracing.
> For backward compatibility, when mounting the debugfs file system,
> the tracefs file system will be automatically mounted at:
>
> /sys/kernel/debug/tracing
>
> A comment in kvm_stat still refers to this older debugfs path, so let's
> update it to avoid confusion.
>
> Signed-off-by: Ross Zwisler <zwisler@google.com>
> ---
> tools/kvm/kvm_stat/kvm_stat | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/kvm/kvm_stat/kvm_stat b/tools/kvm/kvm_stat/kvm_stat
> index 6f28180ffeea..15bf00e79e3f 100755
> --- a/tools/kvm/kvm_stat/kvm_stat
> +++ b/tools/kvm/kvm_stat/kvm_stat
> @@ -627,7 +627,7 @@ class TracepointProvider(Provider):
> name)'.
>
> All available events have directories under
> - /sys/kernel/debug/tracing/events/ which export information
> + /sys/kernel/tracing/events/ which export information
> about the specific event. Therefore, listing the dirs gives us
> a list of all available events.
>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2023-02-17 11:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 22:33 [PATCH v2 0/6] use canonical ftrace path whenever possible Ross Zwisler
2023-02-15 22:33 ` [PATCH v2 1/6] tracing: always use canonical ftrace path Ross Zwisler
2023-02-16 15:13 ` Masami Hiramatsu
2023-02-17 15:34 ` Mukesh Ojha
2023-02-15 22:33 ` [PATCH v2 2/6] selftests: " Ross Zwisler
2023-02-16 20:58 ` Steven Rostedt
2023-02-17 15:40 ` Mukesh Ojha
2023-02-15 22:33 ` [PATCH v2 3/6] leaking_addresses: also skip " Ross Zwisler
2023-02-15 22:33 ` [PATCH v2 4/6] tools/kvm_stat: use " Ross Zwisler
2023-02-16 21:08 ` Steven Rostedt
2023-02-17 11:32 ` Paolo Bonzini [this message]
2023-02-17 15:41 ` Mukesh Ojha
2023-02-15 22:33 ` [PATCH v2 5/6] tools/virtio: " Ross Zwisler
2023-02-17 15:46 ` Mukesh Ojha
2023-06-02 11:15 ` Michael S. Tsirkin
2023-02-15 22:33 ` [PATCH v2 6/6] tools/virtio: fix typo in README instructions Ross Zwisler
2023-03-10 8:29 ` [PATCH v2 0/6] use canonical ftrace path whenever possible Michael S. Tsirkin
2023-03-10 19:06 ` Ross Zwisler
2023-03-10 19:37 ` Steven Rostedt
2023-03-22 2:32 ` Michael S. Tsirkin
2023-03-22 16:52 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45e343f7-9b1b-fb23-30ee-4ba59b6dfa62@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=zwisler@chromium.org \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).