From: Jens Axboe <axboe@kernel.dk>
To: Chaitanya Kulkarni <kch@nvidia.com>,
rostedt@goodmis.org, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com
Cc: shinichiro.kawasaki@wdc.com, linux-block@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] blktrace: fix __this_cpu_read/write in preemptible context
Date: Fri, 27 Feb 2026 09:48:09 -0700 [thread overview]
Message-ID: <488e0beb-d18c-4fce-9787-2fb9ea01f677@kernel.dk> (raw)
In-Reply-To: <20260227050303.10945-1-kch@nvidia.com>
On 2/26/26 10:03 PM, Chaitanya Kulkarni wrote:
> tracing_record_cmdline() internally uses __this_cpu_read() and
> __this_cpu_write() on the per-CPU variable trace_taskinfo_save, and
> trace_save_cmdline() explicitly asserts preemption is disabled via
> lockdep_assert_preemption_disabled(). These operations are safe only
> when preemption is off, as they were designed to be called from the
> scheduler's context probe_wakeup_sched_switch() / probe_wakeup().
>
> __blk_add_trace() calls tracing_record_cmdline(current) from process
> context where preemption is fully enabled, triggering the following
> splat on using blktests/blktrace/002:
>
> blktrace/002 (blktrace ftrace corruption with sysfs trace) [failed]
> runtime 0.367s ... 0.437s
> something found in dmesg:
> [ 81.211018] run blktests blktrace/002 at 2026-02-25 22:24:33
> [ 81.239580] null_blk: disk nullb1 created
> [ 81.357294] BUG: using __this_cpu_read() in preemptible [00000000] code: dd/2516
> [ 81.362842] caller is tracing_record_cmdline+0x10/0x40
> [ 81.362872] CPU: 16 UID: 0 PID: 2516 Comm: dd Tainted: G N 7.0.0-rc1lblk+ #84 PREEMPT(full)
> [ 81.362877] Tainted: [N]=TEST
> [ 81.362878] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.17.0-0-gb52ca86e094d-prebuilt.qemu.org 04/01/2014
> [ 81.362881] Call Trace:
> [ 81.362884] <TASK>
> [ 81.362886] dump_stack_lvl+0x8d/0xb0
> ...
> (See '/mnt/sda/blktests/results/nodev/blktrace/002.dmesg' for the entire message)
>
> [ 81.211018] run blktests blktrace/002 at 2026-02-25 22:24:33
> [ 81.239580] null_blk: disk nullb1 created
> [ 81.357294] BUG: using __this_cpu_read() in preemptible [00000000] code: dd/2516
> [ 81.362842] caller is tracing_record_cmdline+0x10/0x40
> [ 81.362872] CPU: 16 UID: 0 PID: 2516 Comm: dd Tainted: G N 7.0.0-rc1lblk+ #84 PREEMPT(full)
> [ 81.362877] Tainted: [N]=TEST
> [ 81.362878] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.17.0-0-gb52ca86e094d-prebuilt.qemu.org 04/01/2014
> [ 81.362881] Call Trace:
> [ 81.362884] <TASK>
> [ 81.362886] dump_stack_lvl+0x8d/0xb0
> [ 81.362895] check_preemption_disabled+0xce/0xe0
> [ 81.362902] tracing_record_cmdline+0x10/0x40
> [ 81.362923] __blk_add_trace+0x307/0x5d0
> [ 81.362934] ? lock_acquire+0xe0/0x300
> [ 81.362940] ? iov_iter_extract_pages+0x101/0xa30
> [ 81.362959] blk_add_trace_bio+0x106/0x1e0
> [ 81.362968] submit_bio_noacct_nocheck+0x24b/0x3a0
> [ 81.362979] ? lockdep_init_map_type+0x58/0x260
> [ 81.362988] submit_bio_wait+0x56/0x90
> [ 81.363009] __blkdev_direct_IO_simple+0x16c/0x250
> [ 81.363026] ? __pfx_submit_bio_wait_endio+0x10/0x10
> [ 81.363038] ? rcu_read_lock_any_held+0x73/0xa0
> [ 81.363051] blkdev_read_iter+0xc1/0x140
> [ 81.363059] vfs_read+0x20b/0x330
> [ 81.363083] ksys_read+0x67/0xe0
> [ 81.363090] do_syscall_64+0xbf/0xf00
> [ 81.363102] entry_SYSCALL_64_after_hwframe+0x76/0x7e
> [ 81.363106] RIP: 0033:0x7f281906029d
> [ 81.363111] Code: 31 c0 e9 c6 fe ff ff 50 48 8d 3d 66 63 0a 00 e8 59 ff 01 00 66 0f 1f 84 00 00 00 00 00 80 3d 41 33 0e 00 00 74 17 31 c0 0f 05 <48> 3d 00 f0 ff ff 77 5b c3 66 2e 0f 1f 84 00 00 00 00 00 48 83 ec
> [ 81.363113] RSP: 002b:00007ffca127dd48 EFLAGS: 00000246 ORIG_RAX: 0000000000000000
> [ 81.363120] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f281906029d
> [ 81.363122] RDX: 0000000000001000 RSI: 0000559f8bfae000 RDI: 0000000000000000
> [ 81.363123] RBP: 0000000000001000 R08: 0000002863a10a81 R09: 00007f281915f000
> [ 81.363124] R10: 00007f2818f77b60 R11: 0000000000000246 R12: 0000559f8bfae000
> [ 81.363126] R13: 0000000000000000 R14: 0000000000000000 R15: 000000000000000a
> [ 81.363142] </TASK>
Is this a new issue? Needs a Fixes tag.
--
Jens Axboe
next prev parent reply other threads:[~2026-02-27 16:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 5:03 [PATCH] blktrace: fix __this_cpu_read/write in preemptible context Chaitanya Kulkarni
2026-02-27 16:48 ` Jens Axboe [this message]
2026-02-27 19:19 ` Steven Rostedt
2026-02-27 23:08 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488e0beb-d18c-4fce-9787-2fb9ea01f677@kernel.dk \
--to=axboe@kernel.dk \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox