From: Jens Axboe <axboe@kernel.dk>
To: Steven Rostedt <rostedt@goodmis.org>,
"Vineeth Pillai (Google)" <vineeth@bitbyteword.org>
Cc: io-uring@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v3 01/11] io_uring: Use trace_call__##name() at guarded tracepoint call sites
Date: Fri, 15 May 2026 08:06:13 -0600 [thread overview]
Message-ID: <49e77605-6227-426e-8103-329474bf88f9@kernel.dk> (raw)
In-Reply-To: <20260515100448.715589f6@gandalf.local.home>
On 5/15/26 8:04 AM, Steven Rostedt wrote:
> On Fri, 15 May 2026 09:59:03 -0400
> "Vineeth Pillai (Google)" <vineeth@bitbyteword.org> wrote:
>
>> From: Vineeth Pillai <vineeth@bitbyteword.org>
>>
>
> Hi Vineeth,
>
>> Replace trace_foo() with the new trace_call__foo() at sites already
>> guarded by trace_foo_enabled(), avoiding a redundant
>> static_branch_unlikely() re-evaluation inside the tracepoint.
>> trace_call__foo() calls the tracepoint callbacks directly without
>> utilizing the static branch again.
>>
>
>> Original v2 series:
>> https://lore.kernel.org/linux-trace-kernel/20260323160052.17528-1-vineeth@bitbyteword.org/
>>
>> Parts of the original v2 series have already been merged in mainline.
>> This patch is being reposted as a follow-up cleanup for the remaining
>> unmerged pieces.
>
> This part should go below the '---'. There's no reason to add it to the git
> change log.
I pruned it.
> You should probably also state that these can now go in individually as all
> the dependencies are upstream.
I think he did, at least that's how I read it.
--
Jens Axboe
next prev parent reply other threads:[~2026-05-15 14:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 13:59 [PATCH v3 01/11] io_uring: Use trace_call__##name() at guarded tracepoint call sites Vineeth Pillai (Google)
2026-05-15 14:02 ` (subset) " Jens Axboe
2026-05-15 14:04 ` Steven Rostedt
2026-05-15 14:06 ` Jens Axboe [this message]
2026-05-15 14:14 ` Vineeth Remanan Pillai
2026-05-15 14:25 ` Jens Axboe
2026-05-15 14:29 ` Vineeth Remanan Pillai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49e77605-6227-426e-8103-329474bf88f9@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vineeth@bitbyteword.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox