* [PATCH] docs: trace: Fix typo in ftrace.rst
@ 2023-04-12 18:37 Lin Yu Chen
2023-04-13 2:19 ` Bagas Sanjaya
2023-04-20 16:13 ` Jonathan Corbet
0 siblings, 2 replies; 4+ messages in thread
From: Lin Yu Chen @ 2023-04-12 18:37 UTC (permalink / raw)
To: corbet
Cc: rostedt, mhiramat, mark.rutland, linux-kernel, linux-trace-kernel,
linux-doc, Lin Yu Chen
There is a typo in the sentence "A kernel developer must be
conscience ...". The word conscience should be conscious.
This patch fixes it.
Signed-off-by: Lin Yu Chen <starpt.official@gmail.com>
---
Documentation/trace/ftrace.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/trace/ftrace.rst b/Documentation/trace/ftrace.rst
index b927fb2b94dc..e8bca5fea7cc 100644
--- a/Documentation/trace/ftrace.rst
+++ b/Documentation/trace/ftrace.rst
@@ -3510,7 +3510,7 @@ directories, the rmdir will fail with EBUSY.
Stack trace
-----------
Since the kernel has a fixed sized stack, it is important not to
-waste it in functions. A kernel developer must be conscience of
+waste it in functions. A kernel developer must be conscious of
what they allocate on the stack. If they add too much, the system
can be in danger of a stack overflow, and corruption will occur,
usually leading to a system panic.
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] docs: trace: Fix typo in ftrace.rst
2023-04-12 18:37 [PATCH] docs: trace: Fix typo in ftrace.rst Lin Yu Chen
@ 2023-04-13 2:19 ` Bagas Sanjaya
2023-04-13 2:38 ` Steven Rostedt
2023-04-20 16:13 ` Jonathan Corbet
1 sibling, 1 reply; 4+ messages in thread
From: Bagas Sanjaya @ 2023-04-13 2:19 UTC (permalink / raw)
To: Lin Yu Chen, corbet
Cc: rostedt, mhiramat, mark.rutland, linux-kernel, linux-trace-kernel,
linux-doc
On 4/13/23 01:37, Lin Yu Chen wrote:
> There is a typo in the sentence "A kernel developer must be
> conscience ...". The word conscience should be conscious.
> This patch fixes it.
>
Please don't say "This patch does foo".
> -waste it in functions. A kernel developer must be conscience of
> +waste it in functions. A kernel developer must be conscious of
Alternatively, what about "aware of"?
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] docs: trace: Fix typo in ftrace.rst
2023-04-13 2:19 ` Bagas Sanjaya
@ 2023-04-13 2:38 ` Steven Rostedt
0 siblings, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2023-04-13 2:38 UTC (permalink / raw)
To: Bagas Sanjaya
Cc: Lin Yu Chen, corbet, mhiramat, mark.rutland, linux-kernel,
linux-trace-kernel, linux-doc
On Thu, 13 Apr 2023 09:19:12 +0700
Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> On 4/13/23 01:37, Lin Yu Chen wrote:
> > There is a typo in the sentence "A kernel developer must be
> > conscience ...". The word conscience should be conscious.
> > This patch fixes it.
> >
>
> Please don't say "This patch does foo".
Yes, that part can be left out.
>
> > -waste it in functions. A kernel developer must be conscience of
> > +waste it in functions. A kernel developer must be conscious of
>
> Alternatively, what about "aware of"?
>
As the author of this document, and the one that doesn't have a conscience
about using conscious correctly, I approve of Lin Yu's change.
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Thanks!
-- Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] docs: trace: Fix typo in ftrace.rst
2023-04-12 18:37 [PATCH] docs: trace: Fix typo in ftrace.rst Lin Yu Chen
2023-04-13 2:19 ` Bagas Sanjaya
@ 2023-04-20 16:13 ` Jonathan Corbet
1 sibling, 0 replies; 4+ messages in thread
From: Jonathan Corbet @ 2023-04-20 16:13 UTC (permalink / raw)
To: Lin Yu Chen
Cc: rostedt, mhiramat, mark.rutland, linux-kernel, linux-trace-kernel,
linux-doc, Lin Yu Chen
Lin Yu Chen <starpt.official@gmail.com> writes:
> There is a typo in the sentence "A kernel developer must be
> conscience ...". The word conscience should be conscious.
> This patch fixes it.
>
> Signed-off-by: Lin Yu Chen <starpt.official@gmail.com>
> ---
> Documentation/trace/ftrace.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/trace/ftrace.rst b/Documentation/trace/ftrace.rst
> index b927fb2b94dc..e8bca5fea7cc 100644
> --- a/Documentation/trace/ftrace.rst
> +++ b/Documentation/trace/ftrace.rst
> @@ -3510,7 +3510,7 @@ directories, the rmdir will fail with EBUSY.
> Stack trace
> -----------
> Since the kernel has a fixed sized stack, it is important not to
> -waste it in functions. A kernel developer must be conscience of
> +waste it in functions. A kernel developer must be conscious of
> what they allocate on the stack. If they add too much, the system
> can be in danger of a stack overflow, and corruption will occur,
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-04-20 16:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-12 18:37 [PATCH] docs: trace: Fix typo in ftrace.rst Lin Yu Chen
2023-04-13 2:19 ` Bagas Sanjaya
2023-04-13 2:38 ` Steven Rostedt
2023-04-20 16:13 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).