Linux Trace Kernel
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Xie Yuanbin <xieyuanbin1@huawei.com>,
	qiuxu.zhuo@intel.com, bp@alien8.de, akpm@linux-foundation.org,
	rostedt@goodmis.org, linmiaohe@huawei.com
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org,
	mchehab+huawei@kernel.org, tony.luck@intel.com,
	torvalds@linux-foundation.org, yi1.lai@intel.com
Subject: Re: mm/memory-failure tracepoint change breaks userspace rasdaemon
Date: Thu, 4 Jun 2026 08:42:37 +0200	[thread overview]
Message-ID: <4de75e51-025c-4926-871a-4b9da479cefa@kernel.org> (raw)
In-Reply-To: <20260604014629.3144-1-xieyuanbin1@huawei.com>

On 6/4/26 03:46, Xie Yuanbin wrote:
> On Wed, 3 Jun 2026 21:13:30 +0200, David Hildenbrand (Arm) wrote:
>> Would the following be sufficient to avoid a full revert and the dependency on CONFIG_RAS?
>>
>> diff --git a/include/trace/events/memory-failure.h b/include/trace/events/memory-failure.h
>> index aa57cc8f896b..c46b17602578 100644
>> --- a/include/trace/events/memory-failure.h
>> +++ b/include/trace/events/memory-failure.h
>> @@ -1,6 +1,7 @@
>>  /* SPDX-License-Identifier: GPL-2.0 */
>>  #undef TRACE_SYSTEM
>> -#define TRACE_SYSTEM memory_failure
>> +/* Some user space relies on ras/memory_failure_event */
>> +#define TRACE_SYSTEM ras
>>  #define TRACE_INCLUDE_FILE memory-failure
>>
>>  #if !defined(_TRACE_MEMORY_FAILURE_H) || defined(TRACE_HEADER_MULTI_READ)
> 
> Yes, it should be. In fact, when I sent the V2 patch, I had already
> considered this issue, and that's exactly what I did:
> Link: https://lore.kernel.org/20251104072306.100738-3-xieyuanbin1@huawei.com
> 
> However, David Hildenbrand advised me at that time to completely
> remove the dependence on RAS:
> Link: https://lore.kernel.org/01b44e0f-ea2e-406f-9f65-b698b5504f42@kernel.org

Yeah, if only I had known that we would break user space by changing trace
events ... now we know :)

Do you have capacity to send a fix?

-- 
Cheers,

David

  reply	other threads:[~2026-06-04  6:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CY8PR11MB7134346A3E4BB28ECA28D6E989132@CY8PR11MB7134.namprd11.prod.outlook.com>
2026-06-03 13:44 ` mm/memory-failure tracepoint change breaks userspace rasdaemon David Hildenbrand (Arm)
2026-06-03 16:17   ` Steven Rostedt
2026-06-03 16:19     ` Borislav Petkov
2026-06-03 16:26       ` David Hildenbrand (Arm)
2026-06-03 17:00         ` Steven Rostedt
2026-06-03 19:13           ` David Hildenbrand (Arm)
2026-06-03 19:30             ` Steven Rostedt
2026-06-03 19:31             ` Steven Rostedt
2026-06-04  1:46             ` Xie Yuanbin
2026-06-04  6:42               ` David Hildenbrand (Arm) [this message]
2026-06-03 19:54           ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4de75e51-025c-4926-871a-4b9da479cefa@kernel.org \
    --to=david@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=linmiaohe@huawei.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=qiuxu.zhuo@intel.com \
    --cc=rostedt@goodmis.org \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=xieyuanbin1@huawei.com \
    --cc=yi1.lai@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox