From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Tal Yacobi <talycb8@gmail.com>,
matt@codeconstruct.com.au, rostedt@goodmis.org,
mhiramat@kernel.org, mathieu.desnoyers@efficios.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] mctp i2c: Add rx trace
Date: Wed, 29 May 2024 07:54:08 +0800 [thread overview]
Message-ID: <520cf8db945cf8dce4afdaddb59ceda65463a406.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20240528143420.742611-1-talycb8@gmail.com>
Hi Tal,
Thanks for the contribution! Some comments:
> mctp-i2c rx implementation doesn't call
> __i2c_transfer which calls the i2c reply trace function.
No, but we can trace the i2c rx path through the trace_i2c_slave
tracepoint. It is a little messier than tracing trace_i2c_write, but
has been sufficient with the debugging I've needed in the past.
> Add an mctp_reply trace function that will be used instead.
Can you elaborate a little on what you were/are looking to inspect
here? (mainly: which packet fields are you interested in?) That will
help to determine the best approach here.
Cheers,
Jeremy
next prev parent reply other threads:[~2024-05-28 23:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 14:34 [PATCH] mctp i2c: Add rx trace Tal Yacobi
2024-05-28 23:54 ` Jeremy Kerr [this message]
2024-05-29 17:01 ` Tal Yacobi
2024-05-30 8:42 ` Jeremy Kerr
2024-05-31 22:13 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520cf8db945cf8dce4afdaddb59ceda65463a406.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=matt@codeconstruct.com.au \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=talycb8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).