From: Jens Axboe <axboe@kernel.dk>
To: Jason Xing <kerneljasonxing@gmail.com>,
rostedt@goodmis.org, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
Jason Xing <kernelxing@tencent.com>,
Yushan Zhou <katrinzhou@tencent.com>
Subject: Re: [PATCH v2 3/4] blktrace: use rbuf->stats.full as a drop indicator in relayfs
Date: Thu, 15 May 2025 12:21:34 -0600 [thread overview]
Message-ID: <543ef493-a478-4e92-b384-f6ff299b11fb@kernel.dk> (raw)
In-Reply-To: <20250515061643.31472-4-kerneljasonxing@gmail.com>
On 5/15/25 12:16 AM, Jason Xing wrote:
> From: Jason Xing <kernelxing@tencent.com>
>
> Replace internal subbuf_start in blktrace with the default policy
> in relayfs.
>
> Remove dropped field from struct blktrace. Correspondingly, call the
> common helper in relay. Through incrementing full_count to keep track
> of how many times we encountered a full buffer issue, it aids the user
> space app in telling how many lost events appear.
Forgot, I'd rewrite this, "telling how many lost events appear" doesn't
make any sense at all, as these events obviously don't appears in the
first place.
By incrementing full_count to keep track of how many times we
encountered a full buffer issue, user space will know how many events
were lost.
--
Jens Axboe
next prev parent reply other threads:[~2025-05-15 18:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 6:16 [PATCH v2 0/4] relayfs: misc changes Jason Xing
2025-05-15 6:16 ` [PATCH v2 1/4] relayfs: support a counter tracking if per-cpu buffers is full Jason Xing
2025-05-15 18:17 ` Jens Axboe
2025-05-15 6:16 ` [PATCH v2 2/4] relayfs: introduce dump of relayfs statistics function Jason Xing
2025-05-15 18:19 ` Jens Axboe
2025-05-15 23:24 ` Jason Xing
2025-05-16 2:08 ` Masami Hiramatsu
2025-05-16 2:32 ` Jason Xing
2025-05-16 4:37 ` Christoph Hellwig
2025-05-16 5:02 ` Jason Xing
2025-05-16 5:06 ` Christoph Hellwig
2025-05-16 5:44 ` Jason Xing
2025-05-15 6:16 ` [PATCH v2 3/4] blktrace: use rbuf->stats.full as a drop indicator in relayfs Jason Xing
2025-05-15 18:19 ` Jens Axboe
2025-05-15 18:21 ` Jens Axboe [this message]
2025-05-15 23:26 ` Jason Xing
2025-05-15 6:16 ` [PATCH v2 4/4] relayfs: support a counter tracking if data is too big to write Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543ef493-a478-4e92-b384-f6ff299b11fb@kernel.dk \
--to=axboe@kernel.dk \
--cc=akpm@linux-foundation.org \
--cc=katrinzhou@tencent.com \
--cc=kerneljasonxing@gmail.com \
--cc=kernelxing@tencent.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).