Re: [PATCH linux-next 1/2] perf: Remove unnecessary parameter of security check

[Luo Gengkun <luogengkun@huaweicloud.com>]

On 2025/1/5 10:45, Paul Moore wrote:
> On Mon, Dec 23, 2024 at 1:57 AM Luo Gengkun <luogengkun@huaweicloud.com> wrote:
>> It seems that the attr parameter was never been used in security
>> checks since it was first introduced by:
>>
>> commit da97e18458fb ("perf_event: Add support for LSM and SELinux checks")
>>
>> so remove it.
>>
>> Signed-off-by: Luo Gengkun <luogengkun@huaweicloud.com>
>> ---
>>   arch/x86/events/intel/bts.c     |  2 +-
>>   arch/x86/events/intel/core.c    |  2 +-
>>   arch/x86/events/intel/p4.c      |  2 +-
>>   drivers/perf/arm_spe_pmu.c      |  4 ++--
>>   include/linux/lsm_hook_defs.h   |  2 +-
>>   include/linux/perf_event.h      | 10 +++++-----
>>   include/linux/security.h        |  5 ++---
>>   kernel/events/core.c            | 14 +++++++-------
>>   kernel/trace/trace_event_perf.c |  4 ++--
>>   security/security.c             |  5 ++---
>>   security/selinux/hooks.c        |  2 +-
>>   11 files changed, 25 insertions(+), 27 deletions(-)
> This patch seems fine to me from a LSM and SELinux perspective, but
> I'd want to see an ACK from the perf folks before I merge this.
>
> I'll also leave patch 2/2 for the perf folks as it seems largely
> unrelated to this patch.

Thanks for your review

Gengkun