Re: [PATCH v6 12/16] sched: Add deadline tracepoints

[Gabriele Monaco <gmonaco@redhat.com>]

Hello,

On Mon, 2026-03-02 at 15:15 +0100, Juri Lelli wrote:
> > diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> > index 4ca79ff58fca..b5bb2eb112bf 100644
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -124,6 +124,10 @@ EXPORT_TRACEPOINT_SYMBOL_GPL(sched_exit_tp);
> >  EXPORT_TRACEPOINT_SYMBOL_GPL(sched_set_need_resched_tp);
> >  EXPORT_TRACEPOINT_SYMBOL_GPL(sched_enqueue_tp);
> >  EXPORT_TRACEPOINT_SYMBOL_GPL(sched_dequeue_tp);
> > +EXPORT_TRACEPOINT_SYMBOL_GPL(sched_dl_throttle_tp);
> > +EXPORT_TRACEPOINT_SYMBOL_GPL(sched_dl_replenish_tp);
> > +EXPORT_TRACEPOINT_SYMBOL_GPL(sched_dl_server_start_tp);
> > +EXPORT_TRACEPOINT_SYMBOL_GPL(sched_dl_server_stop_tp);
> 
> Don't we need to export sched_dl_update_tp as well?

Right, we do.

> 
> >  DEFINE_PER_CPU_SHARED_ALIGNED(struct rq, runqueues);
> >  DEFINE_PER_CPU(struct rnd_state, sched_rnd_state);
> 
> ...
> 
> > @@ -1532,7 +1551,8 @@ static void update_curr_dl_se(struct rq *rq, struct
> > sched_dl_entity *dl_se, s64
> >  
> >  		if (!is_leftmost(dl_se, &rq->dl))
> >  			resched_curr(rq);
> > -	}
> > +	} else
> > +		trace_sched_dl_update_tp(dl_se, cpu_of(rq),
> > dl_get_type(dl_se, rq));
> 
> This wants braces even if it's a single statement.

Alright, will fix.

Thanks,
Gabriele