From: Gabriele Monaco <gmonaco@redhat.com>
To: wen.yang@linux.dev
Cc: Nam Cao <namcao@linutronix.de>,
linux-trace-kernel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 05/14] rv: Add a KUnit test for the storage free path
Date: Fri, 20 Nov 2026 18:02:23 +0100 [thread overview]
Message-ID: <5cb05c823110358e588c651778c981cb278335e9.camel@redhat.com> (raw)
In-Reply-To: <a00e4d311cbb9da36a621177f8b2c420bd532c7f.1793900349.git.wen.yang@linux.dev>
On Fri, 2026-11-06 at 01:49 +0800, wen.yang@linux.dev wrote:
> +static void rv_test_rvtest_arm_after_destroy(struct kunit *test)
> +{
> + const int id = 4242;
> + struct da_monitor *stale;
> +
> + atomic_set(&rvtest_expired, 0);
> + da_monitor_init();
> + rv_this.enabled = 1;
> +
> + da_handle_start_run_event(id, NULL, start_rvtest);
> +
> + scoped_guard(rcu) /* resolve before the unlink
> */
> + stale = da_get_monitor(id, NULL);
> + KUNIT_ASSERT_NOT_NULL(test, stale);
> +
> + da_destroy_storage(id); /* cancel, unlink,
> call_rcu */
> + ha_start_timer_ns(to_ha_monitor(stale), clk_rvtest,
> + RVTEST_BUDGET_NS, ha_get_ns());
Like sashiko suggested, you aren't really supposed to use stale outside the same
RCU window, the scoped guard should probably come up to here.
> +
> + rcu_barrier();
> +
> + /* A timer the free path missed expires here. */
> + msleep(600);
This feels like a magic number, are you trying to say something like wait for
twice the budget?
Something more explicit would probably be better.
Thanks,
Gabriele
> + KUNIT_EXPECT_EQ(test, atomic_read(&rvtest_expired), 0);
> + da_monitor_destroy();
> + rv_this.enabled = 0;
> +}
> +
> static struct kunit_case rv_ha_kunit_cases[] = {
> KUNIT_CASE(rv_test_rvtest_underflow),
> + KUNIT_CASE(rv_test_rvtest_arm_after_destroy),
> {}
> };
>
next prev parent reply other threads:[~2026-11-20 17:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 17:49 [PATCH v8 00/14] rv: Add task latency over budget RV monitor wen.yang
2026-11-05 17:49 ` [PATCH v8 01/14] rv: Force environment reset action on HA monitor start wen.yang
2026-11-05 17:49 ` [PATCH v8 02/14] rv: Fix ha_monitor timer and invariant underflow wen.yang
2026-11-19 14:34 ` Gabriele Monaco
2026-11-05 17:49 ` [PATCH v8 03/14] rv: Add a KUnit test for the HA timer underflow wen.yang
2026-11-19 15:07 ` Gabriele Monaco
2026-11-05 17:49 ` [PATCH v8 04/14] rv: Disarm HA timers on the storage free path wen.yang
2026-11-20 16:55 ` Gabriele Monaco
2026-11-05 17:49 ` [PATCH v8 05/14] rv: Add a KUnit test for " wen.yang
2026-11-20 17:02 ` Gabriele Monaco [this message]
2026-11-05 17:49 ` [PATCH v8 06/14] rv: Make da_monitor_reset_hook, sync_hook and EVENT_NONE_LBL overridable wen.yang
2026-11-05 17:49 ` [PATCH v8 07/14] rv: Introduce DA_MON_ALLOCATION_STRATEGY wen.yang
2026-11-05 17:49 ` [PATCH v8 08/14] rv: Support embedded target types in per-object DA storage wen.yang
2026-11-20 8:12 ` Gabriele Monaco
2026-11-05 17:49 ` [PATCH v8 09/14] rv: Add generic uprobe infrastructure for RV monitors wen.yang
2026-11-20 12:12 ` Gabriele Monaco
2026-11-05 17:49 ` [PATCH v8 10/14] rv: Add tlob model DOT file wen.yang
2026-11-05 17:49 ` [PATCH v8 11/14] rv: Add tlob hybrid automaton monitor wen.yang
2026-11-20 16:37 ` Gabriele Monaco
2026-11-05 17:49 ` [PATCH v8 12/14] rv: Add KUnit tests for the tlob monitor wen.yang
2026-11-05 17:49 ` [PATCH v8 13/14] selftests/verification: Add tlob selftests wen.yang
2026-11-05 17:49 ` [PATCH v8 14/14] selftests/ftrace: Walk up parent dirs to find test.d/functions wen.yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cb05c823110358e588c651778c981cb278335e9.camel@redhat.com \
--to=gmonaco@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=namcao@linutronix.de \
--cc=wen.yang@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox