From: Gabriele Monaco <gmonaco@redhat.com>
To: Nam Cao <namcao@linutronix.de>
Cc: Steven Rostedt <rostedt@goodmis.org>,
john.ogness@linutronix.de, linux-trace-kernel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/10] rv: raise the number of per-task monitor to 2
Date: Wed, 12 Mar 2025 07:57:14 +0100 [thread overview]
Message-ID: <5ed67309a14e9971fa46bdaf2ae2cd3f5db60fe5.camel@redhat.com> (raw)
In-Reply-To: <8ebb6cc8f566eaf6c62eef8391e930dbac10d66b.1741708239.git.namcao@linutronix.de>
On Tue, 2025-03-11 at 18:05 +0100, Nam Cao wrote:
> There are 2 monitors to check realtime applications. Users may want
> to
> enable them both.
>
> Signed-off-by: Nam Cao <namcao@linutronix.de>
> ---
> include/linux/rv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/rv.h b/include/linux/rv.h
> index 6de4f93b390e..224c2194f582 100644
> --- a/include/linux/rv.h
> +++ b/include/linux/rv.h
> @@ -44,7 +44,7 @@ struct ltl_monitor {
> * adding more or developing a dynamic method. So far, none of
> * these are justified.
> */
> -#define RV_PER_TASK_MONITORS 1
> +#define RV_PER_TASK_MONITORS 2
> #define RV_PER_TASK_MONITOR_INIT (RV_PER_TASK_MONITORS)
>
> union rv_task_monitor {
I was thinking this value could be defined in Kconfig. Here you are
adding two monitors that belong with each other, that would fit nicely
with nested monitors [1] (patch waiting for final Ack).
Your monitor (let's call it rtapp) would require 2 slots and you could
enforce that in Kconfig.
Of course you don't have to add it to this series, but just as a heads up.
Cheers,
Gabriele
[1] - https://lore.kernel.org/lkml/20250218123121.253551-5-gmonaco@redhat.com/
prev parent reply other threads:[~2025-03-12 6:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 17:05 [PATCH 00/10] RV: Linear temporal logic monitors for RT application Nam Cao
2025-03-11 17:05 ` [PATCH 01/10] rv: Add #undef TRACE_INCLUDE_FILE Nam Cao
2025-03-11 17:05 ` [PATCH 02/10] rv: Let the reactors take care of buffers Nam Cao
2025-03-12 7:58 ` Gabriele Monaco
2025-03-13 8:16 ` Nam Cao
2025-03-13 11:39 ` Gabriele Monaco
2025-03-13 16:07 ` kernel test robot
2025-03-13 16:07 ` kernel test robot
2025-03-11 17:05 ` [PATCH 03/10] rv: Add infrastructure for linear temporal logic monitor Nam Cao
2025-03-12 6:47 ` Gabriele Monaco
2025-03-12 9:56 ` Steven Rostedt
2025-03-12 14:29 ` Nam Cao
2025-03-11 17:05 ` [PATCH 04/10] rv: Add rtapp_block monitor Nam Cao
2025-03-12 7:34 ` Gabriele Monaco
2025-03-13 15:15 ` kernel test robot
2025-03-11 17:05 ` [PATCH 05/10] x86/tracing: Remove redundant trace_pagefault_key Nam Cao
2025-03-11 17:05 ` [PATCH 06/10] x86/tracing: Move page fault trace points to generic Nam Cao
2025-03-11 17:05 ` [PATCH 07/10] arm64: mm: Add page fault trace points Nam Cao
2025-03-11 17:05 ` [PATCH 08/10] riscv: " Nam Cao
2025-04-02 7:35 ` Alexandre Ghiti
2025-03-11 17:05 ` [PATCH 09/10] rv: Add rtapp_pagefault monitor Nam Cao
2025-03-11 17:05 ` [PATCH 10/10] rv: raise the number of per-task monitor to 2 Nam Cao
2025-03-12 6:57 ` Gabriele Monaco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ed67309a14e9971fa46bdaf2ae2cd3f5db60fe5.camel@redhat.com \
--to=gmonaco@redhat.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=namcao@linutronix.de \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).