From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Yafang Shao <laoar.shao@gmail.com>,
mhiramat@kernel.org, linux-trace-kernel@vger.kernel.org,
John Stultz <jstultz@google.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Kajetan Puchalski <kajetan.puchalski@arm.com>,
stable@vger.kernel.org
Subject: Re: [PATCH -trace] trace: fix TASK_COMM_LEN in trace event format file
Date: Sat, 11 Feb 2023 14:35:59 -0500 [thread overview]
Message-ID: <6116571c-986b-cdcf-1da8-3ba2ef145f6e@efficios.com> (raw)
In-Reply-To: <20230211143445.51b49a50@gandalf.local.home>
On 2023-02-11 14:34, Steven Rostedt wrote:
> On Fri, 10 Feb 2023 11:27:18 -0500
> Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
>
>>> --- a/include/trace/stages/stage4_event_fields.h
>>> +++ b/include/trace/stages/stage4_event_fields.h
>>> @@ -26,7 +26,8 @@
>>> #define __array(_type, _item, _len) { \
>>> .type = #_type"["__stringify(_len)"]", .name = #_item, \
>>
>> Just out of curiosity, is the content of __stringify(_len) ever used
>> after this patch ? Perhaps we could remove it and just leave:
>>
>> .type = #_type"[]"
>>
>> considering that f_show appears to use the opening square bracket to
>> detect arrays. This would remove a few useless bytes of data.
>
> I agree that we can optimize this. But lets make that a separate patch, and
> not worry about it for this. That's a clean up that can be handled later.
>
> I'd like to not add any more side effects than it may already have.
Fully agreed, hence my "just out of curiosity". :)
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
next prev parent reply other threads:[~2023-02-11 19:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 15:59 [PATCH -trace] trace: fix TASK_COMM_LEN in trace event format file Yafang Shao
2023-02-10 16:27 ` Mathieu Desnoyers
2023-02-11 19:34 ` Steven Rostedt
2023-02-11 19:35 ` Mathieu Desnoyers [this message]
2023-02-10 18:12 ` Kajetan Puchalski
2023-02-10 22:32 ` Alexei Starovoitov
2023-02-11 19:28 ` Steven Rostedt
2023-02-11 20:23 ` Steven Rostedt
2023-02-12 11:42 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6116571c-986b-cdcf-1da8-3ba2ef145f6e@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=alexei.starovoitov@gmail.com \
--cc=jstultz@google.com \
--cc=kajetan.puchalski@arm.com \
--cc=laoar.shao@gmail.com \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).