From: Bean Huo <huobean@gmail.com>
To: Ziqi Chen <quic_ziqichen@quicinc.com>,
quic_asutoshd@quicinc.com, quic_cang@quicinc.com,
bvanassche@acm.org, mani@kernel.org, stanley.chu@mediatek.com,
adrian.hunter@intel.com, beanhuo@micron.com, avri.altman@wdc.com,
junwoo80.lee@samsung.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:TRACING" <linux-trace-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] scsi: ufs: core: Add trace event for MCQ
Date: Tue, 21 Feb 2023 10:49:10 +0100 [thread overview]
Message-ID: <614c6437-d0ba-a75f-8f65-6b47dab0ff99@gmail.com> (raw)
In-Reply-To: <1676959630-35504-1-git-send-email-quic_ziqichen@quicinc.com>
On 21.02.23 7:07 AM, Ziqi Chen wrote:
> +
> + TP_printk(
> + "%s: %s: tag: %u, hwq_id: %d, size: %d, IS: %u, LBA: %llu, opcode: 0x%x (%s), group_id: 0x%x, sq_tail_slot: %d, cq_head_slot: %d, cq_tail_slot: %d",
Hi Ziqi,
Looks good to me, just one thing, the above print strings can be shortened?
hwq_id-->hdid
sq_tail_slot-->sqt
cq_tail_slot->sqt
cq_head_slot->cqh
Kind regards,
Bean
> + show_ufs_cmd_trace_str(__entry->str_t), __get_str(dev_name),
> + __entry->tag, __entry->hwq_id, __entry->transfer_len,
> + __entry->intr, __entry->lba, (u32)__entry->opcode,
> + str_opcode(__entry->opcode), (u32)__entry->group_id,
> + __entry->sq_tail, __entry->cq_head, __entry->cq_tail
> + )
next prev parent reply other threads:[~2023-02-21 9:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 6:07 [PATCH v2] scsi: ufs: core: Add trace event for MCQ Ziqi Chen
2023-02-21 9:49 ` Bean Huo [this message]
2023-02-21 9:55 ` Ziqi Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=614c6437-d0ba-a75f-8f65-6b47dab0ff99@gmail.com \
--to=huobean@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=junwoo80.lee@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mhiramat@kernel.org \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_ziqichen@quicinc.com \
--cc=rostedt@goodmis.org \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox