From: Markus Elfring <Markus.Elfring@web.de>
To: Steven Rostedt <rostedt@goodmis.org>, linux-trace-kernel@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/3] tracing/user_events: Simplify data output in user_seq_show()
Date: Tue, 9 Jun 2026 18:44:04 +0200 [thread overview]
Message-ID: <6762145e-3e51-43b8-8bca-a9dd200b54e2@web.de> (raw)
In-Reply-To: <20260609121348.303ca675@fedora>
>> @@ -2800,8 +2800,7 @@ static int user_seq_show(struct seq_file *m, void *p)
>>
>> mutex_unlock(&group->reg_mutex);
>>
>> - seq_puts(m, "\n");
>> - seq_printf(m, "Active: %d\n", active);
>> + seq_printf(m, "\nActive: %d\n", active);
>> seq_printf(m, "Busy: %d\n", busy);
>
> This isn't a critical section and I find the original way easier to read.
Would you prefer to use a seq_putc() call instead at such a source code place?
https://elixir.bootlin.com/linux/v7.1-rc7/source/kernel/trace/trace_events_user.c#L2803
> But the other two patches are fine.
Thanks for another bit of positive feedback.
Regards,
Markus
next prev parent reply other threads:[~2026-06-09 16:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 12:05 [PATCH 0/3] tracing/user_events: More efficient data output in user_seq_show() Markus Elfring
2026-06-04 12:07 ` [PATCH 1/3] tracing/user_events: Simplify " Markus Elfring
2026-06-09 16:13 ` Steven Rostedt
2026-06-09 16:44 ` Markus Elfring [this message]
2026-06-04 12:10 ` [PATCH 2/3] tracing/user_events: Use seq_putc() " Markus Elfring
2026-06-04 12:12 ` [PATCH 3/3] tracing/user_events: Replace a seq_printf() call by seq_puts() " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6762145e-3e51-43b8-8bca-a9dd200b54e2@web.de \
--to=markus.elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox