From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Steven Rostedt <rostedt@goodmis.org>, Tao Chen <chen.dylane@gmail.com>
Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: Add WARN_ON_ONCE for syscall_nr check
Date: Thu, 28 Nov 2024 11:02:31 -0500 [thread overview]
Message-ID: <67b5a0d7-95a2-46d2-bb4a-69a4368abe3d@efficios.com> (raw)
In-Reply-To: <20241128100324.05bc4c32@gandalf.local.home>
On 2024-11-28 10:03, Steven Rostedt wrote:
> On Thu, 28 Nov 2024 21:15:31 +0800
> Tao Chen <chen.dylane@gmail.com> wrote:
>
>> Hi, Steve, thank you for your reply, as you say, so what about
>> pr_warn_once api just to print something ?
>
> A better solution is for there to be a return code or something where the
> tracers (perf or ftrace) can record in the trace that the system call is
> not supported.
Just be careful not to spam the traces uselessly. E.g. if only the
openat syscall is enabled, you'd only want to be made aware of the
ia32 openat, not all ia32 syscalls.
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
next prev parent reply other threads:[~2024-11-28 16:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 11:53 [PATCH] tracing: Add WARN_ON_ONCE for syscall_nr check Tao Chen
2024-11-28 12:46 ` Steven Rostedt
2024-11-28 13:15 ` Tao Chen
2024-11-28 14:27 ` Mathieu Desnoyers
2024-11-29 2:48 ` Tao Chen
2024-11-28 15:03 ` Steven Rostedt
2024-11-28 16:02 ` Mathieu Desnoyers [this message]
2024-11-28 16:52 ` Steven Rostedt
2024-11-29 2:51 ` Tao Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67b5a0d7-95a2-46d2-bb4a-69a4368abe3d@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=chen.dylane@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).