From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32DE9C63797 for ; Fri, 3 Feb 2023 08:58:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232234AbjBCI6T (ORCPT ); Fri, 3 Feb 2023 03:58:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232124AbjBCI6R (ORCPT ); Fri, 3 Feb 2023 03:58:17 -0500 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 496772196E for ; Fri, 3 Feb 2023 00:58:15 -0800 (PST) Received: by mail-ed1-x52c.google.com with SMTP id f7so4490172edw.5 for ; Fri, 03 Feb 2023 00:58:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blackwall-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1z40xBZl1s88AVKBaaMT4kPg0/IWGeDII88qOAQgOrM=; b=ugJ1ZUxXgqF6M2ADHF0b7CSoiPxc2idiHZ2fRCEKjinDPuJE2buPQtrAgjDPb3eklH yExCa7ATGFczL1g330HeaNsvJYxp3uMmFmpgZ5scL1Gv8BDXq+CM8vi+Yy6zCybrbEE1 yvEnkc+NXR+ivXGx61+N8VusLuYKcwoRKlBJC2qLYRuGCA8ylN4rd7Dusa8F29f1tkss DATUANszgU8rquTfwekSlBTrURvimxxPLYMUDnzTjX3g9e5taFjOLQuY2fUcQVY5dnv2 8vAW/OmHtlY200qBn0iNM/CgVbxDZ8ErDa3qfQMqjybVpO87MwGol2ISPhewfHnDAgQO wz/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1z40xBZl1s88AVKBaaMT4kPg0/IWGeDII88qOAQgOrM=; b=gedVxBM2ct919G8y2rYma4JX+Mk5gmuRvt3wS6tvRs5MP8VKbboufTIzlcdqBRr8OF EVw/UhtRbk+AJLjv0ZzSOn328xxD1aXMVNrXcSYCqEEh40wv9hvdc3oerA7UwD6lmUSf lLoxWHKWN4yVEEOHKLfqadMJwmXUIuOwa9L/pCERd39IDSlhm30VFGS8SC3V+kHOTs+F YIm0QwRKzcT3lj4cq8Jwd0GUnkxJelFMTwsFW86sOWJJUNQEOJekvK5e5MB26n8AZM53 /rJ2V1fhJvQr/TfcgdDEU6pLCIV7aNa4gPGWE5P8F8j4Jk/vy0ECOm11WMbL7LB/uPT0 ZrYA== X-Gm-Message-State: AO0yUKVYytPILiH0pcRGyv2oPIKdXwX6GS5dSsw9DGmyOc3VVjhykNJc Rfr8rzJhbFXYLVzl4xcBhiUAzA== X-Google-Smtp-Source: AK7set/ZmQCxv0xQUirdGsWOY06LUA2AkD+Yj31SlUyBsvKXs195QxZ3dTLxR/WJF3JVqpCmSNj+gA== X-Received: by 2002:a05:6402:3647:b0:49e:eb5:ed05 with SMTP id em7-20020a056402364700b0049e0eb5ed05mr9680658edb.9.1675414693697; Fri, 03 Feb 2023 00:58:13 -0800 (PST) Received: from [192.168.0.161] (62-73-72-43.ip.btc-net.bg. [62.73.72.43]) by smtp.gmail.com with ESMTPSA id k3-20020a056402048300b00499b6b50419sm813274edv.11.2023.02.03.00.58.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Feb 2023 00:58:13 -0800 (PST) Message-ID: <6e50c1ac-9182-0d86-24fb-afcc2c63db85@blackwall.org> Date: Fri, 3 Feb 2023 10:58:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH net-next v3 06/16] net: bridge: Add a tracepoint for MDB overflows Content-Language: en-US To: Petr Machata , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Roopa Prabhu , netdev@vger.kernel.org Cc: bridge@lists.linux-foundation.org, Ido Schimmel , Steven Rostedt , linux-trace-kernel@vger.kernel.org References: From: Nikolay Aleksandrov In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org On 02/02/2023 19:59, Petr Machata wrote: > The following patch will add two more maximum MDB allowances to the global > one, mcast_hash_max, that exists today. In all these cases, attempts to add > MDB entries above the configured maximums through netlink, fail noisily and > obviously. Such visibility is missing when adding entries through the > control plane traffic, by IGMP or MLD packets. > > To improve visibility in those cases, add a trace point that reports the > violation, including the relevant netdevice (be it a slave or the bridge > itself), and the MDB entry parameters: > > # perf record -e bridge:br_mdb_full & > # [...] > # perf script | cut -d: -f4- > dev v2 af 2 src ::ffff:0.0.0.0 grp ::ffff:239.1.1.112/00:00:00:00:00:00 vid 0 > dev v2 af 10 src :: grp ff0e::112/00:00:00:00:00:00 vid 0 > dev v2 af 2 src ::ffff:0.0.0.0 grp ::ffff:239.1.1.112/00:00:00:00:00:00 vid 10 > dev v2 af 10 src 2001:db8:1::1 grp ff0e::1/00:00:00:00:00:00 vid 10 > dev v2 af 2 src ::ffff:192.0.2.1 grp ::ffff:239.1.1.1/00:00:00:00:00:00 vid 10 > > CC: Steven Rostedt > CC: linux-trace-kernel@vger.kernel.org > Signed-off-by: Petr Machata > Reviewed-by: Steven Rostedt (Google) > --- > > Notes: > v2: > - Report IPv4 as an IPv6-mapped address through the IPv6 buffer > as well, to save ring buffer space. > > include/trace/events/bridge.h | 58 +++++++++++++++++++++++++++++++++++ > net/core/net-traces.c | 1 + > 2 files changed, 59 insertions(+) > Acked-by: Nikolay Aleksandrov