From: Markus Elfring <Markus.Elfring@web.de>
To: Josh Law <objecting@objecting.org>,
linux-trace-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Masami Hiramatsu <mhiramat@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v8 2/2] tools/bootconfig: fix fd leak in load_xbc_file() on fstat failure
Date: Wed, 18 Mar 2026 21:02:48 +0100 [thread overview]
Message-ID: <72b44223-5c7d-474b-ad98-adab69700ec9@web.de> (raw)
In-Reply-To: <20260318155847.78065-3-objecting@objecting.org>
> If fstat() fails after open() succeeds, the function returns without
> closing the file descriptor. Also preserve errno across close(), since
> close() may overwrite it before the error is returned.
I find such a change description improvable.
Did anything hinder to use a corresponding goto chain?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v7.0-rc4#n526
https://elixir.bootlin.com/linux/v7.0-rc4/source/tools/bootconfig/main.c#L155-L173
Regards,
Markus
prev parent reply other threads:[~2026-03-18 20:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 15:58 [PATCH v8 0/2] bootconfig: targeted fixes for stable Josh Law
2026-03-18 15:58 ` [PATCH v8 1/2] lib/bootconfig: check xbc_init_node() return in override path Josh Law
2026-03-18 15:58 ` [PATCH v8 2/2] tools/bootconfig: fix fd leak in load_xbc_file() on fstat failure Josh Law
2026-03-18 20:02 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72b44223-5c7d-474b-ad98-adab69700ec9@web.de \
--to=markus.elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=objecting@objecting.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox