From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C639C31AF24 for ; Tue, 14 Jul 2026 05:21:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784006517; cv=none; b=SR5FJze+zz2AUUR6+81EqySB5hDg2/FMihKorlLoBSpd1wwusA68D1+eFzdyoiW4oE5cmoMcSzlSJzEB4t47O3xxvY3ad702y1K/UymV9bH1OrMPrt2eKgTolgUcLyGs65Um6Sp0e5H4ImIVZSGNNuk5QJSfXzv/xB8GfSDMu60= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784006517; c=relaxed/simple; bh=TuAodXskmsk6PpOUP7bcreyJUVtepgakQ0Ia6qBO6yc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rbmWJTtfxVYE8RqNXgw8ulL0BM+xPP2SwrdNmp8TEGVkgtLJtMc/MwRqenoX/vdvMutkoQAN/1Twgh7BLBwEfgDHm+SptJotDODFqjYgl9ks3ShKxITT1dBni2+IUNHiA7vsbuFQMFbJkxCaYi8ucvdfeLyKc/brel+ALBXpXoA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ga7ciTTX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FQVFj787; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ga7ciTTX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FQVFj787" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66E38BJa3482918 for ; Tue, 14 Jul 2026 05:21:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= A9GY5SmmKpXBp0S4UpoTVLYAhXq0hiNnfIA35k/Yeeo=; b=Ga7ciTTXlZHchP5y CXm0Hb5IiuHPAAzHw/LV3WURvZcT8WuNWYzDJ7olnGQ4qtHhZ19Wc5Bg+J4CcEto uMAnHTYeRCPgiAKVmSi3YWrHOm860/8BOSfSUKvQQ9G3Q7cW9XQQT1AaRu1rTSKA uua4CfftwzQmZsW3kuw5kGsNZ/H03sqvD8xT7dIJ+K9axjzEMq84ZQb+Nyykl6GM RzNIzkHkp4QotepVCvPzSznMH0bzwYR4t0ROcXbuTbRzlNyD/oa8PvjMWz9OVKRB GMn1uZyu6jC0c5/vb8GPKUxe8T1ZDSh6J38Fu7kpQRq94YLpol26Ctq81ONeYn5o UKXftw== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fd37xabj1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 14 Jul 2026 05:21:51 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c890bac374eso10148261a12.1 for ; Mon, 13 Jul 2026 22:21:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784006511; x=1784611311; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=A9GY5SmmKpXBp0S4UpoTVLYAhXq0hiNnfIA35k/Yeeo=; b=FQVFj787dafAwEeiJ7rVH5Vi/BBHnlKHlshOHIqs2IdztPoIFAxZBZZbx6Gq92UBf2 dhSWHuK+GPwZQkcBgPs/aIw6VVQQ4ELM7IK2RY4JzwUiwfTbexEvRc+ynl+xcovxCcrl 1EUGM1Up0YRoFK7qWp+fHzC8W8PbNVewVbOAYFAOTFsTDJX6zBiKApJOXQlknel72nGM bEr3cTiaq8HsPx+yrdDK6Jt7JdDW4Oz3hqhOxlMd0ioitny9Bimba7NRVGwPY5EjTamJ Oz1XAOlRp6z+9r/+mFpcgwR/iekOefQFGJYSGvp18r1xfy06l6GsqZKMFoOFiYhg0Fsp cBxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784006511; x=1784611311; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=A9GY5SmmKpXBp0S4UpoTVLYAhXq0hiNnfIA35k/Yeeo=; b=AXx7bqoTc0oXuJuSFIPuYxshDjOOJ/yEYhYw1HSoCJqsy0E2bMtVVuermAzc00TR/Y EAKL8wgJ8ySwmS/DHrogRsiUDbMFU+YbhdHf/rfScckNsrkf0ssDEmpwgVDgPvxtd6di Rk0u5XS5lmfcCDY702aOoryuLipLjMJhB0vqPXUuKAbFw796TqAob8FHDVgxgj60yOO9 cEKhS2S0U9v+98obaPJ3X6dj6zMo//fladwWPNGBr6lsfRtsYhTe8quDGbtdm+CbpGaI QbMlHK+8GllJabadb5vR1A4n+NFUtAtoaZMkxm5g6rSkD8U5aN5UgyAFS6joE+EPwOcN FV2Q== X-Forwarded-Encrypted: i=1; AHgh+Rpr5QOqdH1Tj/4bGPGlcGXnyqPJUPxy1WlcipW4be9Gb/yf9O+PhLTHj4d6DlFbCCzRqXOZX9Ji0jhA5I0afaWod0o=@vger.kernel.org X-Gm-Message-State: AOJu0YzjA5RS8ZU2bZMWRNDEb8M7BPI1EkkhoTbc0pQV8x4WADdVDUDJ fzLUYVmPvr9x1/CBUSsTGWDXDY0yxkQX9xMIe+ZbphZJP/WMbyXx/011Oe9Z8YeLoo8ioR0ttDh v6imCXB2yB+jGK0vNGHRDGIS3pCEtIyJQshld10TNQp6yqTQi+PIZEyIutbXkxlEZ930NV8rjUu c= X-Gm-Gg: AfdE7cnCOb36Y62XiaXVok9ZpMN53hyPweMzkTruNVvDVcRji7ISVUMDjGOQrqRRl++ xZasvO5xQrf1Aq/SW9L4waOHQ2Lve39ppom1cdrQ5diyWhCLgtSHzmdv+1YrUk66cTYFwz+ls0y GAHOI+SBqr3IfVwxIrC9ns+AXEFky3KlGNq8ouV4ofIdBBSWJTerG4WOdh8Ej50d4cZwmMqtjV/ V0xouXY7G7CvX6wLFxczzRba+naZ1KaIj3zgTb8akSPkozuUft+EOhBtQJmJkbV+wYJn+Z20p5E iYyDTLUB//LeDomd1dcz4FsjajahITTjOfHVG1BJSslLexIEDorR3vQFf6Yjh4M5JeNri2a58XO uGNmYezgXaURZB3fT2SHZksWVlMpBURYIssdDlccqhQ== X-Received: by 2002:a05:6a21:4cca:b0:3c0:9c19:65b9 with SMTP id adf61e73a8af0-3c110a66059mr12624714637.65.1784006510617; Mon, 13 Jul 2026 22:21:50 -0700 (PDT) X-Received: by 2002:a05:6a21:4cca:b0:3c0:9c19:65b9 with SMTP id adf61e73a8af0-3c110a66059mr12624675637.65.1784006510017; Mon, 13 Jul 2026 22:21:50 -0700 (PDT) Received: from [10.92.197.28] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3120c8e41fcsm42074011eec.15.2026.07.13.22.21.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2026 22:21:49 -0700 (PDT) Message-ID: <788b1ebb-db13-4f6f-9e92-46802d7027f6@oss.qualcomm.com> Date: Tue, 14 Jul 2026 10:51:42 +0530 Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] spi: qcom-geni: add GENI SE registers trace event on error paths To: Mark Brown Cc: Bjorn Andersson , Konrad Dybcio , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mukesh Kumar Savaliya , Konrad Dybcio References: <20260711-add-tracepoints-for-se-reg-dump-v2-0-ca1e9ba62359@oss.qualcomm.com> <20260711-add-tracepoints-for-se-reg-dump-v2-2-ca1e9ba62359@oss.qualcomm.com> <4bcaa245-2127-45aa-bf05-48e275c0129c@oss.qualcomm.com> <72cb70b0-d89d-405b-b2b9-807e028d6fd3@sirena.org.uk> Content-Language: en-US From: Praveen Talari In-Reply-To: <72cb70b0-d89d-405b-b2b9-807e028d6fd3@sirena.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE0MDA1MSBTYWx0ZWRfX3jNgOIRMvXck NUNyKWnnbn6pEgpWph1dPyq96HdoXHldhdp1NmWnWfchP5u8Pa+QVimAVJG7XJUll50cOFbo6dj EW3a2Ap/PycWJUJ3NPTVM/mlrfViprSBlMEVfqee9dvsj2Qy17y/oehZizzScJyHHBwcbtaNCZl MlHkXIvgV88NJ25PfYGbdH6z6dQ0cbJNm8yn9cd/ZWGOjkbJER2KcDke0QYUc2bbAsICoWWCkRy sNm1dhlc28PyMyqcn5q+3cTcoPzRMN3lNLB2wQ/nK1kT7FX4HEP4/Q/HUE8it9XxFKjJKH/xV6T 3hx2IgqWN1QOJqIhZbuuWh3qeuaGKce4kGw7Jkr2lFzKZ+YImFbLd4O5g1uN1jGjtmVDJVi1gb8 4B6jcmgDmliCfEB4330dlc5a+xPMtmMb/LyRrm2fouBtEcKOrSlymzPSFqd0dv5yIQXIcl1M2Yu 4nagjQ1zyOHDLADoxcw== X-Authority-Analysis: v=2.4 cv=BNWDalQG c=1 sm=1 tr=0 ts=6a55c76f cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=JsoTjjDMo91fjAJr_joA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-ORIG-GUID: U_gH29kaUVKcqa3D0AQilusf8SS6fJ0C X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE0MDA1MSBTYWx0ZWRfXz2yXV9Y7KbgY xpR8Ft1VT+HDjUcgVGwCSOOUsVakDrjJlY1V3lmMJp286y6/OREk4BHkfdhx+dCMfz5YwT468ou sTOvTK1SwlkeVe3i/7FUWH1ollZMn4c= X-Proofpoint-GUID: U_gH29kaUVKcqa3D0AQilusf8SS6fJ0C X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-14_01,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 phishscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607140051 Hi On 13-07-2026 16:16, Mark Brown wrote: > On Sat, Jul 11, 2026 at 08:21:02AM +0530, Praveen Talari wrote: >> On 11-07-2026 02:56, Mark Brown wrote: >>> On Sat, Jul 11, 2026 at 12:18:42AM +0530, Praveen Talari wrote: >>>> +#include >>> Should this be in rivers/soc/qcom/qcom-geni-se.c (and the first patch?) >>> - that way if another driver starts using them we won't multiply define >>> the tracepoints. >> Yes, you are correct but >> If this header in drivers/soc/qcom/qcom-geni-se.c, how it will be access >> trace API in other drivers like i2c, spi and uart? > The header needs to be in the users but the CREATE_ define that you cut > needs to be in only one place to actually create the tracepoints. Sure, got it. > >>>> @@ -986,10 +997,13 @@ static irqreturn_t geni_spi_isr(int irq, void *data) >>>> writel(0, se->base + SE_GENI_TX_WATERMARK_REG); >>>> dev_err(mas->dev, "Premature done. tx_rem = %d bpw%d\n", >>>> mas->tx_rem_bytes, mas->cur_bits_per_word); >>>> + trace_geni_se_regs(se); >>> SE_GENI_TX_WATERMARK_REG is one of the registers in the tracepoint, >>> perhaps trace before we write to clear it? >> it will be captured in m_irq register so it is not required to capture. > Are you sure that won't lead to user confusion? No since m_irq can capture most of other bits as well. Thanks, Praveen talari