From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3FD03E0C74; Mon, 2 Mar 2026 14:02:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772460165; cv=none; b=OrF0z/yOswTVWV2zv46ez2XbpE0Ji0gMdV5GwkmYZBFyr43ygMVmnX5gvTkYyEuQxbuFdDbSmoHAGD4RBBP1Aky2nxcyQWlkk8RhIb9onMZygWBYi1sqIFM2dZ5Zea1AhFCHEgnMUhva1D0Xc4wOI3mzM/hVVVzyv9NPcW6LTmk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772460165; c=relaxed/simple; bh=sziW4pOUkxTp9O8LXGHmN/0KGKu2HZcxR9I6yaCXqP0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=od7oUS0nqsuC/2nAT+T5mQkZnhEpAnQGJbdmWjDJBZ7CiIBxyPmq+e8sutmcX7qSdBnRbf/r8+H8I5HEk9K8Fnj89NmJEZr6JpnaXm17TnVkNLrDXsFg4FMgQPCim6BpXpW1MQhYy39ZN2ffksoAYoingsR5K9QoJVKiUTkm1ak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=J3sPEAkp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="J3sPEAkp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4835AC19423; Mon, 2 Mar 2026 14:02:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772460165; bh=sziW4pOUkxTp9O8LXGHmN/0KGKu2HZcxR9I6yaCXqP0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=J3sPEAkp7ZXe2WdNJfY0wlkY+4gPNTR4C2pJ1PdyTfXB4N+0vvY4E583r8pFrOTd6 2fcEoG7epPt1Jr32IIY9UlFEt7QtPxpW0ADSrLZZVXVqE2Ac1Lej86lq9gfkrIj4kZ ojjYIPYUX2o0kCs2MEfhBq1HIe5aI3LgGR+rUTtyNvdskd/j2xtKi40ILxobWdcnKx VpORqxQ4YXNmiVwZqzkAOAhoMvtb72XzRfk+IYI88iHnEqU8HbTl3V7WBWSfuC/DKx PqLL2ESytNeNAe9u0Y52x+9ZxNdqX4L94I6LC+SFQGc0T8ntIHIrBa6E5Sj+Om5xLd t4iYJo49n6tFg== Message-ID: <7cacd42c-642d-421a-9180-ecf044eda00e@kernel.org> Date: Mon, 2 Mar 2026 15:02:38 +0100 Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/5] mm: convert compaction to zone lock wrappers Content-Language: en-US To: Dmitry Ilvokhin , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Axel Rasmussen , Yuanchu Xie , Wei Xu , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Brendan Jackman , Johannes Weiner , Zi Yan , Oscar Salvador , Qi Zheng , Shakeel Butt Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-pm@vger.kernel.org, "linux-cxl@vger.kernel.orgkernel-team"@meta.com References: <3a09e46f52cf9f709b0725bc2b648cc5212843b2.1772206930.git.d@ilvokhin.com> From: "Vlastimil Babka (SUSE)" In-Reply-To: <3a09e46f52cf9f709b0725bc2b648cc5212843b2.1772206930.git.d@ilvokhin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/27/26 17:00, Dmitry Ilvokhin wrote: > Compaction uses compact_lock_irqsave(), which currently operates > on a raw spinlock_t pointer so it can be used for both zone->lock > and lruvec->lru_lock. Since zone lock operations are now wrapped, > compact_lock_irqsave() can no longer directly operate on a > spinlock_t when the lock belongs to a zone. > > Split the helper into compact_zone_lock_irqsave() and > compact_lruvec_lock_irqsave(), duplicating the small amount of > shared logic. As there are only two call sites and both statically > know the lock type, this avoids introducing additional abstraction > or runtime dispatch in the compaction path. > > No functional change intended. > > Signed-off-by: Dmitry Ilvokhin > Acked-by: Shakeel Butt Reviewed-by: Vlastimil Babka (SUSE)