From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Ian Rogers <irogers@google.com>
Subject: Re: [PATCH v9 2/4] ring-buffer: Flush and stop persistent ring buffer on panic
Date: Wed, 18 Mar 2026 11:51:28 -0400 [thread overview]
Message-ID: <831523cf-110c-419d-9b22-e54f93a3bdb5@efficios.com> (raw)
In-Reply-To: <20260319002918.5768a8ee053dd35373e215f2@kernel.org>
On 2026-03-18 11:29, Masami Hiramatsu (Google) wrote:
>>
>> - AFAIU, you are not trying to evince cache lines after creation
>> of a new virtual mapping (which is the documented intent of
>> flush_cache_vmap).
>
> Ah, OK. That's a good point!
> (anyway I will replace it with do { } while (0) in the next version.)
>
>>
>> - AFAIU flush_cache_vmap maps to no-code on arm64 (asm-generic), what am
>> I missing ? It makes sense to be a no-op because AFAIR arm64 does not
>> have to deal with virtually aliasing caches.
>
> Yeah, so my patch also introduces arm64 specific implementation.
Just make sure to call this something else than "flush_cache_vmap",
because you don't want to slow down vmap on arm64 which does not
require to evince and certainly not write back cache lines after
creation of a new virtual mapping.
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
next prev parent reply other threads:[~2026-03-18 15:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 1:32 [PATCH v9 0/4] ring-buffer: Making persistent ring buffers robust Masami Hiramatsu (Google)
2026-03-11 1:32 ` [PATCH v9 1/4] ring-buffer: Fix to update per-subbuf entries of persistent ring buffer Masami Hiramatsu (Google)
2026-03-11 1:32 ` [PATCH v9 2/4] ring-buffer: Flush and stop persistent ring buffer on panic Masami Hiramatsu (Google)
2026-03-18 14:19 ` Masami Hiramatsu
2026-03-18 14:53 ` Mathieu Desnoyers
2026-03-18 15:29 ` Masami Hiramatsu
2026-03-18 15:51 ` Mathieu Desnoyers [this message]
2026-03-19 3:36 ` Masami Hiramatsu
2026-03-11 1:32 ` [PATCH v9 3/4] ring-buffer: Skip invalid sub-buffers when validating persistent ring buffer Masami Hiramatsu (Google)
2026-03-11 1:32 ` [PATCH v9 4/4] ring-buffer: Add persistent ring buffer selftest Masami Hiramatsu (Google)
2026-03-16 23:21 ` [PATCH v9 0/4] ring-buffer: Making persistent ring buffers robust Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831523cf-110c-419d-9b22-e54f93a3bdb5@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox