Linux Trace Kernel
 help / color / mirror / Atom feed
From: Pablo Fraile Alonso <pablo@pablofraile.net>
To: sashiko-reviews@lists.linux.dev
Cc: linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] uprobes/x86: Fix bypass of two-byte opcode validation
Date: Mon, 16 Nov 2026 17:53:58 +0100	[thread overview]
Message-ID: <83290e65-131e-4aea-ba79-e1453445e872@pablofraile.net> (raw)
In-Reply-To: <sashiko-outbox-217334@kernel.org>


On 11/16/26 17:01, sashiko-bot@kernel.org wrote:
> map-1 opcode against good_insns_64 (map 0) instead of good_2byte_insns,

I checked the parent revision and confirmed that the reported REX2 behavior already exists before this patch.

Previously, REX2 map-1 instructions also reached the first OPCODE1(insn) lookup against good_insns_64. The in-place opcode modification in insn_is_nop() is likewise pre-existing and unchanged. Consequently, the examples described here have the same acceptance/rejection results before and after this patch.

This patch specifically addresses the validation bypass for legacy 0x0f-escaped instructions. It leaves REX2 handling unresolved, and I can make that limitation explicit in the commit message.

I agree that prefixed encodings need separate attention. I was already planning a patch for some VEX/EVEX handling issues.


  reply	other threads:[~2026-11-16 16:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 15:40 [PATCH] uprobes/x86: Fix bypass of two-byte opcode validation Pablo Fraile Alonso
2026-11-16 16:01 ` sashiko-bot
2026-11-16 16:53   ` Pablo Fraile Alonso [this message]
2026-11-19 23:59 ` Edgecombe, Rick P

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83290e65-131e-4aea-ba79-e1453445e872@pablofraile.net \
    --to=pablo@pablofraile.net \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox