From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B25E1F0E25; Wed, 1 Jul 2026 07:22:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782890570; cv=none; b=O4nWUDe9PFE4unk8NSpvZQ8fLDW24F9Mj05kU7PUpupdaQIxVzj+LPNRaSRtcdkZLjvAMWwM+vVGFwlZT4GhIehJzxugQlsSD2Q+H9ynKnQnBqp2Xc72ywJMSGt0Si3TKy5vcy+MHk+ZUSTEMeDEQXtA2vuZqgsv8FQhvHmOnm4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782890570; c=relaxed/simple; bh=O95arKx9T5MkaZlIQszzS6sq+z6RycCRVDU6C6dp8F8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Yr25LtyF628Aa5zMjfOH+Bt+vOSF5tKP4QewZsoy/MMnBVkueSU6n4n+8IMBciP59gQ0Rehj9U+aw75IKH5bhvIMx9n2XiM9J6Bxakm1NApEGaUgsXR9nRAsuPZ8brnP+wRR5ROj/UFzM7brtuiFj4BLNN2fR7sfMBuP2ds86rk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=XQmGOI1f; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="XQmGOI1f" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782890567; x=1814426567; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=O95arKx9T5MkaZlIQszzS6sq+z6RycCRVDU6C6dp8F8=; b=XQmGOI1fJisTrg7QqbBAO/xiwGnKkd1huBRxe1AKF615REyyy1lZYgn5 9ECRIcrn/+vXKoNax2f5TBSz6GllKCbXP9mRd6LqUs0hkz5WFNCYypylo fP3gtFtBa1ZbF0hUOp2KKLcy+jyI6q0OK/Yr3jH6UhlGtEBS6hpag5mQT b0utK7oDUy1cRC9KOgfIoRml+t6ontylDeqstUWXIpkO1MOsMQnqaMMze 7qdLsZZ/1Dlphn1YWZkKj+QlH3ndCd+aee45inRzj8WSXKTqph49CiaUA ujun+HAEp57zcZrTIoKyYNX508ngEWRqUasF8aRN37SNoeWOsGpeH4JZO g==; X-CSE-ConnectionGUID: GrWMUMXgRCeihJM3gMGeww== X-CSE-MsgGUID: QNDaZU24SEiAlOB9gOE5jw== X-IronPort-AV: E=McAfee;i="6800,10657,11833"; a="94212705" X-IronPort-AV: E=Sophos;i="6.24,235,1774335600"; d="scan'208";a="94212705" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2026 00:22:46 -0700 X-CSE-ConnectionGUID: OCgLTDNcQc+i2MkkRhnhSQ== X-CSE-MsgGUID: ze+nbZzkTA6u9tCtlTgwPQ== X-ExtLoop1: 1 Received: from unknown (HELO [10.239.158.49]) ([10.239.158.49]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2026 00:22:29 -0700 Message-ID: <8494b247-64b5-4a04-b964-1f778c17acc3@intel.com> Date: Wed, 1 Jul 2026 15:22:26 +0800 Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 08/46] KVM: Provide generic interface for checking memory private/shared status To: ackerleytng@google.com, aik@amd.com, andrew.jones@linux.dev, binbin.wu@linux.intel.com, brauner@kernel.org, chao.p.peng@linux.intel.com, david@kernel.org, jmattson@google.com, jthoughton@google.com, michael.roth@amd.com, oupton@kernel.org, pankaj.gupta@amd.com, qperret@google.com, rick.p.edgecombe@intel.com, rientjes@google.com, shivankg@amd.com, steven.price@arm.com, tabba@google.com, willy@infradead.org, wyihan@google.com, yan.y.zhao@intel.com, forkloop@google.com, pratyush@kernel.org, suzuki.poulose@arm.com, aneesh.kumar@kernel.org, liam@infradead.org, Paolo Bonzini , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jonathan Corbet , Shuah Khan , Shuah Khan , Vishal Annapurve , Andrew Morton , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Youngjun Park , Qi Zheng , Shakeel Butt , Kiryl Shutsemau , Baoquan He , Jason Gunthorpe , Vlastimil Babka Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev References: <20260618-gmem-inplace-conversion-v8-0-9d2959357853@google.com> <20260618-gmem-inplace-conversion-v8-8-9d2959357853@google.com> Content-Language: en-US From: Xiaoyao Li In-Reply-To: <20260618-gmem-inplace-conversion-v8-8-9d2959357853@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/19/2026 8:31 AM, Ackerley Tng via B4 Relay wrote: > From: Sean Christopherson > > Introduce a generic kvm_mem_is_private() interface using a static call to > determine if a GFN is private. This allows the implementation for checking > a GFN's private/shared status to be set at runtime. > > In preparation for choosing implementations between a guest_memfd lookup > and the existing VM attribute lookup, rename the existing > VM-attribute-based check to kvm_vm_mem_is_private to emphasize that it > looks up VM attributes. > > Signed-off-by: Sean Christopherson Reviewed-by: Xiaoyao Li One nit below. > --- > include/linux/kvm_host.h | 12 +++++++++++- > virt/kvm/kvm_main.c | 15 +++++++++++++++ > 2 files changed, 26 insertions(+), 1 deletion(-) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index eb26d4ea8945a..3915da2a61778 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -2546,7 +2546,7 @@ bool kvm_arch_pre_set_memory_attributes(struct kvm *kvm, > bool kvm_arch_post_set_memory_attributes(struct kvm *kvm, > struct kvm_gfn_range *range); > > -static inline bool kvm_mem_is_private(struct kvm *kvm, gfn_t gfn) > +static inline bool kvm_vm_mem_is_private(struct kvm *kvm, gfn_t gfn) > { > return kvm_get_vm_memory_attributes(kvm, gfn) & KVM_MEMORY_ATTRIBUTE_PRIVATE; > } > @@ -2557,6 +2557,16 @@ static inline bool kvm_mem_range_is_private(struct kvm *kvm, gfn_t start, > KVM_MEMORY_ATTRIBUTE_PRIVATE, > KVM_MEMORY_ATTRIBUTE_PRIVATE); > } > +#endif /* CONFIG_KVM_VM_MEMORY_ATTRIBUTES */ Since it stops the original #define scope of CONFIG_KVM_VM_MEMORY_ATTRIBUTES here, ... > +#ifdef kvm_arch_has_private_mem > +typedef bool (kvm_mem_is_private_t)(struct kvm *kvm, gfn_t gfn); > +DECLARE_STATIC_CALL(__kvm_mem_is_private, kvm_mem_is_private_t); > + > +static inline bool kvm_mem_is_private(struct kvm *kvm, gfn_t gfn) > +{ > + return static_call(__kvm_mem_is_private)(kvm, gfn); > +} > #else > static inline bool kvm_mem_is_private(struct kvm *kvm, gfn_t gfn) > { ... we need to update the comment of #endif to match with the new scope kvm_arch_has_private_mem as below. Or just delete the comment. --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h @@ -2572,7 +2572,7 @@ static inline bool kvm_mem_is_private(struct kvm *kvm, gfn_t gfn) { return false; } -#endif /* CONFIG_KVM_VM_MEMORY_ATTRIBUTES */ +#endif /* kvm_arch_has_private_mem */ #ifdef CONFIG_KVM_GUEST_MEMFD int kvm_gmem_get_pfn(struct kvm *kvm, struct kvm_memory_slot *slot,