From: "Naik, Avadhut" <avadnaik@amd.com>
To: "Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>,
Avadhut Naik <avadhut.naik@amd.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-trace-kernel@vger.kernel.org"
<linux-trace-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bp@alien8.de" <bp@alien8.de>, "Luck, Tony" <tony.luck@intel.com>,
"rafael@kernel.org" <rafael@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"lenb@kernel.org" <lenb@kernel.org>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"james.morse@arm.com" <james.morse@arm.com>,
"airlied@gmail.com" <airlied@gmail.com>,
"yazen.ghannam@amd.com" <yazen.ghannam@amd.com>,
"john.allen@amd.com" <john.allen@amd.com>
Subject: Re: [PATCH v5 1/5] x86/mce: Add wrapper for struct mce to export vendor specific info
Date: Tue, 15 Oct 2024 13:14:01 -0500 [thread overview]
Message-ID: <86df5bba-1750-4dc9-ba3c-b357f562748c@amd.com> (raw)
In-Reply-To: <CY8PR11MB713406B2C492D55428397AFA89452@CY8PR11MB7134.namprd11.prod.outlook.com>
[...]
On 10/15/2024 01:53, Zhuo, Qiuxu wrote:
>> From: Avadhut Naik <avadhut.naik@amd.com>
>> [...]
>> [...]
>> static __always_inline int
>> -__mc_scan_banks(struct mce *m, struct pt_regs *regs, struct mce *final,
>> +__mc_scan_banks(struct mce_hw_err *err, struct pt_regs *regs, struct mce *final,
>
> The 'final' parameter should also be a pointer to this_cpu_ptr(&hw_errs_seen).
> So, it's the final value with an entire 'mce_hw_err' structure stored to
> ' hw_errs_seen ', not just a 'mce' structure got stored in 'hw_errs_seen'.
>
> So,
> __mc_scan_banks(struct mce_hw_err *err, struct pt_regs *regs, struct mce_hw_err *final, ...
>
Thanks for pointing this out. This may require a few other changes too.
Will address them in the next revision.
>> unsigned long *toclear, unsigned long *valid_banks, int no_way_out,
>> int *worst)
>> [...]
--
Thanks,
Avadhut Naik
next prev parent reply other threads:[~2024-10-15 18:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 18:12 [PATCH v5 0/5] MCE wrapper and support for new SMCA syndrome MSRs Avadhut Naik
2024-10-01 18:12 ` [PATCH v5 1/5] x86/mce: Add wrapper for struct mce to export vendor specific info Avadhut Naik
2024-10-14 6:04 ` Zhuo, Qiuxu
2024-10-14 17:03 ` Naik, Avadhut
2024-10-15 6:53 ` Zhuo, Qiuxu
2024-10-15 9:48 ` Borislav Petkov
2024-10-15 18:14 ` Naik, Avadhut [this message]
2024-10-01 18:12 ` [PATCH v5 2/5] tracing: Add __print_dynamic_array() helper Avadhut Naik
2024-10-02 15:06 ` Steven Rostedt
2024-10-02 16:29 ` Steven Rostedt
2024-10-02 16:35 ` Naik, Avadhut
2024-10-01 18:12 ` [PATCH v5 3/5] x86/mce, EDAC/mce_amd: Add support for new MCA_SYND{1,2} registers Avadhut Naik
2024-10-01 18:12 ` [PATCH v5 4/5] x86/mce/apei: Handle variable register array size Avadhut Naik
2024-10-01 18:12 ` [PATCH v5 5/5] EDAC/mce_amd: Add support for FRU Text in MCA Avadhut Naik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86df5bba-1750-4dc9-ba3c-b357f562748c@amd.com \
--to=avadnaik@amd.com \
--cc=airlied@gmail.com \
--cc=avadhut.naik@amd.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=john.allen@amd.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mingo@redhat.com \
--cc=qiuxu.zhuo@intel.com \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox