From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Jens Axboe <axboe@kernel.dk>, Damien Le Moal <dlemoal@kernel.org>
Cc: "rostedt@goodmis.org" <rostedt@goodmis.org>,
"mhiramat@kernel.org" <mhiramat@kernel.org>,
"mathieu.desnoyers@efficios.com" <mathieu.desnoyers@efficios.com>,
"johannes.thumshirn@wdc.com" <johannes.thumshirn@wdc.com>,
Chaitanya Kulkarni <ckulkarnilinux@gmail.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-trace-kernel@vger.kernel.org"
<linux-trace-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] blktrace: log dropped REQ_OP_ZONE_XXX events ver1
Date: Tue, 23 Dec 2025 02:13:38 +0000 [thread overview]
Message-ID: <874ee16d-0a76-4139-b802-83c854e271fb@nvidia.com> (raw)
In-Reply-To: <03a59f8b-c139-43e0-94cb-80cee108f939@kernel.dk>
On 12/22/25 3:28 PM, Jens Axboe wrote:
>>> */
>>> strreplace(buts->name, '/', '_');
>>>
>>> + if (version == 1 && IS_ENABLED(CONFIG_BLK_DEV_ZONED)) {
>>> + pr_info("%s: blktrace events for REQ_OP_ZONE_XXX will be dropped\n",
>>> + name);
>>> + pr_info("use blktrace tools version >= 2 to track REQ_OP_ZONE_XXX\n");
>> Please change REQ_OP_ZONE_XXX to "zone operations" in these messages. That is a
>> little more general, so better I think since we also trace zone write
>> plug/unplug events, which are not REQ_OP_ZONE_XXX.
> Agree, REQ_OP_ZONE_XXX means nothing in userspace.
>
> -- Jens Axboe
Thanks Damien and Jens for comment.
Will send out V3 soon.
-ck
prev parent reply other threads:[~2025-12-23 2:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 17:32 [PATCH V2] blktrace: log dropped REQ_OP_ZONE_XXX events ver1 Chaitanya Kulkarni
2025-10-29 6:47 ` Johannes Thumshirn
2025-12-19 23:50 ` Chaitanya Kulkarni
2025-12-19 23:55 ` Damien Le Moal
2025-12-22 23:28 ` Jens Axboe
2025-12-23 2:13 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ee16d-0a76-4139-b802-83c854e271fb@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=ckulkarnilinux@gmail.com \
--cc=dlemoal@kernel.org \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox